chore: disable cycle dependency error for eslint (#227)

* chore: disable cycle dependency error for eslint

* chore: remove done from async function

* chore: downgrade @testing-library/react to 12 for react@16 support

* fix: update integration test selection and waiting

---------

Co-authored-by: Ben Warzeski <bwarzesk@gmail.com>

src/test/app.test.jsx

@@ -191,8 +191,12 @@ const initialize = async () => {
  * Wait for the review page to show and update the top-level state object.
  */
 const makeTableSelections = async () => {
-  [0, 1, 2, 3, 4].forEach(index => userEvent.click(inspector.listView.listCheckbox(index)));
-  userEvent.click(inspector.listView.selectedBtn(5));
+  [0, 1, 2, 3, 4].forEach(
+    index => userEvent.click(inspector.listView.listCheckbox(index))
+  );
+
+  await inspector.find.listView.selectedBtn(5);
+  await userEvent.click(inspector.listView.selectedBtn(5));
   // wait for navigation, which will show while request is pending
   try {
     await inspector.find.review.prevNav();
@@ -480,10 +484,10 @@ describe('ESG app integration tests', () => {
           await resolveFns.lock.success();
         }
         /*
-          test('submit pending', async (done) => {
+          test('submit pending', async () => {
             done();
           });
-          test('submit failed', async (done) => {
+          test('submit failed', async () => {
             done();
           });
         */

src/test/inspector.js

@@ -92,6 +92,7 @@ class Inspector {
     return {
       listView: {
         viewAllResponsesBtn: () => this.findByText(appMessages.ListView.viewAllResponses),
+        selectedBtn: (num) => this.findByText(`View selected responses (${num})`),
         loadErrorHeading: () => this.findByText(appMessages.ListView.loadErrorHeading),
       },
       review: {