Log api request errors to New Relic and display load error (#24)

TNL-7114 Logs any failed api request to New Relic. Show error in CourseContainer instead of a spinner when a course fails to load.
This commit is contained in:
Adam Butterworth
2020-03-09 12:43:02 -04:00
committed by GitHub
parent 6082ade9e0
commit fcddc2d639
4 changed files with 51 additions and 23 deletions

View File

@@ -1,3 +1,4 @@
import { logError } from '@edx/frontend-platform/logging';
import {
fetchCourseBlocksRequest,
fetchCourseBlocksSuccess,
@@ -25,7 +26,8 @@ export function fetchCourseBlocks(courseUsageKey) {
const courseBlocks = await getCourseBlocks(courseUsageKey);
dispatch(fetchCourseBlocksSuccess(courseBlocks));
} catch (error) {
dispatch(fetchCourseBlocksFailure(error));
logError(error);
dispatch(fetchCourseBlocksFailure(courseUsageKey));
}
};
}
@@ -41,7 +43,8 @@ export function fetchSequenceMetadata(sequenceBlockId) {
relatedBlocksMetadata: sequenceMetadata.items,
}));
} catch (error) {
dispatch(fetchBlockMetadataFailure({ blockId: sequenceBlockId }, error));
logError(error);
dispatch(fetchBlockMetadataFailure({ blockId: sequenceBlockId }));
}
};
}
@@ -63,7 +66,8 @@ export function checkBlockCompletion(courseUsageKey, sequenceId, unitId) {
},
}));
} catch (error) {
dispatch(fetchBlockMetadataFailure(commonPayload, error));
logError(error);
dispatch(fetchBlockMetadataFailure(commonPayload));
}
};
}
@@ -82,6 +86,7 @@ export function saveSequencePosition(courseUsageKey, sequenceId, position) {
await updateSequencePosition(courseUsageKey, sequenceId, position);
dispatch(updateBlockSuccess(actionPayload));
} catch (error) {
logError(error);
dispatch(updateBlockFailure(actionPayload));
}
};
@@ -100,6 +105,7 @@ export function addBookmark(unitId) {
await createBookmark(unitId);
dispatch(updateBlockSuccess(actionPayload));
} catch (error) {
logError(error);
dispatch(updateBlockFailure(actionPayload));
}
};
@@ -118,6 +124,7 @@ export function removeBookmark(unitId) {
await deleteBookmark(unitId);
dispatch(updateBlockSuccess(actionPayload));
} catch (error) {
logError(error);
dispatch(updateBlockFailure(actionPayload));
}
};

View File

@@ -1,4 +1,5 @@
/* eslint-disable import/prefer-default-export */
import { logError } from '@edx/frontend-platform/logging';
import {
fetchCourseMetadataRequest,
fetchCourseMetadataSuccess,
@@ -15,7 +16,8 @@ export function fetchCourseMetadata(courseUsageKey) {
const courseMetadata = await getCourseMetadata(courseUsageKey);
dispatch(fetchCourseMetadataSuccess(courseMetadata));
} catch (error) {
dispatch(fetchCourseMetadataFailure(error));
logError(error);
dispatch(fetchCourseMetadataFailure({ courseUsageKey }));
}
};
}