Andal.LND/frontend-app-learning
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Format may not be defined. Provide a default and only add to URL if it exists (#178)

Browse Source
This commit is contained in:
Dillon Dumesnil
2020-08-12 09:49:21 -07:00
committed by GitHub
parent 3b34a87391
commit a975b8ae70
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/courseware/course/sequence/Unit.jsx
View File

@@ -57,7 +57,10 @@ function Unit({
id,
intl,
}) {
const iframeUrl = `${getConfig().LMS_BASE_URL}/xblock/${id}?show_title=0&show_bookmark_button=0&format=${format}`;
let iframeUrl = `${getConfig().LMS_BASE_URL}/xblock/${id}?show_title=0&show_bookmark_button=0`;
if (format) {
iframeUrl += `&format=${format}`;
}
const [iframeHeight, setIframeHeight] = useState(0);
const [hasLoaded, setHasLoaded] = useState(false);
@@ -151,13 +154,14 @@ function Unit({
Unit.propTypes = {
courseId: PropTypes.string.isRequired,
format: PropTypes.string.isRequired,
format: PropTypes.string,
id: PropTypes.string.isRequired,
intl: intlShape.isRequired,
onLoaded: PropTypes.func,
};
Unit.defaultProps = {
format: null,
onLoaded: undefined,
};