Improving file organization.

This commit is contained in:
David Joy
2020-01-10 11:52:37 -05:00
parent 0db7cabf29
commit 990cef31a3
12 changed files with 162 additions and 400 deletions

View File

@@ -6,7 +6,7 @@ import { faChevronRight } from '@fortawesome/free-solid-svg-icons';
import { getConfig } from '@edx/frontend-platform';
import CourseStructureContext from './CourseStructureContext';
import { useBlockAncestry } from './hooks';
import { useBlockAncestry } from './data/hooks';
const CourseBreadcrumbs = () => {
const { courseId, unitId } = useContext(CourseStructureContext);

View File

@@ -4,12 +4,10 @@ import { injectIntl, intlShape } from '@edx/frontend-platform/i18n';
import PageLoading from './PageLoading';
import messages from './messages';
import CourseBreadcrumbs from './CourseBreadcrumbs';
import SubSection from './SubSection';
import { useCourseStructure } from './hooks';
import CourseStructureContext from './CourseStructureContext';
import { useCourseStructure } from './data/hooks';
import SubSection from './sub-section/SubSection';
function LearningSequencePage({ match, intl }) {
const {

View File

@@ -1,239 +0,0 @@
import React, { Component, useContext, useEffect, useState } from 'react';
import PropTypes from 'prop-types';
import { getConfig } from '@edx/frontend-platform';
import SubSectionNavigation from './SubSectionNavigation';
import { getSubSectionMetadata } from './api';
import CourseStructureContext from './CourseStructureContext';
import Unit from './Unit';
function useSubSectionMetadata(courseId, subSectionId) {
const [metadata, setMetadata] = useState(null);
const [loaded, setLoaded] = useState(false);
useEffect(() => {
setLoaded(false);
getSubSectionMetadata(courseId, subSectionId).then((data) => {
setMetadata(data);
setLoaded(true);
});
}, [courseId, subSectionId]);
return {
metadata,
loaded,
};
}
function useExamRedirect(metadata, blocks) {
useEffect(() => {
if (metadata !== null && blocks !== null) {
if (metadata.isTimeLimited) {
global.location.href = blocks[metadata.itemId].lmsWebUrl;
}
}
}, [metadata, blocks]);
}
/*
const calculateUnitId = (metadata, options) => {
const { first, last, preferredUnitId } = options;
let position = metadata.position - 1; // metadata's position is 1's indexed
position = first ? 0 : position;
position = last ? metadata.unitIds.length - 1 : position;
position = preferredUnitId ? metadata.unitIds.indexOf(preferredUnitId) : position;
const unitId = metadata.items[position].id;
return unitId;
}
handleUnitChange = (unitId) => {
this.setState({
unitId,
});
}
*/
export default function SubSection() {
const {
courseId,
subSectionId,
unitId,
blocks,
} = useContext(CourseStructureContext);
const { metadata } = useSubSectionMetadata(courseId, subSectionId);
useExamRedirect(metadata, blocks);
if (blocks === null || metadata === null) {
return null;
}
const unit = blocks[unitId];
// units={this.state.units}
// unitIds={this.state.subSectionMetadata.unitIds}
// activeUnitId={this.state.unitId}
// unitClickHandler={this.handleUnitChange}
// nextClickHandler={this.handleNextClick}
// previousClickHandler={this.handlePreviousClick}
return (
<section>
<SubSectionNavigation />
<Unit id={unitId} unit={unit} />
</section>
);
}
/*
<h1>{course.displayName}</h1>
<Breadcrumbs
links={[
{ label: course.displayName, url: global.location.href },
{ label: chapter.displayName, url: global.location.href },
{ label: subSection.displayName, url: global.location.href },
]}
activeLabel={currentUnit.pageTitle}
/>
<SubSectionNavigation
units={this.state.units}
unitIds={this.state.subSectionMetadata.unitIds}
activeUnitId={this.state.unitId}
unitClickHandler={this.handleUnitChange}
nextClickHandler={this.handleNextClick}
previousClickHandler={this.handlePreviousClick}
/>
<iframe
title="yus"
ref={this.iframeRef}
src={iframeUrl}
/>
*/
// constructor(props, context) {
// super(props, context);
// // this.state = {
// // loading: true,
// // blocks: {},
// // units: {},
// // subSectionMetadata: null,
// // subSectionId: null,
// // subSectionIds: [],
// // unitId: null,
// // courseBlockId: null,
// // };
// // this.iframeRef = React.createRef();
// }
// componentDidMount() {
// loadCourseSequence(this.props.match.params.courseId, this.props.match.params.subSectionId, this.props.match.params.unitId, this.context.authenticatedUser.username)
// .then(({
// blocks, courseBlockId, subSectionIds, subSectionMetadata, units, unitId,
// }) => {
// console.log(subSectionMetadata);
// console.log(blocks[subSectionMetadata.itemId].lmsWebUrl);
// // If the sub section is time limited, that means it is some sort of special exam.
// const specialExam = subSectionMetadata.isTimeLimited;
// if (specialExam) {
// global.location.href = blocks[subSectionMetadata.itemId].lmsWebUrl;
// return; // We get out of here to abort loading.
// }
// this.setState({
// loading: false,
// blocks,
// units,
// subSectionMetadata,
// subSectionId: subSectionMetadata.itemId,
// subSectionIds,
// unitId,
// // eslint-disable-next-line react/no-unused-state
// courseBlockId, // TODO: Currently unused, but may be necessary.
// });
// });
// }
// componentDidUpdate(prevProps, prevState) {
// if (
// this.props.match.params.courseId !== prevProps.match.params.courseId ||
// this.state.subSectionId !== prevState.subSectionId ||
// this.state.unitId !== prevState.unitId
// ) {
// history.push(`/course/${this.props.match.params.courseId}/${this.state.subSectionId}/${this.state.unitId}`);
// }
// }
// handlePreviousClick = () => {
// const index = this.state.subSectionMetadata.unitIds.indexOf(this.state.unitId);
// if (index > 0) {
// this.setState({
// unitId: this.state.subSectionMetadata.unitIds[index - 1],
// });
// } else {
// const subSectionIndex = this.state.subSectionIds.indexOf(this.state.subSectionId);
// if (subSectionIndex > 0) {
// const previousSubSectionId = this.state.subSectionIds[subSectionIndex - 1];
// loadSubSectionMetadata(this.props.match.params.courseId, previousSubSectionId, { last: true }).then(({ subSectionMetadata, units, unitId }) => {
// const specialExam = subSectionMetadata.isTimeLimited;
// if (specialExam) {
// global.location.href = this.state.blocks[subSectionMetadata.itemId].lmsWebUrl;
// return; // We get out of here to abort loading.
// }
// this.setState({
// subSectionId: subSectionMetadata.itemId,
// subSectionMetadata,
// units,
// unitId,
// });
// });
// } else {
// console.log('we are at the beginning!');
// // TODO: We need to calculate whether we're on the first/last subSection in render so we can
// // disable the Next/Previous buttons. That'll involve extracting a bit of logic from this
// // function and handleNextClick below and reusing it - memoized, probably - in render().
// }
// }
// }
// handleNextClick = () => {
// const index = this.state.subSectionMetadata.unitIds.indexOf(this.state.unitId);
// if (index < this.state.subSectionMetadata.unitIds.length - 1) {
// this.setState({
// unitId: this.state.subSectionMetadata.unitIds[index + 1],
// });
// } else {
// const subSectionIndex = this.state.subSectionIds.indexOf(this.state.subSectionId);
// if (subSectionIndex < this.state.subSectionIds.length - 1) {
// const nextSubSectionId = this.state.subSectionIds[subSectionIndex + 1];
// loadSubSectionMetadata(this.props.match.params.courseId, nextSubSectionId, { first: true })
// .then(({ subSectionMetadata, units, unitId }) => {
// const specialExam = subSectionMetadata.isTimeLimited;
// if (specialExam) {
// global.location.href = this.state.blocks[subSectionMetadata.itemId].lmsWebUrl;
// return; // We get out of here to abort loading.
// }
// this.setState({
// subSectionId: subSectionMetadata.itemId,
// subSectionMetadata,
// units,
// unitId,
// });
// });
// } else {
// console.log('we are at the end!');
// }
// }
// }

View File

@@ -1,150 +0,0 @@
/* eslint-disable no-use-before-define */
/* eslint-disable no-plusplus */
import { getAuthenticatedHttpClient } from '@edx/frontend-platform/auth';
import { getConfig, camelCaseObject } from '@edx/frontend-platform';
export async function loadCourseSequence(courseId, subSectionId, urlUnitId, username) {
const blocksData = await getCourseBlocks(courseId, username);
const courseBlockId = blocksData.root;
const blocks = createBlocksMap(blocksData.blocks);
const defaultedSubSectionId = subSectionId || findFirstLeafChild(blocks, courseBlockId).id;
const subSectionIds = createSubSectionIdList(blocks, courseBlockId);
const { subSectionMetadata, units, unitId } = await loadSubSectionMetadata(
courseId,
defaultedSubSectionId,
{ unitId: urlUnitId },
);
return {
blocks,
subSectionIds,
courseBlockId,
subSectionMetadata,
units,
unitId,
};
}
export async function getCourseBlocks(courseId, username) {
const url = new URL(`${getConfig().LMS_BASE_URL}/api/courses/v2/blocks/`);
url.searchParams.append('course_id', decodeURIComponent(courseId));
url.searchParams.append('username', username);
url.searchParams.append('depth', 3);
url.searchParams.append('requested_fields', 'children');
const { data } = await getAuthenticatedHttpClient()
.get(url.href, {});
return data;
}
export async function loadSubSectionMetadata(courseId, subSectionId, {
first,
last,
unitId: urlUnitId,
}) {
let subSectionMetadata = await getSubSectionMetadata(courseId, subSectionId);
subSectionMetadata = camelCaseObject(subSectionMetadata);
subSectionMetadata.unitIds = subSectionMetadata.items.map(item => item.id);
let position = subSectionMetadata.position - 1; // metadata's position is 1's indexed
position = first ? 0 : position;
position = last ? subSectionMetadata.unitIds.length - 1 : position;
position = urlUnitId ? subSectionMetadata.unitIds.indexOf(urlUnitId) : position;
const unitId = subSectionMetadata.items[position].id;
const units = createUnitsMap(subSectionMetadata.items);
return {
subSectionMetadata,
units,
unitId,
};
}
export async function getSubSectionMetadata(courseId, subSectionId) {
const { data } = await getAuthenticatedHttpClient()
.get(`${getConfig().LMS_BASE_URL}/courses/${courseId}/xblock/${subSectionId}/handler/xmodule_handler/metadata`, {});
return data;
}
export function createBlocksMap(blocksData) {
const blocks = {};
const blocksList = Object.values(blocksData);
// First go through the list and flesh out our blocks map, camelCasing the objects as we go.
for (let i = 0; i < blocksList.length; i++) {
const block = blocksList[i];
blocks[block.id] = camelCaseObject(block);
}
// Next go through the blocksList again - now that we've added them all to the blocks map - and
// append a parent ID to every child found in every `children` list, using the blocks map to find
// them.
for (let i = 0; i < blocksList.length; i++) {
const block = blocksList[i];
if (Array.isArray(block.children)) {
for (let j = 0; j < block.children.length; j++) {
const childId = block.children[j];
const child = blocks[childId];
child.parentId = block.id;
}
}
}
return blocks;
}
function createUnitsMap(unitsList) {
const units = {};
for (let i = 0; i < unitsList.length; i++) {
const unit = unitsList[i];
units[unit.id] = camelCaseObject(unit);
}
return units;
}
function findFirstLeafChild(blocks, entryPointId) {
const block = blocks[entryPointId];
if (Array.isArray(block.children) && block.children.length > 0) {
return findFirstLeafChild(blocks, block.children[0]);
}
return block;
}
export function createSubSectionIdList(blocks, entryPointId, subSections = []) {
const block = blocks[entryPointId];
if (block.type === 'sequential') {
subSections.push(block.id);
}
if (Array.isArray(block.children)) {
for (let i = 0; i < block.children.length; i++) {
const childId = block.children[i];
createSubSectionIdList(blocks, childId, subSections);
}
}
return subSections;
}
export function createUnitIdList(blocks, entryPointId, units = []) {
const block = blocks[entryPointId];
if (block.type === 'vertical') {
units.push(block.id);
}
if (Array.isArray(block.children)) {
for (let i = 0; i < block.children.length; i++) {
const childId = block.children[i];
createUnitIdList(blocks, childId, units);
}
}
return units;
}
export function findBlockAncestry(blocks, blockId, descendents = []) {
const block = blocks[blockId];
descendents.unshift(block);
if (block.parentId === undefined) {
return descendents;
}
return findBlockAncestry(blocks, block.parentId, descendents);
}

View File

@@ -0,0 +1,16 @@
/* eslint-disable import/prefer-default-export */
import { getAuthenticatedHttpClient } from '@edx/frontend-platform/auth';
import { getConfig } from '@edx/frontend-platform';
export async function getCourseBlocks(courseId, username) {
const url = new URL(`${getConfig().LMS_BASE_URL}/api/courses/v2/blocks/`);
url.searchParams.append('course_id', decodeURIComponent(courseId));
url.searchParams.append('username', username);
url.searchParams.append('depth', 3);
url.searchParams.append('requested_fields', 'children');
const { data } = await getAuthenticatedHttpClient()
.get(url.href, {});
return data;
}

View File

@@ -1,8 +1,9 @@
import { useContext, useMemo, useState, useEffect } from 'react';
import { AppContext } from '@edx/frontend-platform/react';
import CourseStructureContext from './CourseStructureContext';
import { findBlockAncestry, getCourseBlocks, createBlocksMap, createSubSectionIdList, createUnitIdList } from './api';
import CourseStructureContext from '../CourseStructureContext';
import { getCourseBlocks } from './api';
import { findBlockAncestry, createBlocksMap, createSubSectionIdList, createUnitIdList } from './utils';
export function useBlockAncestry(blockId) {
const { blocks, loaded } = useContext(CourseStructureContext);

View File

@@ -0,0 +1,67 @@
/* eslint-disable no-plusplus */
import { camelCaseObject } from '@edx/frontend-platform';
export function createBlocksMap(blocksData) {
const blocks = {};
const blocksList = Object.values(blocksData);
// First go through the list and flesh out our blocks map, camelCasing the objects as we go.
for (let i = 0; i < blocksList.length; i++) {
const block = blocksList[i];
blocks[block.id] = camelCaseObject(block);
}
// Next go through the blocksList again - now that we've added them all to the blocks map - and
// append a parent ID to every child found in every `children` list, using the blocks map to find
// them.
for (let i = 0; i < blocksList.length; i++) {
const block = blocksList[i];
if (Array.isArray(block.children)) {
for (let j = 0; j < block.children.length; j++) {
const childId = block.children[j];
const child = blocks[childId];
child.parentId = block.id;
}
}
}
return blocks;
}
export function createSubSectionIdList(blocks, entryPointId, subSections = []) {
const block = blocks[entryPointId];
if (block.type === 'sequential') {
subSections.push(block.id);
}
if (Array.isArray(block.children)) {
for (let i = 0; i < block.children.length; i++) {
const childId = block.children[i];
createSubSectionIdList(blocks, childId, subSections);
}
}
return subSections;
}
export function createUnitIdList(blocks, entryPointId, units = []) {
const block = blocks[entryPointId];
if (block.type === 'vertical') {
units.push(block.id);
}
if (Array.isArray(block.children)) {
for (let i = 0; i < block.children.length; i++) {
const childId = block.children[i];
createUnitIdList(blocks, childId, units);
}
}
return units;
}
export function findBlockAncestry(blocks, blockId, descendents = []) {
const block = blocks[blockId];
descendents.unshift(block);
if (block.parentId === undefined) {
return descendents;
}
return findBlockAncestry(blocks, block.parentId, descendents);
}

View File

@@ -0,0 +1,28 @@
import React, { useContext } from 'react';
import SubSectionNavigation from './SubSectionNavigation';
import CourseStructureContext from '../CourseStructureContext';
import Unit from './Unit';
import { useSubSectionMetadata, useExamRedirect } from './data/hooks';
export default function SubSection() {
const {
courseId,
subSectionId,
unitId,
blocks,
} = useContext(CourseStructureContext);
const { metadata } = useSubSectionMetadata(courseId, subSectionId);
useExamRedirect(metadata, blocks);
const ready = blocks !== null && metadata !== null;
return ready && (
<section>
<SubSectionNavigation />
<Unit id={unitId} unit={blocks[unitId]} />
</section>
);
}

View File

@@ -1,12 +1,11 @@
import React, { Component, useCallback, useContext } from 'react';
import PropTypes from 'prop-types';
import React, { useCallback, useContext } from 'react';
import { history } from '@edx/frontend-platform';
import { Button } from '@edx/paragon';
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { faFilm, faBook, faPencilAlt, faTasks } from '@fortawesome/free-solid-svg-icons';
import { useCurrentSubSection, useCurrentUnit, usePreviousUnit, useNextUnit, useCurrentCourse, useCurrentSubSectionUnits } from './hooks';
import CourseStructureContext from './CourseStructureContext';
import { useCurrentSubSection, usePreviousUnit, useNextUnit, useCurrentSubSectionUnits } from '../data/hooks';
import CourseStructureContext from '../CourseStructureContext';
function UnitIcon({ type }) {
let icon = null;

View File

@@ -0,0 +1,11 @@
import { getConfig } from '@edx/frontend-platform';
import { getAuthenticatedHttpClient } from '@edx/frontend-platform/auth';
/* eslint-disable import/prefer-default-export */
export async function getSubSectionMetadata(courseId, subSectionId) {
const { data } = await getAuthenticatedHttpClient()
.get(`${getConfig().LMS_BASE_URL}/courses/${courseId}/xblock/${subSectionId}/handler/xmodule_handler/metadata`, {});
return data;
}

View File

@@ -0,0 +1,31 @@
import { useState, useEffect } from 'react';
import { getSubSectionMetadata } from './api';
export function useSubSectionMetadata(courseId, subSectionId) {
const [metadata, setMetadata] = useState(null);
const [loaded, setLoaded] = useState(false);
useEffect(() => {
setLoaded(false);
getSubSectionMetadata(courseId, subSectionId).then((data) => {
setMetadata(data);
setLoaded(true);
});
}, [courseId, subSectionId]);
return {
metadata,
loaded,
};
}
export function useExamRedirect(metadata, blocks) {
useEffect(() => {
if (metadata !== null && blocks !== null) {
if (metadata.isTimeLimited) {
global.location.href = blocks[metadata.itemId].lmsWebUrl;
}
}
}, [metadata, blocks]);
}