From 964abbe0c3d64350b0e47fb29a570543f8458e57 Mon Sep 17 00:00:00 2001
From: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>
Date: Mon, 17 Mar 2025 09:31:23 -0400
Subject: [PATCH] fix: right sidebar icon behavior (#1636)

When using the right new-sidebar with the left sidebar navigation, the icon for the right sidebar changed whenever the left sidebar was open. The icon change is supposed to indicate to users that the right sidebar is open. It is confusing to users when the left sidebar navigation is open and the right sidebar icon is filled instead of outlined.
---
 .../DiscussionsNotificationsTrigger.tsx                       | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/courseware/course/new-sidebar/sidebars/discussions-notifications/DiscussionsNotificationsTrigger.tsx b/src/courseware/course/new-sidebar/sidebars/discussions-notifications/DiscussionsNotificationsTrigger.tsx
index eddd306f..fed68e87 100644
--- a/src/courseware/course/new-sidebar/sidebars/discussions-notifications/DiscussionsNotificationsTrigger.tsx
+++ b/src/courseware/course/new-sidebar/sidebars/discussions-notifications/DiscussionsNotificationsTrigger.tsx
@@ -36,6 +36,8 @@ const DiscussionsNotificationsTrigger = ({ onClick }) => {
     [tabs],
   );
 
+  const sidebarIcon = currentSidebar === ID ? RightSidebarFilled : RightSidebarOutlined;
+
   useEffect(() => {
     if (baseUrl && edxProvider) {
       dispatch(getCourseDiscussionTopics(courseId));
@@ -81,7 +83,7 @@ const DiscussionsNotificationsTrigger = ({ onClick }) => {
 
   return (
     <IconButton
-      src={currentSidebar ? RightSidebarFilled : RightSidebarOutlined}
+      src={sidebarIcon}
       iconAs={Icon}
       onClick={handleClick}
       alt={intl.formatMessage(messages.openSidebarTrigger)}