fix: [AA-1018] api cleanup
Implement review feedback. Clean up tests
This commit is contained in:
@@ -108,7 +108,7 @@ describe('Sequence', () => {
|
||||
expect(screen.queryByText('The due date for this assignment has passed.')).toBeInTheDocument();
|
||||
});
|
||||
expect(screen.getByRole('link', { name: 'progress page' }))
|
||||
.toHaveAttribute('href', 'http://localhost:18000/courses/course-v1:edX+DemoX+Demo_Course_1/progress');
|
||||
.toHaveAttribute('href', 'http://localhost:18000/courses/course-v1:edX+DemoX+Demo_Course/progress');
|
||||
|
||||
// No normal content or navigation should be rendered. Just the above alert.
|
||||
expect(screen.queryAllByRole('button').length).toEqual(0);
|
||||
|
||||
@@ -12,7 +12,10 @@ import messages from './messages';
|
||||
|
||||
function HonorCode({ intl, courseId }) {
|
||||
const dispatch = useDispatch();
|
||||
const coursewareMetaData = useModel('courseHomeMeta', courseId);
|
||||
const {
|
||||
isMasquerading,
|
||||
username,
|
||||
} = useModel('courseHomeMeta', courseId);
|
||||
const authUser = getAuthenticatedUser();
|
||||
const siteName = getConfig().SITE_NAME;
|
||||
const honorCodeUrl = `${getConfig().TERMS_OF_SERVICE_URL}#honor-code`;
|
||||
@@ -26,7 +29,7 @@ function HonorCode({ intl, courseId }) {
|
||||
// Otherwise, even for staff users, we want to record the signature.
|
||||
saveIntegritySignature(
|
||||
courseId,
|
||||
coursewareMetaData.isMasquerading && coursewareMetaData.username !== authUser.username,
|
||||
isMasquerading && username !== authUser.username,
|
||||
),
|
||||
);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user