From 4f187390a0f91c15167f4955702b93fbc1787529 Mon Sep 17 00:00:00 2001
From: Chris Deery <3932645+cdeery@users.noreply.github.com>
Date: Mon, 20 Sep 2021 15:10:44 -0400
Subject: [PATCH] feat: [AA-906] Front end for Number of Days goal setting

fix errors from AccountActivationAlert.jsx
---
 .../AccountActivationAlert.jsx                | 27 +++++++++----------
 src/alerts/logistration-alert/messages.js     | 11 ++++++++
 src/course-home/outline-tab/messages.js       |  5 ++++
 3 files changed, 28 insertions(+), 15 deletions(-)
 create mode 100644 src/alerts/logistration-alert/messages.js

diff --git a/src/alerts/logistration-alert/AccountActivationAlert.jsx b/src/alerts/logistration-alert/AccountActivationAlert.jsx
index bbb9f565..dcdd06d7 100644
--- a/src/alerts/logistration-alert/AccountActivationAlert.jsx
+++ b/src/alerts/logistration-alert/AccountActivationAlert.jsx
@@ -9,10 +9,13 @@ import {
   Icon,
 } from '@edx/paragon';
 import { Check, ArrowForward } from '@edx/paragon/icons';
-import { FormattedMessage, injectIntl } from '@edx/frontend-platform/i18n';
+import { FormattedMessage, injectIntl, intlShape } from '@edx/frontend-platform/i18n';
 import { sendActivationEmail } from '../../courseware/data';
+import messages from './messages';
 
-function AccountActivationAlert() {
+function AccountActivationAlert({
+  intl,
+}) {
   const [showModal, setShowModal] = useState(false);
   const [showSpinner, setShowSpinner] = useState(false);
   const [showCheck, setShowCheck] = useState(false);
@@ -29,22 +32,12 @@ function AccountActivationAlert() {
   if (showAccountActivationAlert !== undefined) {
     Cookies.remove('show-account-activation-popup', { path: '/', domain: process.env.SESSION_COOKIE_DOMAIN });
     // extra check to make sure cookie was removed before updating the state. Updating the state without removal
-    // of cookie would make it infinit rendering
+    // of cookie would make it infinite rendering
     if (Cookies.get('show-account-activation-popup') === undefined) {
       setShowModal(true);
     }
   }
 
-  const title = (
-    <h3>
-      <FormattedMessage
-        id="account-activation.alert.title"
-        defaultMessage="Activate your account so you can log back in"
-        description="Title for account activation alert which is shown after the registration"
-      />
-    </h3>
-  );
-
   const button = (
     <Button
       variant="primary"
@@ -64,7 +57,7 @@ function AccountActivationAlert() {
   );
 
   const children = () => {
-    let bodyContent = null;
+    let bodyContent;
     const message = (
       <FormattedMessage
         id="account-activation.alert.message"
@@ -123,7 +116,7 @@ function AccountActivationAlert() {
   return (
     <AlertModal
       isOpen={showModal}
-      title={title}
+      title={intl.formatMessage(messages.accountActivationAlertTitle)}
       footerNode={button}
       onClose={() => ({})}
     >
@@ -132,4 +125,8 @@ function AccountActivationAlert() {
   );
 }
 
+AccountActivationAlert.propTypes = {
+  intl: intlShape.isRequired,
+};
+
 export default injectIntl(AccountActivationAlert);
diff --git a/src/alerts/logistration-alert/messages.js b/src/alerts/logistration-alert/messages.js
new file mode 100644
index 00000000..421d24de
--- /dev/null
+++ b/src/alerts/logistration-alert/messages.js
@@ -0,0 +1,11 @@
+import { defineMessages } from '@edx/frontend-platform/i18n';
+
+const messages = defineMessages({
+  accountActivationAlertTitle: {
+    id: 'account-activation.alert.title',
+    defaultMessage: 'Activate your account so you can log back in',
+    description: 'Title for account activation alert which is shown after the registration',
+  },
+});
+
+export default messages;
diff --git a/src/course-home/outline-tab/messages.js b/src/course-home/outline-tab/messages.js
index d4dab708..da013da9 100644
--- a/src/course-home/outline-tab/messages.js
+++ b/src/course-home/outline-tab/messages.js
@@ -268,6 +268,11 @@ const messages = defineMessages({
     id: 'learning.proctoringPanel.onboardingButtonPastDue',
     defaultMessage: 'Onboarding Past Due',
   },
+  accountActivationAlertTitle: {
+    id: 'account-activation.alert.title',
+    defaultMessage: 'Activate your account so you can log back in',
+    description: 'Title for account activation alert which is shown after the registration',
+  },
 });
 
 export default messages;