From 437f50b261ac395ba2a63260c2e8085343216a85 Mon Sep 17 00:00:00 2001 From: David Joy Date: Thu, 30 Jan 2020 18:14:47 -0500 Subject: [PATCH] Fixing linting errors. --- src/courseware/course/CourseBreadcrumb.jsx | 4 ++-- src/courseware/course/CourseBreadcrumbs.jsx | 2 +- src/courseware/sequence/Sequence.jsx | 9 ++++++--- src/courseware/sequence/UnitIcon.jsx | 4 +++- src/courseware/sequence/api.js | 3 +-- .../sequence/content-lock/ContentLock.jsx | 15 +++++++++++---- src/index.jsx | 4 +++- src/user-messages/Alert.jsx | 16 +++++++++++----- 8 files changed, 38 insertions(+), 19 deletions(-) diff --git a/src/courseware/course/CourseBreadcrumb.jsx b/src/courseware/course/CourseBreadcrumb.jsx index a758594d..788c08d3 100644 --- a/src/courseware/course/CourseBreadcrumb.jsx +++ b/src/courseware/course/CourseBreadcrumb.jsx @@ -9,11 +9,11 @@ export default function CourseBreadcrumb({ url, label, last }) {
  • {last ? label : ({label})}
    • - {!last && + {!last && (
    • - } + )} ); } diff --git a/src/courseware/course/CourseBreadcrumbs.jsx b/src/courseware/course/CourseBreadcrumbs.jsx index 98e1fb6b..6a5957c9 100644 --- a/src/courseware/course/CourseBreadcrumbs.jsx +++ b/src/courseware/course/CourseBreadcrumbs.jsx @@ -27,7 +27,7 @@ export default function CourseBreadcrumbs({
      {links.map(({ id, url, label }, i) => ( - ))} + ))}
    ); diff --git a/src/courseware/sequence/Sequence.jsx b/src/courseware/sequence/Sequence.jsx index 0966d443..70007093 100644 --- a/src/courseware/sequence/Sequence.jsx +++ b/src/courseware/sequence/Sequence.jsx @@ -103,9 +103,12 @@ function Sequence({ showCompletion={showCompletion} /> {isGated && ( - } + + )} > - `${getConfig().LMS_BASE_URL}/courses/${courseUsageKey}/xblock/${sequenceId}/handler/xmodule_handler`; +const getSequenceXModuleHandlerUrl = (courseUsageKey, sequenceId) => `${getConfig().LMS_BASE_URL}/courses/${courseUsageKey}/xblock/${sequenceId}/handler/xmodule_handler`; export async function saveSequencePosition(courseUsageKey, sequenceId, position) { diff --git a/src/courseware/sequence/content-lock/ContentLock.jsx b/src/courseware/sequence/content-lock/ContentLock.jsx index aa09fcbd..8d041204 100644 --- a/src/courseware/sequence/content-lock/ContentLock.jsx +++ b/src/courseware/sequence/content-lock/ContentLock.jsx @@ -1,4 +1,5 @@ import React, { useCallback } from 'react'; +import PropTypes from 'prop-types'; import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; import { faLock } from '@fortawesome/free-solid-svg-icons'; import { injectIntl, intlShape } from '@edx/frontend-platform/i18n'; @@ -17,13 +18,15 @@ function ContentLock({ return ( <>

    - {' '} + + {' '} {sectionName}

    {intl.formatMessage(messages['learn.contentLock.content.locked'])}

    -

    {intl.formatMessage(messages['learn.contentLock.complete.prerequisite'], { - prereqSectionName, - })} +

    + {intl.formatMessage(messages['learn.contentLock.complete.prerequisite'], { + prereqSectionName, + })}

    @@ -33,5 +36,9 @@ function ContentLock({ } ContentLock.propTypes = { intl: intlShape.isRequired, + courseUsageKey: PropTypes.string.isRequired, + prereqSectionName: PropTypes.string.isRequired, + prereqId: PropTypes.string.isRequired, + sectionName: PropTypes.string.isRequired, }; export default injectIntl(ContentLock); diff --git a/src/index.jsx b/src/index.jsx index 20a662ae..6591da1d 100755 --- a/src/index.jsx +++ b/src/index.jsx @@ -1,7 +1,9 @@ import 'core-js/stable'; import 'regenerator-runtime/runtime'; -import { APP_INIT_ERROR, APP_READY, subscribe, initialize } from '@edx/frontend-platform'; +import { + APP_INIT_ERROR, APP_READY, subscribe, initialize, +} from '@edx/frontend-platform'; import { AppProvider, ErrorPage } from '@edx/frontend-platform/react'; import React from 'react'; import ReactDOM from 'react-dom'; diff --git a/src/user-messages/Alert.jsx b/src/user-messages/Alert.jsx index dda6f992..9fb2281b 100644 --- a/src/user-messages/Alert.jsx +++ b/src/user-messages/Alert.jsx @@ -1,16 +1,20 @@ import React from 'react'; import PropTypes from 'prop-types'; import classNames from 'classnames'; -import { faExclamationTriangle, faInfoCircle, faCheckCircle, faMinusCircle, faTimes } from '@fortawesome/free-solid-svg-icons'; +import { + faExclamationTriangle, faInfoCircle, faCheckCircle, faMinusCircle, faTimes, +} from '@fortawesome/free-solid-svg-icons'; import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; import { Button } from '@edx/paragon'; function getAlertClass(type) { if (type === 'error') { return 'alert-warning'; - } else if (type === 'danger') { + } + if (type === 'danger') { return 'alert-danger'; - } else if (type === 'success') { + } + if (type === 'success') { return 'alert-success'; } return 'alert-info'; @@ -19,9 +23,11 @@ function getAlertClass(type) { function getAlertIcon(type) { if (type === 'error') { return faExclamationTriangle; - } else if (type === 'danger') { + } + if (type === 'danger') { return faMinusCircle; - } else if (type === 'success') { + } + if (type === 'success') { return faCheckCircle; } return faInfoCircle;