Andal.LND/frontend-app-learner-dashboard
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: additional linting + clarity changes

Browse Source
This commit is contained in:
Jody Bailey
2023-06-06 10:29:15 +02:00
parent 91a694736a
commit c3b98d954e
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/containers/Dashboard/index.jsx
View File

@@ -24,7 +24,7 @@ export const Dashboard = () => {
const showSelectSessionModal = reduxHooks.useShowSelectSessionModal();
// Hard coded to not show until experiment set-up logic is implemented
const showProductRecommendations = !initIsPending && !hasAvailableDashboards && hasCourses && true;
const showProductRecommendations = !initIsPending && !hasAvailableDashboards && hasCourses && false;
return (
<div id="dashboard-container" className="d-flex flex-column p-2 pt-0">

4
src/widgets/ProductRecommendations/api.js
View File

@@ -1,9 +1,9 @@
import { get, stringifyUrl } from 'data/services/lms/utils';
import urls from 'data/services/lms/urls';
export const crossProductRecommendationsUrl = (courseId) => `${urls.api}/learner_recommendations/product_recommendations/${courseId}/`;
export const productRecommendationsUrl = (courseId) => `${urls.api}/learner_recommendations/product_recommendations/${courseId}/`;
const fetchProductRecommendations = (courseId) => get(stringifyUrl(crossProductRecommendationsUrl(courseId)));
const fetchProductRecommendations = (courseId) => get(stringifyUrl(productRecommendationsUrl(courseId)));
export default {
fetchProductRecommendations,

4
src/widgets/ProductRecommendations/api.test.js
View File

@@ -1,5 +1,5 @@
import { get, stringifyUrl } from 'data/services/lms/utils';
import api, { crossProductRecommendationsUrl } from './api';
import api, { productRecommendationsUrl } from './api';
jest.mock('data/services/lms/utils', () => ({
stringifyUrl: (...args) => ({ stringifyUrl: args }),
@@ -10,7 +10,7 @@ describe('productRecommendationCourses api', () => {
describe('fetchProductRecommendations', () => {
it('calls get with the correct recommendation courses URL', () => {
expect(api.fetchProductRecommendations('CourseRunKey')).toEqual(
get(stringifyUrl(crossProductRecommendationsUrl('CourseRunKey'))),
get(stringifyUrl(productRecommendationsUrl('CourseRunKey'))),
);
});
});

4
src/widgets/ProductRecommendations/components/ProductCardHeader.jsx
View File

@@ -7,7 +7,7 @@ import { Icon, Hyperlink } from '@edx/paragon';
import { ChevronRight } from '@edx/paragon/icons';
import messages from '../messages';
function ProductCardHeader({ courseType }) {
const ProductCardHeader = ({ courseType }) => {
const { formatMessage } = useIntl();
const getProductTypeDetail = (type) => {
@@ -54,7 +54,7 @@ function ProductCardHeader({ courseType }) {
</p>
</div>
);
}
};
ProductCardHeader.propTypes = {
courseType: PropTypes.string.isRequired,