From c144c04aee78f54d16c36e42a2016de7e67991af Mon Sep 17 00:00:00 2001 From: Jason Wesson Date: Wed, 25 Sep 2024 21:11:52 +0000 Subject: [PATCH] fix: modify tests for course card and import paths --- .../CourseCard/components/CourseCardActions/index.jsx | 2 +- .../components/CourseCardActions/index.test.jsx | 10 ++++++---- src/plugin-slots/CourseCardActionSlot/index.jsx | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/containers/CourseCard/components/CourseCardActions/index.jsx b/src/containers/CourseCard/components/CourseCardActions/index.jsx index b14f1c9..5f4a34f 100644 --- a/src/containers/CourseCard/components/CourseCardActions/index.jsx +++ b/src/containers/CourseCard/components/CourseCardActions/index.jsx @@ -5,11 +5,11 @@ import { ActionRow } from '@openedx/paragon'; import { reduxHooks } from 'hooks'; +import CourseCardActionSlot from 'plugin-slots/CourseCardActionSlot'; import SelectSessionButton from './SelectSessionButton'; import BeginCourseButton from './BeginCourseButton'; import ResumeButton from './ResumeButton'; import ViewCourseButton from './ViewCourseButton'; -import CourseCardActionSlot from '../../../../plugin-slots/CourseCardActionSlot'; export const CourseCardActions = ({ cardId }) => { const { isEntitlement, isFulfilled } = reduxHooks.useCardEntitlementData(cardId); diff --git a/src/containers/CourseCard/components/CourseCardActions/index.test.jsx b/src/containers/CourseCard/components/CourseCardActions/index.test.jsx index 58809da..5819a9b 100644 --- a/src/containers/CourseCard/components/CourseCardActions/index.test.jsx +++ b/src/containers/CourseCard/components/CourseCardActions/index.test.jsx @@ -2,6 +2,7 @@ import { shallow } from '@edx/react-unit-test-utils'; import { reduxHooks } from 'hooks'; +import CourseCardActionSlot from 'plugin-slots/CourseCardActionSlot'; import UpgradeButton from './UpgradeButton'; import SelectSessionButton from './SelectSessionButton'; import BeginCourseButton from './BeginCourseButton'; @@ -19,6 +20,7 @@ jest.mock('hooks', () => ({ }, })); +jest.mock('plugin-slots/CourseCardActionSlot', () => 'CustomActionButton'); jest.mock('./UpgradeButton', () => 'UpgradeButton'); jest.mock('./SelectSessionButton', () => 'SelectSessionButton'); jest.mock('./ViewCourseButton', () => 'ViewCourseButton'); @@ -88,18 +90,18 @@ describe('CourseCardActions', () => { expect(el.instance.findByType(UpgradeButton).length).toEqual(0); }); }); - describe('not entielement, verified, or exec ed', () => { + describe('not entitlement, verified, or exec ed', () => { it('renders UpgradeButton and ViewCourseButton for archived courses', () => { mockHooks({ isArchived: true }); render(); - expect(el.instance.findByType(UpgradeButton)[0].props.cardId).toEqual(cardId); + expect(el.instance.findByType(CourseCardActionSlot)[0].props.cardId).toEqual(cardId); expect(el.instance.findByType(ViewCourseButton)[0].props.cardId).toEqual(cardId); }); describe('unstarted courses', () => { it('renders UpgradeButton and BeginCourseButton', () => { mockHooks(); render(); - expect(el.instance.findByType(UpgradeButton)[0].props.cardId).toEqual(cardId); + expect(el.instance.findByType(CourseCardActionSlot)[0].props.cardId).toEqual(cardId); expect(el.instance.findByType(BeginCourseButton)[0].props.cardId).toEqual(cardId); }); }); @@ -107,7 +109,7 @@ describe('CourseCardActions', () => { it('renders UpgradeButton and ResumeButton', () => { mockHooks({ hasStarted: true }); render(); - expect(el.instance.findByType(UpgradeButton)[0].props.cardId).toEqual(cardId); + expect(el.instance.findByType(CourseCardActionSlot)[0].props.cardId).toEqual(cardId); expect(el.instance.findByType(ResumeButton)[0].props.cardId).toEqual(cardId); }); }); diff --git a/src/plugin-slots/CourseCardActionSlot/index.jsx b/src/plugin-slots/CourseCardActionSlot/index.jsx index 564e803..6747ee1 100644 --- a/src/plugin-slots/CourseCardActionSlot/index.jsx +++ b/src/plugin-slots/CourseCardActionSlot/index.jsx @@ -3,7 +3,7 @@ import PropTypes from 'prop-types'; import { PluginSlot } from '@openedx/frontend-plugin-framework'; import { reduxHooks } from 'hooks'; -import UpgradeButton from '../../containers/CourseCard/components/CourseCardActions/UpgradeButton'; +import UpgradeButton from 'containers/CourseCard/components/CourseCardActions/UpgradeButton'; const CourseCardActionSlot = ({ cardId }) => { const { isEntitlement } = reduxHooks.useCardEntitlementData(cardId);