From b23e741a5e76b7299c7d212e129eb8985b120ce0 Mon Sep 17 00:00:00 2001
From: leangseu-edx <83240113+leangseu-edx@users.noreply.github.com>
Date: Mon, 12 Dec 2022 11:21:59 -0500
Subject: [PATCH] Revert "chore: add facebook button back"
This reverts commit 03e42f45bb0e54b33ac69b779f8c2adcaa375783.
---
.../__snapshots__/index.test.jsx.snap | 22 ++----------
.../components/CourseCardMenu/index.jsx | 36 +++++++++----------
.../components/CourseCardMenu/index.test.jsx | 13 ++++---
3 files changed, 24 insertions(+), 47 deletions(-)
diff --git a/src/containers/CourseCard/components/CourseCardMenu/__snapshots__/index.test.jsx.snap b/src/containers/CourseCard/components/CourseCardMenu/__snapshots__/index.test.jsx.snap
index 7ef6a6c..44fe18c 100644
--- a/src/containers/CourseCard/components/CourseCardMenu/__snapshots__/index.test.jsx.snap
+++ b/src/containers/CourseCard/components/CourseCardMenu/__snapshots__/index.test.jsx.snap
@@ -26,18 +26,9 @@ exports[`CourseCardMenu enrolled, share enabled, email setting enable snapshot 1
>
Email settings
-
-
- Share to Facebook
-
-
Email settings
-
-
- Share to Facebook
-
-
{
const { courseName } = appHooks.useCardCourseData(cardId);
const { isEnrolled, isEmailEnabled } = appHooks.useCardEnrollmentData(cardId);
- const { twitter, facebook } = appHooks.useCardSocialSettingsData(cardId);
+ const { twitter } = appHooks.useCardSocialSettingsData(cardId);
const { isMasquerading } = appHooks.useMasqueradeData();
const handleTwitterShare = appHooks.useTrackCourseEvent(
track.socialShare,
cardId,
'twitter',
);
- const handleFacebookShare = appHooks.useTrackCourseEvent(
- track.socialShare,
- cardId,
- 'facebook',
- );
const emailSettingsModal = useEmailSettings();
const unenrollModal = useUnenrollData();
@@ -70,20 +65,21 @@ export const CourseCardMenu = ({ cardId }) => {
{formatMessage(messages.emailSettings)}
)}
- {facebook.isEnabled && (
-
-
- {formatMessage(messages.shareToFacebook)}
-
-
- )}
+ {/* Disabled pending PM decision on missing quote param in updated FB api.
+ {facebook.isEnabled && (
+
+
+ {formatMessage(messages.shareToFacebook)}
+
+
+ )}
+ */}
{twitter.isEnabled && (
({
useCardEnrollmentData: jest.fn(),
useCardSocialSettingsData: jest.fn(),
useMasqueradeData: jest.fn(),
- useTrackCourseEvent: (_, __, site) => jest.fn().mockName(`${site}ShareClick`),
+ useTrackCourseEvent: jest.fn(),
},
}));
jest.mock('./hooks', () => ({
@@ -60,6 +60,7 @@ describe('CourseCardMenu', () => {
appHooks.useCardCourseData.mockReturnValue({ courseName });
appHooks.useCardEnrollmentData.mockReturnValue({ isEnrolled: true, isEmailEnabled: true });
appHooks.useMasqueradeData.mockReturnValue({ isMasquerading: false });
+ appHooks.useTrackCourseEvent.mockReturnValue(jest.fn().mockName('handleTwitterShare'));
});
describe('enrolled, share enabled, email setting enable', () => {
beforeEach(() => {
@@ -69,9 +70,7 @@ describe('CourseCardMenu', () => {
expect(wrapper).toMatchSnapshot();
});
it('renders share buttons', () => {
- el = wrapper.find('FacebookShareButton');
- expect(el.length).toEqual(1);
- expect(el.prop('url')).toEqual('facebook-share-url');
+ // expect(wrapper.find('FacebookShareButton').length).toEqual(1);
el = wrapper.find('TwitterShareButton');
expect(el.length).toEqual(1);
expect(el.prop('url')).toEqual('twitter-share-url');
@@ -94,7 +93,7 @@ describe('CourseCardMenu', () => {
appHooks.useCardSocialSettingsData.mockReturnValueOnce({
...defaultSocialShare,
twitter: { ...defaultSocialShare.twitter, isEnabled: false },
- facebook: { ...defaultSocialShare.facebook, isEnabled: false },
+ // facebook: { ...defaultSocialShare.facebook, isEnabled: false },
});
appHooks.useCardEnrollmentData.mockReturnValueOnce({ isEnrolled: false, isEmailEnabled: false });
wrapper = shallow();
@@ -103,7 +102,7 @@ describe('CourseCardMenu', () => {
expect(wrapper).toMatchSnapshot();
});
it('does not renders share buttons', () => {
- expect(wrapper.find('FacebookShareButton').length).toEqual(0);
+ // expect(wrapper.find('FacebookShareButton').length).toEqual(0);
expect(wrapper.find('TwitterShareButton').length).toEqual(0);
});
it('does not render unenroll modal toggle', () => {
@@ -124,7 +123,7 @@ describe('CourseCardMenu', () => {
expect(wrapper).toMatchSnapshot();
});
it('renders share buttons', () => {
- expect(wrapper.find('FacebookShareButton').length).toEqual(1);
+ // expect(wrapper.find('FacebookShareButton').length).toEqual(1);
el = wrapper.find('TwitterShareButton');
expect(el.length).toEqual(1);
expect(el.prop('url')).toEqual('twitter-share-url');