From 5cd8b005b9d62d1bbd22e462e4fbf4cad6404dfc Mon Sep 17 00:00:00 2001 From: Justin Hynes Date: Fri, 5 Apr 2024 14:30:08 -0400 Subject: [PATCH] feat!: Removes rendering of the RecommendationsPanel by default in Open edX (#311) --- .../LoadedSidebar/__snapshots__/index.test.jsx.snap | 4 +++- src/containers/WidgetContainers/LoadedSidebar/index.jsx | 4 ++-- src/containers/WidgetContainers/LoadedSidebar/index.test.jsx | 3 +++ .../NoCoursesSidebar/__snapshots__/index.test.jsx.snap | 4 +++- src/containers/WidgetContainers/NoCoursesSidebar/index.jsx | 4 ++-- .../WidgetContainers/NoCoursesSidebar/index.test.jsx | 3 +++ 6 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/containers/WidgetContainers/LoadedSidebar/__snapshots__/index.test.jsx.snap b/src/containers/WidgetContainers/LoadedSidebar/__snapshots__/index.test.jsx.snap index 38a19bb..e99ec3a 100644 --- a/src/containers/WidgetContainers/LoadedSidebar/__snapshots__/index.test.jsx.snap +++ b/src/containers/WidgetContainers/LoadedSidebar/__snapshots__/index.test.jsx.snap @@ -7,7 +7,9 @@ exports[`WidgetSidebar snapshots default 1`] = `
- +
`; diff --git a/src/containers/WidgetContainers/LoadedSidebar/index.jsx b/src/containers/WidgetContainers/LoadedSidebar/index.jsx index 8f5f222..e16e8fc 100644 --- a/src/containers/WidgetContainers/LoadedSidebar/index.jsx +++ b/src/containers/WidgetContainers/LoadedSidebar/index.jsx @@ -1,7 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; +import { PluginSlot } from '@openedx/frontend-plugin-framework'; -import RecommendationsPanel from 'widgets/RecommendationsPanel'; import hooks from 'widgets/ProductRecommendations/hooks'; export const WidgetSidebar = ({ setSidebarShowing }) => { @@ -13,7 +13,7 @@ export const WidgetSidebar = ({ setSidebarShowing }) => { return (
- +
); diff --git a/src/containers/WidgetContainers/LoadedSidebar/index.test.jsx b/src/containers/WidgetContainers/LoadedSidebar/index.test.jsx index aa822c8..4ff6410 100644 --- a/src/containers/WidgetContainers/LoadedSidebar/index.test.jsx +++ b/src/containers/WidgetContainers/LoadedSidebar/index.test.jsx @@ -8,6 +8,9 @@ jest.mock('widgets/LookingForChallengeWidget', () => 'LookingForChallengeWidget' jest.mock('widgets/ProductRecommendations/hooks', () => ({ useShowRecommendationsFooter: jest.fn(), })); +jest.mock('@openedx/frontend-plugin-framework', () => ({ + PluginSlot: 'PluginSlot', +})); describe('WidgetSidebar', () => { beforeEach(() => jest.resetAllMocks()); diff --git a/src/containers/WidgetContainers/NoCoursesSidebar/__snapshots__/index.test.jsx.snap b/src/containers/WidgetContainers/NoCoursesSidebar/__snapshots__/index.test.jsx.snap index 29e9ea0..6e6e829 100644 --- a/src/containers/WidgetContainers/NoCoursesSidebar/__snapshots__/index.test.jsx.snap +++ b/src/containers/WidgetContainers/NoCoursesSidebar/__snapshots__/index.test.jsx.snap @@ -7,7 +7,9 @@ exports[`WidgetSidebar snapshots default 1`] = `
- +
`; diff --git a/src/containers/WidgetContainers/NoCoursesSidebar/index.jsx b/src/containers/WidgetContainers/NoCoursesSidebar/index.jsx index c3e669a..1b1e328 100644 --- a/src/containers/WidgetContainers/NoCoursesSidebar/index.jsx +++ b/src/containers/WidgetContainers/NoCoursesSidebar/index.jsx @@ -1,7 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; +import { PluginSlot } from '@openedx/frontend-plugin-framework'; -import RecommendationsPanel from 'widgets/RecommendationsPanel'; import hooks from 'widgets/ProductRecommendations/hooks'; export const WidgetSidebar = ({ setSidebarShowing }) => { @@ -13,7 +13,7 @@ export const WidgetSidebar = ({ setSidebarShowing }) => { return (
- +
); diff --git a/src/containers/WidgetContainers/NoCoursesSidebar/index.test.jsx b/src/containers/WidgetContainers/NoCoursesSidebar/index.test.jsx index aa822c8..4ff6410 100644 --- a/src/containers/WidgetContainers/NoCoursesSidebar/index.test.jsx +++ b/src/containers/WidgetContainers/NoCoursesSidebar/index.test.jsx @@ -8,6 +8,9 @@ jest.mock('widgets/LookingForChallengeWidget', () => 'LookingForChallengeWidget' jest.mock('widgets/ProductRecommendations/hooks', () => ({ useShowRecommendationsFooter: jest.fn(), })); +jest.mock('@openedx/frontend-plugin-framework', () => ({ + PluginSlot: 'PluginSlot', +})); describe('WidgetSidebar', () => { beforeEach(() => jest.resetAllMocks());