From 4f117dfc963eccc502d2d190fb21b1e0cf6f0d53 Mon Sep 17 00:00:00 2001 From: "Adolfo R. Brandes" Date: Fri, 6 Feb 2026 11:44:03 -0300 Subject: [PATCH] test: fix minor issues with tests --- .../CourseCardActions/index.test.jsx | 2 +- .../CourseCardDetails/hooks.test.js | 11 ++++++----- .../CourseCardMenu/SocialShareMenu.test.jsx | 2 +- .../components/CourseCardMenu/index.test.jsx | 1 - src/setupTest.jsx | 19 ------------------- src/utils/StrictDict.test.js | 3 --- 6 files changed, 8 insertions(+), 30 deletions(-) diff --git a/src/containers/CourseCard/components/CourseCardActions/index.test.jsx b/src/containers/CourseCard/components/CourseCardActions/index.test.jsx index 8f8ae87..5b13344 100644 --- a/src/containers/CourseCard/components/CourseCardActions/index.test.jsx +++ b/src/containers/CourseCard/components/CourseCardActions/index.test.jsx @@ -12,7 +12,7 @@ jest.mock('@src/hooks', () => ({ }, })); -jest.mock('../../../../slots/CourseCardActionSlot', () => jest.fn(() =>
CourseCardActionSlot
)); +jest.mock('@src/slots/CourseCardActionSlot', () => jest.fn(() =>
CourseCardActionSlot
)); jest.mock('./SelectSessionButton', () => jest.fn(() =>
SelectSessionButton
)); jest.mock('./ViewCourseButton', () => jest.fn(() =>
ViewCourseButton
)); jest.mock('./BeginCourseButton', () => jest.fn(() =>
BeginCourseButton
)); diff --git a/src/containers/CourseCard/components/CourseCardDetails/hooks.test.js b/src/containers/CourseCard/components/CourseCardDetails/hooks.test.js index 17d3903..13b1931 100644 --- a/src/containers/CourseCard/components/CourseCardDetails/hooks.test.js +++ b/src/containers/CourseCard/components/CourseCardDetails/hooks.test.js @@ -45,9 +45,8 @@ describe('CourseCardDetails hooks', () => { }); describe('useCardDetailsData', () => { - const providerData = { - name: 'Unknown', - }; + const providerName = 'my-provider-name'; + const providerData = {}; const entitlementData = { isEntitlement: false, disableViewCourse: false, @@ -77,8 +76,10 @@ describe('CourseCardDetails hooks', () => { expect(out.accessMessage).toEqual(mockAccessMessage({ cardId })); }); it('forwards provider name if it exists, else formatted unknown provider name', () => { - expect(out.providerName).toEqual(providerData.name); - runHook({ provider: { name: providerData.name } }); + runHook({ provider: { name: providerName } }); + expect(out.providerName).toEqual(providerName); + + runHook({ provider: {} }); expect(out.providerName).toEqual(formatMessage(messages.unknownProviderName)); }); it('forward changeOrLeaveSessionMessage', () => { diff --git a/src/containers/CourseCard/components/CourseCardMenu/SocialShareMenu.test.jsx b/src/containers/CourseCard/components/CourseCardMenu/SocialShareMenu.test.jsx index 53e705a..4a6e6fa 100644 --- a/src/containers/CourseCard/components/CourseCardMenu/SocialShareMenu.test.jsx +++ b/src/containers/CourseCard/components/CourseCardMenu/SocialShareMenu.test.jsx @@ -116,7 +116,7 @@ describe('SocialShareMenu', () => { expect(emailSettingsButton).toBeInTheDocument(); }); if (isMasquerading) { - it('renders when masquerading', () => { + it('is disabled', () => { const emailSettingsButton = screen.getByRole('button', { name: messages.emailSettings.defaultMessage }); expect(emailSettingsButton).toBeInTheDocument(); expect(emailSettingsButton).toHaveAttribute('aria-disabled', 'true'); diff --git a/src/containers/CourseCard/components/CourseCardMenu/index.test.jsx b/src/containers/CourseCard/components/CourseCardMenu/index.test.jsx index 735cb11..db3aed0 100644 --- a/src/containers/CourseCard/components/CourseCardMenu/index.test.jsx +++ b/src/containers/CourseCard/components/CourseCardMenu/index.test.jsx @@ -10,7 +10,6 @@ import messages from './messages'; jest.mock('@src/hooks', () => ({ reduxHooks: { - useCardEnrollmentData: jest.fn(), }, })); diff --git a/src/setupTest.jsx b/src/setupTest.jsx index 6134dd4..08dd6fe 100755 --- a/src/setupTest.jsx +++ b/src/setupTest.jsx @@ -43,22 +43,3 @@ jest.mock('react-redux', () => { useSelector: jest.fn((selector) => ({ useSelector: selector })), }; }); - -jest.mock('./data/constants/app', () => ({ - ...jest.requireActual('./data/constants/app'), - locationId: 'fake-location-id', -})); - -jest.mock('./utils', () => ({ - ...jest.requireActual('./utils'), - nullMethod: jest.fn().mockName('utils.nullMethod'), -})); - -jest.mock('./utils/hooks', () => { - const formatDate = jest.fn(date => new Date(date).toLocaleDateString()) - .mockName('utils.formatDate'); - return { - formatDate, - useFormatDate: () => formatDate, - }; -}); diff --git a/src/utils/StrictDict.test.js b/src/utils/StrictDict.test.js index 998a5eb..5e11845 100644 --- a/src/utils/StrictDict.test.js +++ b/src/utils/StrictDict.test.js @@ -54,8 +54,5 @@ describe('StrictDict', () => { // Accessing a missing key should return undefined expect(dict.fakeKey).toBeUndefined(); }); - it('returns undefined', () => { - expect(dict.fakeKey).toEqual(undefined); - }); }); });