fix: a11y issues (#47)

This commit is contained in:
Ben Warzeski
2022-10-19 15:01:50 -04:00
committed by GitHub
parent 9abcf35100
commit 4b38aaa199
24 changed files with 284 additions and 138 deletions

View File

@@ -30,9 +30,11 @@ export const CourseCardContent = ({ cardId, orientation }) => {
<Card.Body>
<Card.Header
title={(
<a href={homeUrl} data-testid="CourseCardTitle">
{courseName}
</a>
<h3>
<a href={homeUrl} data-testid="CourseCardTitle">
{courseName}
</a>
</h3>
)}
actions={<CourseCardMenu cardId={cardId} />}
/>

View File

@@ -7,7 +7,7 @@ exports[`CourseCardMenu snapshot 1`] = `
alt="Actions dropdown"
as="IconButton"
iconAs="Icon"
id="dropdown-toggle-with-iconbutton"
id="course-actions-dropdown-test-card-id"
src={[MockFunction icons.MoreVert]}
variant="primary"
/>

View File

@@ -19,7 +19,7 @@ export const CourseCardMenu = ({ cardId }) => {
<>
<Dropdown>
<Dropdown.Toggle
id="dropdown-toggle-with-iconbutton"
id={`course-actions-dropdown-${cardId}`}
as={IconButton}
src={MoreVert}
iconAs={Icon}

View File

@@ -20,12 +20,14 @@ exports[`CourseCardContent snapshot orientation horizontal 1`] = `
/>
}
title={
<a
data-testid="CourseCardTitle"
href="test-home-url"
>
test-course-name
</a>
<h3>
<a
data-testid="CourseCardTitle"
href="test-home-url"
>
test-course-name
</a>
</h3>
}
/>
<Card.Section
@@ -71,12 +73,14 @@ exports[`CourseCardContent snapshot orientation vertical 1`] = `
/>
}
title={
<a
data-testid="CourseCardTitle"
href="test-home-url"
>
test-course-name
</a>
<h3>
<a
data-testid="CourseCardTitle"
href="test-home-url"
>
test-course-name
</a>
</h3>
}
/>
<Card.Section