feat: test and lint updates

This commit is contained in:
Ben Warzeski
2022-06-16 13:25:01 -04:00
parent 58026abbc9
commit 12ac0a317a
30 changed files with 334 additions and 263 deletions

View File

@@ -1,13 +1,13 @@
import { selectors } from 'data/redux';
import { getCardValues } from 'hooks';
import { useCardValues } from 'hooks';
const { cardData } = selectors;
const { programs } = cardData;
export const modalData = ({
export const useProgramData = ({
courseNumber,
}) => {
const data = getCardValues(courseNumber, {
const data = useCardValues(courseNumber, {
courseTitle: cardData.courseTitle,
relatedPrograms: cardData.relatedPrograms,
});
@@ -24,4 +24,4 @@ export const modalData = ({
};
};
export default modalData;
export default useProgramData;

View File

@@ -51,8 +51,8 @@ const relatedPrograms = [
describe('RelatedProgramsModal hooks', () => {
let out;
beforeEach(() => {
appHooks.getCardValues.mockReturnValueOnce({ courseTitle, relatedPrograms });
out = hooks.modalData({ courseNumber });
appHooks.useCardValues.mockReturnValueOnce({ courseTitle, relatedPrograms });
out = hooks.useProgramData({ courseNumber });
});
testCardValues(courseNumber, {
courseTitle: fieldKeys.courseTitle,

View File

@@ -7,7 +7,7 @@ import { CardGrid, ModalDialog } from '@edx/paragon';
import ProgramCard from './components/ProgramCard';
import messages from './messages';
import { modalData } from './hooks';
import { useProgramData } from './hooks';
import './index.scss';
export const RelatedProgramsModal = ({
@@ -16,7 +16,7 @@ export const RelatedProgramsModal = ({
courseNumber,
}) => {
const { formatMessage } = useIntl();
const { courseTitle, relatedPrograms } = modalData({ courseNumber });
const { courseTitle, relatedPrograms } = useProgramData({ courseNumber });
return (
<ModalDialog
title={formatMessage(messages.header)}

View File

@@ -1,12 +1,12 @@
import React from 'react';
import { shallow } from 'enzyme';
import { modalData } from './hooks';
import { useProgramData } from './hooks';
import RelatedProgramsModal from '.';
jest.mock('./components/ProgramCard', () => 'ProgramCard');
jest.mock('./hooks', () => ({
modalData: jest.fn(),
useProgramData: jest.fn(),
}));
const courseNumber = 'test-course-number';
@@ -36,7 +36,7 @@ const props = {
describe('RelatedProgramsModal', () => {
beforeEach(() => {
modalData.mockReturnValueOnce(hookProps);
useProgramData.mockReturnValueOnce(hookProps);
});
test('snapshot: open', () => {
expect(shallow(<RelatedProgramsModal {...props} />)).toMatchSnapshot();