Andal.LND/frontend-app-learner-dashboard
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: update course selector (#51)

Browse Source
This commit is contained in:
leangseu-edx
2022-10-25 13:19:58 -04:00
committed by GitHub
parent 57eac99b42
commit 115ef77e37
5 changed files with 7 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/data/redux/app/selectors/courseCard.js
View File

@@ -34,7 +34,6 @@ export const courseCard = StrictDict({
bannerImgSrc: baseAppUrl(course.bannerImgSrc),
courseNumber: course.courseNumber,
courseName: course.courseName,
website: course.website,
socialShareUrl: course.socialShareUrl,
}),
),
@@ -51,7 +50,6 @@ export const courseCard = StrictDict({
courseId: courseRun.courseId,
isArchived: courseRun.isArchived,
isStarted: courseRun.isStarted,
isFinished: courseRun.isFinished,
minPassingGrade: Math.floor(courseRun.minPassingGrade * 100),
@@ -86,6 +84,7 @@ export const courseCard = StrictDict({
isVerified: enrollment.isVerified,
isEmailEnabled: enrollment.isEmailEnabled,
hasOptedOutOfEmail: enrollment.hasOptedOutOfEmail,
};
},
),

8
src/data/redux/app/selectors/courseCard.test.js
View File

@@ -107,7 +107,6 @@ describe('courseCard selectors module', () => {
bannerImgSrc: 'test-banner-img-src',
courseNumber: 'test-course-number',
courseName: 'test-course-name',
website: 'test-website',
socialShareUrl: 'test-social-share-url',
});
});
@@ -117,10 +116,9 @@ describe('courseCard selectors module', () => {
it('passes bannerImgSrc, converted to a baseAppUrl', () => {
expect(selected.bannerImgSrc).toEqual(baseAppUrl(testData.bannerImgSrc));
});
it('passes [courseNumber, courseName, website, socialShareUrl]', () => {
it('passes [courseNumber, courseName, socialShareUrl]', () => {
expect(selected.courseNumber).toEqual(testData.courseNumber);
expect(selected.courseName).toEqual(testData.courseName);
expect(selected.website).toEqual(testData.website);
expect(selected.socialShareUrl).toEqual(testData.socialShareUrl);
});
});
@@ -149,7 +147,6 @@ describe('courseCard selectors module', () => {
courseId: 'test-course-id',
isArchived: 'test-is-archived',
isStarted: 'test-is-started',
isFinished: 'test-is-finished',
minPassingGrade: 0.9354,
@@ -169,11 +166,10 @@ describe('courseCard selectors module', () => {
expect(selected.endDate).toEqual(new Date(testData.endDate));
expect(selected.startDate).toEqual(new Date(testData.startDate));
});
it('passes [courseId, isArchived, isStarted, isFinished]', () => {
it('passes [courseId, isArchived, isStarted]', () => {
expect(selected.courseId).toEqual(testData.courseId);
expect(selected.isArchived).toEqual(testData.isArchived);
expect(selected.isStarted).toEqual(testData.isStarted);
expect(selected.isFinished).toEqual(testData.isFinished);
});
it('passes minPassingGrade floored from float to a percentage value', () => {
expect(selected.minPassingGrade).toEqual(93);