From 6dd2fb3dd645f01d096e68f5981ad2a0a951b030 Mon Sep 17 00:00:00 2001 From: Ben Warzeski Date: Thu, 11 May 2023 13:30:59 -0400 Subject: [PATCH] refactor: GradebookFilters component modernization --- .../GradebookFilters/__snapshots__/index.test.jsx.snap | 2 +- src/components/GradebookFilters/hooks.js | 2 +- src/components/GradebookFilters/hooks.test.jsx | 8 +++++--- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/components/GradebookFilters/__snapshots__/index.test.jsx.snap b/src/components/GradebookFilters/__snapshots__/index.test.jsx.snap index 4ee3e95..fe9adf0 100644 --- a/src/components/GradebookFilters/__snapshots__/index.test.jsx.snap +++ b/src/components/GradebookFilters/__snapshots__/index.test.jsx.snap @@ -16,7 +16,7 @@ exports[`GradebookFilters render snapshot 1`] = ` className="p-1" iconAs="Icon" onClick={[MockFunction hook.closeMenu]} - src={[Function]} + src="Close" /> { const includeCourseRoleMembers = selectors.filters.useIncludeCourseRoleMembers(); const updateIncludeCourseRoleMembers = actions.filters.useUpdateIncludeCourseRoleMembers(); - const closeMenu = thunkActions.app.useCloseFilterMenu(); + const closeMenu = thunkActions.app.filterMenu.useCloseMenu(); const fetchGrades = thunkActions.grades.useFetchGrades(); const handleIncludeTeamMembersChange = ({ target: { checked } }) => { diff --git a/src/components/GradebookFilters/hooks.test.jsx b/src/components/GradebookFilters/hooks.test.jsx index 2900c92..5722c52 100644 --- a/src/components/GradebookFilters/hooks.test.jsx +++ b/src/components/GradebookFilters/hooks.test.jsx @@ -9,7 +9,9 @@ jest.mock('data/redux/hooks', () => ({ filters: { useIncludeCourseRoleMembers: jest.fn() }, }, thunkActions: { - app: { useCloseFilterMenu: jest.fn() }, + app: { + filterMenu: { useCloseMenu: jest.fn() }, + }, grades: { useFetchGrades: jest.fn() }, }, })); @@ -18,7 +20,7 @@ selectors.filters.useIncludeCourseRoleMembers.mockReturnValue(true); const updateIncludeCourseRoleMembers = jest.fn(); actions.filters.useUpdateIncludeCourseRoleMembers.mockReturnValue(updateIncludeCourseRoleMembers); const closeFilterMenu = jest.fn(); -thunkActions.app.useCloseFilterMenu.mockReturnValue(closeFilterMenu); +thunkActions.app.filterMenu.useCloseMenu.mockReturnValue(closeFilterMenu); const fetchGrades = jest.fn(); thunkActions.grades.useFetchGrades.mockReturnValue(fetchGrades); @@ -34,7 +36,7 @@ describe('GradebookFiltersData component hooks', () => { it('initializes hooks', () => { expect(actions.filters.useUpdateIncludeCourseRoleMembers).toHaveBeenCalledWith(); expect(selectors.filters.useIncludeCourseRoleMembers).toHaveBeenCalledWith(); - expect(thunkActions.app.useCloseFilterMenu).toHaveBeenCalledWith(); + expect(thunkActions.app.filterMenu.useCloseMenu).toHaveBeenCalledWith(); expect(thunkActions.grades.useFetchGrades).toHaveBeenCalledWith(); }); });