From a7316e68245e81f31ee51205ad3cbde8994ab15b Mon Sep 17 00:00:00 2001 From: Simon Chen Date: Thu, 17 Jan 2019 14:37:21 -0500 Subject: [PATCH] fix(bug): make sure gradebook rounding handle null input --- package-lock.json | 8 ++------ src/components/Gradebook/index.jsx | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/package-lock.json b/package-lock.json index 870eb31..77d830f 100755 --- a/package-lock.json +++ b/package-lock.json @@ -10469,14 +10469,12 @@ "balanced-match": { "version": "1.0.0", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, "dev": true, - "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -10496,8 +10494,7 @@ "concat-map": { "version": "0.0.1", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "console-control-strings": { "version": "1.1.0", @@ -10645,7 +10642,6 @@ "version": "3.0.4", "bundled": true, "dev": true, - "optional": true, "requires": { "brace-expansion": "^1.1.7" } diff --git a/src/components/Gradebook/index.jsx b/src/components/Gradebook/index.jsx index 9cbe82f..1905439 100644 --- a/src/components/Gradebook/index.jsx +++ b/src/components/Gradebook/index.jsx @@ -176,7 +176,7 @@ export default class Gradebook extends React.Component { return 'Tracks'; }; - roundGrade = percent => parseFloat(percent.toFixed(DECIMAL_PRECISION)); + roundGrade = percent => parseFloat((percent || 0).toFixed(DECIMAL_PRECISION)); formatter = { percent: (entries, areGradesFrozen) => entries.map((entry) => {