From 2536b93cbbdbe075dc2b069c59aa01b53b908f66 Mon Sep 17 00:00:00 2001 From: Ihor Romaniuk Date: Wed, 23 Nov 2022 17:48:30 +0200 Subject: [PATCH] fix: add an asterisk to the 'Email' name of column (#272) * fix: add an asterisk to the 'Email' name of column * fix: update package log --- package-lock.json | 51 ++++++++++++------- .../__snapshots__/test.jsx.snap | 2 +- .../GradesView/GradebookTable/messages.js | 2 +- src/i18n/messages/ar.json | 4 +- src/i18n/messages/es_419.json | 4 +- src/i18n/messages/fr.json | 4 +- src/i18n/messages/zh_CN.json | 4 +- src/i18n/transifex_input.json | 4 +- 8 files changed, 46 insertions(+), 29 deletions(-) diff --git a/package-lock.json b/package-lock.json index 4f40549..e885f8a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18833,6 +18833,12 @@ "decamelize": "^1.2.0" } }, + "node_modules/jquery": { + "version": "3.6.1", + "resolved": "https://registry.npmjs.org/jquery/-/jquery-3.6.1.tgz", + "integrity": "sha512-opJeO4nCucVnsjiXOE+/PcCgYw9Gwpvs/a6B1LL/lQhwWwpbVEVYDZ1FokFr8PRc7ghYlrFPuyHuiiDNTQxmcw==", + "peer": true + }, "node_modules/js-tokens": { "version": "4.0.0", "resolved": "https://registry.npmjs.org/js-tokens/-/js-tokens-4.0.0.tgz", @@ -22801,7 +22807,6 @@ }, "node_modules/npm/node_modules/lodash._baseindexof": { "version": "3.1.0", - "dev": true, "inBundle": true, "license": "MIT" }, @@ -22817,19 +22822,16 @@ }, "node_modules/npm/node_modules/lodash._bindcallback": { "version": "3.0.1", - "dev": true, "inBundle": true, "license": "MIT" }, "node_modules/npm/node_modules/lodash._cacheindexof": { "version": "3.0.2", - "dev": true, "inBundle": true, "license": "MIT" }, "node_modules/npm/node_modules/lodash._createcache": { "version": "3.1.2", - "dev": true, "inBundle": true, "license": "MIT", "dependencies": { @@ -22844,7 +22846,6 @@ }, "node_modules/npm/node_modules/lodash._getnative": { "version": "3.9.1", - "dev": true, "inBundle": true, "license": "MIT" }, @@ -22862,7 +22863,6 @@ }, "node_modules/npm/node_modules/lodash.restparam": { "version": "3.6.1", - "dev": true, "inBundle": true, "license": "MIT" }, @@ -26181,6 +26181,17 @@ "node": ">= 8" } }, + "node_modules/popper.js": { + "version": "1.16.1", + "resolved": "https://registry.npmjs.org/popper.js/-/popper.js-1.16.1.tgz", + "integrity": "sha512-Wb4p1J4zyFTbM+u6WuO4XstYx4Ky9Cewe4DWrel7B0w6VVICvPwdOpotjzcf6eD8TsckVnIMNONQyPIUFOUbCQ==", + "deprecated": "You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1", + "peer": true, + "funding": { + "type": "opencollective", + "url": "https://opencollective.com/popperjs" + } + }, "node_modules/portfinder": { "version": "1.0.28", "resolved": "https://registry.npmjs.org/portfinder/-/portfinder-1.0.28.tgz", @@ -48044,6 +48055,12 @@ "supports-color": "^7.0.0" } }, + "jquery": { + "version": "3.6.1", + "resolved": "https://registry.npmjs.org/jquery/-/jquery-3.6.1.tgz", + "integrity": "sha512-opJeO4nCucVnsjiXOE+/PcCgYw9Gwpvs/a6B1LL/lQhwWwpbVEVYDZ1FokFr8PRc7ghYlrFPuyHuiiDNTQxmcw==", + "peer": true + }, "js-tokens": { "version": "4.0.0", "resolved": "https://registry.npmjs.org/js-tokens/-/js-tokens-4.0.0.tgz", @@ -51063,8 +51080,7 @@ }, "lodash._baseindexof": { "version": "3.1.0", - "bundled": true, - "dev": true + "bundled": true }, "lodash._baseuniq": { "version": "4.6.0", @@ -51077,18 +51093,15 @@ }, "lodash._bindcallback": { "version": "3.0.1", - "bundled": true, - "dev": true + "bundled": true }, "lodash._cacheindexof": { "version": "3.0.2", - "bundled": true, - "dev": true + "bundled": true }, "lodash._createcache": { "version": "3.1.2", "bundled": true, - "dev": true, "requires": { "lodash._getnative": "^3.0.0" } @@ -51100,8 +51113,7 @@ }, "lodash._getnative": { "version": "3.9.1", - "bundled": true, - "dev": true + "bundled": true }, "lodash._root": { "version": "3.0.1", @@ -51115,8 +51127,7 @@ }, "lodash.restparam": { "version": "3.6.1", - "bundled": true, - "dev": true + "bundled": true }, "lodash.union": { "version": "4.6.0", @@ -53674,6 +53685,12 @@ } } }, + "popper.js": { + "version": "1.16.1", + "resolved": "https://registry.npmjs.org/popper.js/-/popper.js-1.16.1.tgz", + "integrity": "sha512-Wb4p1J4zyFTbM+u6WuO4XstYx4Ky9Cewe4DWrel7B0w6VVICvPwdOpotjzcf6eD8TsckVnIMNONQyPIUFOUbCQ==", + "peer": true + }, "portfinder": { "version": "1.0.28", "resolved": "https://registry.npmjs.org/portfinder/-/portfinder-1.0.28.tgz", diff --git a/src/components/GradesView/GradebookTable/__snapshots__/test.jsx.snap b/src/components/GradesView/GradebookTable/__snapshots__/test.jsx.snap index 702d896..a70472d 100644 --- a/src/components/GradesView/GradebookTable/__snapshots__/test.jsx.snap +++ b/src/components/GradesView/GradebookTable/__snapshots__/test.jsx.snap @@ -17,7 +17,7 @@ exports[`GradebookTable component snapshot - fields1 and 2 between email and tot Object { "key": "Email", "label": , diff --git a/src/components/GradesView/GradebookTable/messages.js b/src/components/GradesView/GradebookTable/messages.js index 458e8dd..ec1c823 100644 --- a/src/components/GradesView/GradebookTable/messages.js +++ b/src/components/GradesView/GradebookTable/messages.js @@ -3,7 +3,7 @@ import { defineMessages } from '@edx/frontend-platform/i18n'; const messages = defineMessages({ emailHeading: { id: 'gradebook.GradesView.table.headings.email', - defaultMessage: 'Email', + defaultMessage: 'Email*', description: 'Gradebook table email column header', }, totalGradeHeading: { diff --git a/src/i18n/messages/ar.json b/src/i18n/messages/ar.json index f0c5dfc..0387055 100644 --- a/src/i18n/messages/ar.json +++ b/src/i18n/messages/ar.json @@ -37,7 +37,7 @@ "gradebook.GradesView.EditModal.Overrides.reasonHeader": "Reason", "gradebook.GradesTab.usersVisibilityLabel'": "Showing {filteredUsers} of {totalUsers} total learners", "gradebook.GradesView.editFilterLabel": "Edit Filters", - "gradebook.GradesView.table.headings.email": "Email", + "gradebook.GradesView.table.headings.email": "Email*", "gradebook.GradesView.table.headings.totalGrade": "Total Grade (%)", "gradebook.GradesView.table.headings.username": "Username", "gradebook.GradesView.table.labels.studentKey": "Student Key*", @@ -70,4 +70,4 @@ "gradebook.GradesTab.FilterBadges.courseGrade": "Course Grade", "gradebook.GradesTab.FilterBadges.includeCourseRoleMembers": "Include Course Team Members", "gradebook.GradesTab.FilterBadges.track": "Track" -} \ No newline at end of file +} diff --git a/src/i18n/messages/es_419.json b/src/i18n/messages/es_419.json index f0c5dfc..0387055 100644 --- a/src/i18n/messages/es_419.json +++ b/src/i18n/messages/es_419.json @@ -37,7 +37,7 @@ "gradebook.GradesView.EditModal.Overrides.reasonHeader": "Reason", "gradebook.GradesTab.usersVisibilityLabel'": "Showing {filteredUsers} of {totalUsers} total learners", "gradebook.GradesView.editFilterLabel": "Edit Filters", - "gradebook.GradesView.table.headings.email": "Email", + "gradebook.GradesView.table.headings.email": "Email*", "gradebook.GradesView.table.headings.totalGrade": "Total Grade (%)", "gradebook.GradesView.table.headings.username": "Username", "gradebook.GradesView.table.labels.studentKey": "Student Key*", @@ -70,4 +70,4 @@ "gradebook.GradesTab.FilterBadges.courseGrade": "Course Grade", "gradebook.GradesTab.FilterBadges.includeCourseRoleMembers": "Include Course Team Members", "gradebook.GradesTab.FilterBadges.track": "Track" -} \ No newline at end of file +} diff --git a/src/i18n/messages/fr.json b/src/i18n/messages/fr.json index 59ea5b9..e7ce863 100644 --- a/src/i18n/messages/fr.json +++ b/src/i18n/messages/fr.json @@ -37,7 +37,7 @@ "gradebook.GradesView.EditModal.Overrides.reasonHeader": "Motif", "gradebook.GradesTab.usersVisibilityLabel'": "Showing {filteredUsers} of {totalUsers} total learners", "gradebook.GradesView.editFilterLabel": "Editer les filtres", - "gradebook.GradesView.table.headings.email": "Email", + "gradebook.GradesView.table.headings.email": "Email*", "gradebook.GradesView.table.headings.totalGrade": "Note totale (%)", "gradebook.GradesView.table.headings.username": "Nom d’utilisateur", "gradebook.GradesView.table.labels.studentKey": "Clé d'étudiant", @@ -70,4 +70,4 @@ "gradebook.GradesTab.FilterBadges.courseGrade": "Note du cours", "gradebook.GradesTab.FilterBadges.includeCourseRoleMembers": "Include Course Team Members", "gradebook.GradesTab.FilterBadges.track": "Track" -} \ No newline at end of file +} diff --git a/src/i18n/messages/zh_CN.json b/src/i18n/messages/zh_CN.json index f0c5dfc..0387055 100644 --- a/src/i18n/messages/zh_CN.json +++ b/src/i18n/messages/zh_CN.json @@ -37,7 +37,7 @@ "gradebook.GradesView.EditModal.Overrides.reasonHeader": "Reason", "gradebook.GradesTab.usersVisibilityLabel'": "Showing {filteredUsers} of {totalUsers} total learners", "gradebook.GradesView.editFilterLabel": "Edit Filters", - "gradebook.GradesView.table.headings.email": "Email", + "gradebook.GradesView.table.headings.email": "Email*", "gradebook.GradesView.table.headings.totalGrade": "Total Grade (%)", "gradebook.GradesView.table.headings.username": "Username", "gradebook.GradesView.table.labels.studentKey": "Student Key*", @@ -70,4 +70,4 @@ "gradebook.GradesTab.FilterBadges.courseGrade": "Course Grade", "gradebook.GradesTab.FilterBadges.includeCourseRoleMembers": "Include Course Team Members", "gradebook.GradesTab.FilterBadges.track": "Track" -} \ No newline at end of file +} diff --git a/src/i18n/transifex_input.json b/src/i18n/transifex_input.json index f0c5dfc..0387055 100644 --- a/src/i18n/transifex_input.json +++ b/src/i18n/transifex_input.json @@ -37,7 +37,7 @@ "gradebook.GradesView.EditModal.Overrides.reasonHeader": "Reason", "gradebook.GradesTab.usersVisibilityLabel'": "Showing {filteredUsers} of {totalUsers} total learners", "gradebook.GradesView.editFilterLabel": "Edit Filters", - "gradebook.GradesView.table.headings.email": "Email", + "gradebook.GradesView.table.headings.email": "Email*", "gradebook.GradesView.table.headings.totalGrade": "Total Grade (%)", "gradebook.GradesView.table.headings.username": "Username", "gradebook.GradesView.table.labels.studentKey": "Student Key*", @@ -70,4 +70,4 @@ "gradebook.GradesTab.FilterBadges.courseGrade": "Course Grade", "gradebook.GradesTab.FilterBadges.includeCourseRoleMembers": "Include Course Team Members", "gradebook.GradesTab.FilterBadges.track": "Track" -} \ No newline at end of file +}