Commit Graph

52 Commits

Author SHA1 Message Date
Awais Ansari
0844ee6875 Perf: improved discussions MFE's components re-rendering and loading time (#513)
* chore: configure WDYR for react profiling

* perf: reduced post content re-rendering

* perf: post content view and it child optimization

* perf: add memoization in post editor

* perf: add memoization in postCommnetsView

* perf: improved endorsed comment view rendering

* perf: improved re-rendering in reply component

* fix: uncomment questionType commentsView

* fix: removed console errors in postContent area

* perf: reduced postType and postId dependancy

* perf: improved re-rendering in discussionHome

* perf: improved re-rendering of postsList and its child components

* perf: improved re-rendering of legacyTopic and learner sidebar

* fix: postFilterBar filter was not updating

* fix: resolve duplicate comment posts issue

* fix: memory leaking issue in comments view

* fix: duplicate topic posts in inContext sidebar

* perf: add lazy loading

* chore: remove WDYR configuration

* fix: alert banner padding

* chore: update package-lock file

* fix: bind tour API call with buttons
2023-05-08 16:21:29 +05:00
Awais Ansari
7b7c249abd Revert "Perf: improved discussions MFE's components re-rendering and loading time (#485)" (#512)
This reverts commit 59b4366edd.
2023-05-08 15:34:43 +05:00
Awais Ansari
59b4366edd Perf: improved discussions MFE's components re-rendering and loading time (#485)
* chore: configure WDYR for react profiling

* perf: reduced post content re-rendering

* perf: post content view and it child optimization

* perf: add memoization in post editor

* perf: add memoization in postCommnetsView

* perf: improved endorsed comment view rendering

* perf: improved re-rendering in reply component

* fix: uncomment questionType commentsView

* fix: removed console errors in postContent area

* perf: reduced postType and postId dependancy

* perf: improved re-rendering in discussionHome

* perf: improved re-rendering of postsList and its child components

* perf: improved re-rendering of legacyTopic and learner sidebar

* fix: postFilterBar filter was not updating

* fix: resolve duplicate comment posts issue

* fix: memory leaking issue in comments view

* fix: duplicate topic posts in inContext sidebar

* perf: add lazy loading

* chore: remove WDYR configuration

* fix: alert banner padding

* chore: update package-lock file
2023-05-08 15:14:53 +05:00
ayesha waris
15aee6a534 temp: fix for resize observer loop limit exceeded (#477) 2023-03-22 16:17:14 +05:00
sundasnoreen12
530f2cec82 test: added test cases for learner view (#465)
* test: added test cases for learner view

* refactor: fixed changes for code optimization

* refactor: added url changes

---------

Co-authored-by: sundasnoreen12 <sundasnoreen12@ggmail.com>
2023-03-13 13:18:09 +05:00
Ahtisham Shahid
d39a196cdf feat: added product tour for response sort (#462)
* feat: added product tour for response sort
2023-03-10 12:23:13 +05:00
Muhammad Adeel Tajamul
dedbc25358 fix: incontext crashing (#453)
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
2023-02-23 19:05:39 +05:00
Mehak Nasir
0f2ad8b7b4 fix: conditionally skipped some API calls and deffered script loading to improve performance 2023-02-23 14:26:02 +05:00
Mehak Nasir
f8800de766 feat: added delay in post preview to avoid flashing of content 2023-02-15 17:06:48 +05:00
Ahtisham Shahid
6948a9fa5e feat: added tour for not responded filter (#406)
* feat: added tour for not responded filter

* fix: resolved linter errors

* refactor: added translations, removed redundant code, fixed tests

* refactor: made tour component generic

* fix: update isEmpty logic
2023-01-17 20:55:36 +05:00
Awais Ansari
3f890401e8 feat: implements new v3 in-context topics structure (#371) 2022-12-30 17:15:47 +05:00
Adolfo R. Brandes
0c71e8b5b7 feat: Support runtime configuration (second attempt)
(This reintroduces the change in 9f84230c that was later reverted by
67b0b33a.)

frontend-platform supports runtime configuration since 2.5.0 (see the PR
that introduced it[1], but it requires MFE cooperation.  This implements
just that: by avoiding making configuration values constant, it should
now be possible to change them after initialization.

Almost all changes here relate to the `LMS_BASE_URL` setting, which in
most places was treated as a constant.

[1] https://github.com/openedx/frontend-platform/pull/335
2022-12-20 17:54:21 +05:00
Ahtisham Shahid
b1c1f1c024 fix: removed sidebar in case there are no posts (#367)
* fix: removed sidebar in case there are no posts
2022-12-19 11:35:14 +05:00
AsadAzam
67b0b33a81 Revert "feat: Support runtime configuration"
This reverts commit 9f84230c17.
2022-12-12 15:36:40 +05:00
Adolfo R. Brandes
9f84230c17 feat: Support runtime configuration
frontend-platform supports runtime configuration since 2.5.0 (see the PR
that introduced it[1], but it requires MFE cooperation.  This implements
just that: by avoiding making configuration values constant, it should
now be possible to change them after initialization.

Almost all changes here relate to the `LMS_BASE_URL` setting, which in
most places was treated as a constant.

[1] https://github.com/openedx/frontend-platform/pull/335
2022-12-09 10:39:59 +00:00
ayesha waris
bdaa13a7ad Merge branch 'master' into INF-628 2022-12-02 17:51:38 +05:00
ayeshoali
5ab324c9ca test: changed structure of test cases 2022-12-02 17:48:17 +05:00
Mehak Nasir
00ab8283e2 fix: UI style fixed for medium screens 2022-12-02 16:14:13 +05:00
ayeshoali
8e19eed468 test: testcases made for hook useusercanaddthreadinblackoutDate 2022-12-01 20:46:37 +05:00
ayeshoali
1169de04f6 refactor: hook's return condition changed 2022-12-01 16:48:44 +05:00
ayeshoali
f805f73447 refactor: modified hook to use can add thread in blackout dates 2022-11-30 13:42:47 +05:00
ayeshoali
27c4d7e3d6 refactor: made hook to get privilage users 2022-11-30 13:42:47 +05:00
ayeshoali
b976e812dc fix: add a post during active blackout dates fixed for all roles 2022-11-30 13:42:47 +05:00
Awais Ansari
1c5b0ac581 fix: in-context discussion rendering in sidebar (#351)
* fix: in-context discussion rendering in sidebar

* test: fix the failed test case for post editor
2022-11-17 19:47:20 +05:00
Mehak Nasir
401d38ce05 fix: learner tab is now visible irrespective of user role 2022-10-14 14:05:23 +05:00
SaadYousaf
cd204c8e05 fix: fix for reported alert banner 2022-10-13 23:28:07 +05:00
Kshitij Sobti
50b2e15731 feat: Add support for grouping at subsections (#281)
For smaller courses, there is a feature under the new provider
for grouping topics at the subsection level so that when
navigating the course, all topics under a subsection show up in
the sidebar instead of just the current unit.

This implements that functionality by checking if the discussion
is loaded in-context, and if grouping at subsection is enabled,
and if so, displaying the current subsection's topics.
2022-10-12 17:58:04 +05:00
Awais Ansari
52bd342dbf test: fix failed test related to containerSize hook 2022-09-30 13:06:47 +05:00
Awais Ansari
de81833f9a fix: post content vertical scroll issue 2022-09-30 13:06:47 +05:00
Mehak Nasir
5ba964fa70 fix: fixed landing url and filters 2022-09-13 18:36:09 +05:00
Mehak Nasir
02202e2c07 fix: learner tab is hidden from learners 2022-09-02 17:14:05 +05:00
Ahtisham Shahid
b0737da689 feat: added blackout dates implementation (#271)
* feat: added blackout dates implementation

Co-authored-by: Mehak Nasir <mehaknasir94@gmail.com>
2022-09-01 19:58:42 +05:00
Awais Ansari
45c596b770 fix: allow actions according to user role and privileges (#260)
* fix: allow actions according to user role and privileges

* test: fix failed test case for has_moderation_privileges change
2022-08-24 12:31:31 +05:00
Mehak Nasir
7426ee8838 fix: fix added for screen flickering (#257) 2022-08-19 18:45:04 +05:00
Awais Ansari
027e9c04f9 fix: desktop responsiveness issue (#253) 2022-08-16 16:52:12 +05:00
Awais Ansari
3657767b25 feat: add a posts list back button for small devices and improve responsiveness (#230)
* feat: add a posts list back button for small devices and improve mobile responsiveness
2022-08-05 22:06:23 +05:00
Awais Ansari
4991eba2b2 fix: display post closed/edited reason to post author (#228)
* fix: display post closed/edited reason to post author
2022-08-04 15:33:02 +05:00
Awais Ansari
d3adb8b3e7 fix: response and comment UI according to Figma (#220)
* fix: response and comment UI according to Figma
* test: add test cases for endorse alert banner
2022-07-27 15:32:34 +05:00
Awais Ansari
59187d2217 feat: implement learners area new UI (#197)
* feat: implement learners area new UI

* fix: learners list UI

* fix: initial learner sort based on role
2022-06-20 16:14:13 +05:00
Ahtisham Shahid
8d02ad33af fix: show reported label in case of reported response (#173)
* fix: show reported label in case of reported response

* fix: resolved linter issues

Co-authored-by: AhtishamShahid <ahtishamshahid@A006-00850.local>
2022-05-31 13:21:21 +05:00
Abdurrahman Asad
243274ab10 fix: discussion moderators can't create posts for specific cohorts (#155) 2022-05-11 10:42:23 +05:00
Kshitij Sobti
daacdbea1a feat: send message to learning MFE on navigation
Sends the current path to the learning MFE, so it can maintain the path on reload.
2022-04-01 16:41:27 +05:30
Kshitij Sobti
6bc0065259 feat: use resize postmessage API to send size hints to parent (#100)
When the post list is resized, send a size hint to the parent window (LMS/Learning MFE) so it can resize the discussions MFE iframe dynamically.
2022-03-30 11:10:42 +00:00
Hamza Khchine
2c40685932 feat: Add Learners list [BD-38] [TNL-8841] (#83)
Adds a new tab and listing view for learners in a course that have interacted with the discussions forums. It reports stats about the learner's created posts, comments, and reported content. 

Co-authored-by: Kshitij Sobti <kshitij@sobti.in>
2022-03-28 05:53:26 +00:00
Abdurrahman Asad
7d3a103a93 fix: send request to fetch discussion settings only for admins (#95) 2022-03-21 12:00:39 +05:00
Felipe Trzaskowski
194a3f2485 feat: Add support for specifying edit reasons (#46)
Adds support for specifying an edit reason when a moderator edits a user's post.

Co-authored-by: Kshitij Sobti <kshitij@opencraft.com>
2022-03-17 12:41:47 +00:00
Kshitij Sobti
d802e5331f fix: filtering by post type wasn't working [BD-38] [TNL-9609] (#82)
Fixes an issue where filtering by post type wasn't working, since the filter wasn't being passed to the API.
It also simplifies the code a bit and adds tests.
2022-03-14 05:36:28 +00:00
Keith Grootboom
c65230d5da feat: show empty state on posts pages [BD-38] [TNL-9484] [SE-5347] (#65)
When a user browses the discussion pages, show a page showing
that there is no data, rather than a blank page.

This PR implements the designs for this page while refactoring the
DiscussionHome component so that it doesn't get much larger.

- Created a hooks file and move some of the larger hooks in there.
- Added selectors for the state that would be needed for the
  components.
- Split the DiscussionHome into DiscussionContent and
  DiscussionSidebar to make it clearer where certain things get
  rendered.
- Adds a message to the sidebar to display No Results when
  appropriate.
- Added the NoResults component to show when filtering posts and there
  is nothing to show.
2022-03-09 12:15:32 +00:00
Kshitij Sobti
d31c438fc1 feat: add support for new provider and new topic api (#54)
Adds support for the new openedx provider and the new topics structure it introduces which ses the new topics v2 API.
2022-03-02 08:13:44 +00:00
Kshitij Sobti
b07b4043b0 test: tests 2021-12-06 15:45:14 +05:30