Commit Graph

41 Commits

Author SHA1 Message Date
Awais Ansari
4917da3245 fix: fetch topics on MFE load (#840)
* fix: added fetch topic API call in learners tab

* refactor: fetch topics on MFE load

* test: added legacy param in legacy topic test cases

---------

Co-authored-by: Awais  Ansari <awais.ansari@A006-01824.local>
2025-12-16 19:39:36 +05:00
ayesha waris
f69b2c118f chore: removed eslint-disable statements (#658)
* chore: removed eslint-disable statements

* refactor: removed unnecessary files and unintentional eslint-disable statements

* refactor: removed eslint import/no-cycle error

* fix: failing testcase

* style: removed comments

* fix: failing testcase

---------

Co-authored-by: sohailfatima <23100065@lums.edu.pk>
Co-authored-by: Fatima Sohail <68312464+sohailfatima@users.noreply.github.com>
2024-01-31 16:54:03 +05:00
Awais Ansari
0844ee6875 Perf: improved discussions MFE's components re-rendering and loading time (#513)
* chore: configure WDYR for react profiling

* perf: reduced post content re-rendering

* perf: post content view and it child optimization

* perf: add memoization in post editor

* perf: add memoization in postCommnetsView

* perf: improved endorsed comment view rendering

* perf: improved re-rendering in reply component

* fix: uncomment questionType commentsView

* fix: removed console errors in postContent area

* perf: reduced postType and postId dependancy

* perf: improved re-rendering in discussionHome

* perf: improved re-rendering of postsList and its child components

* perf: improved re-rendering of legacyTopic and learner sidebar

* fix: postFilterBar filter was not updating

* fix: resolve duplicate comment posts issue

* fix: memory leaking issue in comments view

* fix: duplicate topic posts in inContext sidebar

* perf: add lazy loading

* chore: remove WDYR configuration

* fix: alert banner padding

* chore: update package-lock file

* fix: bind tour API call with buttons
2023-05-08 16:21:29 +05:00
Awais Ansari
7b7c249abd Revert "Perf: improved discussions MFE's components re-rendering and loading time (#485)" (#512)
This reverts commit 59b4366edd.
2023-05-08 15:34:43 +05:00
Awais Ansari
59b4366edd Perf: improved discussions MFE's components re-rendering and loading time (#485)
* chore: configure WDYR for react profiling

* perf: reduced post content re-rendering

* perf: post content view and it child optimization

* perf: add memoization in post editor

* perf: add memoization in postCommnetsView

* perf: improved endorsed comment view rendering

* perf: improved re-rendering in reply component

* fix: uncomment questionType commentsView

* fix: removed console errors in postContent area

* perf: reduced postType and postId dependancy

* perf: improved re-rendering in discussionHome

* perf: improved re-rendering of postsList and its child components

* perf: improved re-rendering of legacyTopic and learner sidebar

* fix: postFilterBar filter was not updating

* fix: resolve duplicate comment posts issue

* fix: memory leaking issue in comments view

* fix: duplicate topic posts in inContext sidebar

* perf: add lazy loading

* chore: remove WDYR configuration

* fix: alert banner padding

* chore: update package-lock file
2023-05-08 15:14:53 +05:00
ayesha waris
1c2da56e3b fix: fix filter and sorting effect in discussion sidebar (#438)
* fix: fix filter and sorting effect in discussion sidebar

* test: fix test cases
2023-02-17 00:45:18 +05:00
ayesha waris
71931c83de refactor: hovercard hover state refactoring (#425)
* fix: peoples icon fixed to proper height and width

* refactor: reduced lines of codes aand changed some classes

* fix: fixed side bar peoples icon height and width

* test: fix test cases

* style: add wrapper around add response button

* test: add and fix test cases for hover card

* refactor: change line height class and view to hovercard
2023-02-09 23:30:16 +05:00
Awais Ansari
3f890401e8 feat: implements new v3 in-context topics structure (#371) 2022-12-30 17:15:47 +05:00
Mehak Nasir
31a66f6832 fix: filter result rendering fixed in topics 2022-12-09 17:58:08 +05:00
Kshitij Sobti
50b2e15731 feat: Add support for grouping at subsections (#281)
For smaller courses, there is a feature under the new provider
for grouping topics at the subsection level so that when
navigating the course, all topics under a subsection show up in
the sidebar instead of just the current unit.

This implements that functionality by checking if the discussion
is loaded in-context, and if grouping at subsection is enabled,
and if so, displaying the current subsection's topics.
2022-10-12 17:58:04 +05:00
Mehak Nasir
969df198d5 fix: text search rewrite text added 2022-10-07 20:29:28 +05:00
Awais Ansari
b5ed63c2ed fix: update topics listing UI (#317)
* fix: update topics listing UI

* test: update archived topics test case

* style: remove topic list last divider
2022-10-07 14:32:00 +05:00
Mehak Nasir
315da6ba5d fix: ui text changes 2022-10-04 18:00:14 +05:00
Awais Ansari
8a73f23cb0 fix: small UI issue and post sorting (#274)
* fix: filter pinned, unpinned posts and render separately

* fix: UI updates for INF-421 and INF-417

* fix: pin icon moves to left for non privilege user

* fix: posts list accessibility issue
2022-08-31 18:29:21 +05:00
Muhammad Adeel Tajamul
eb2ece323c fix: vertically centered no results found message (#270)
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
2022-08-29 11:09:53 +05:00
Muhammad Adeel Tajamul
7ee5a8e157 fix: show searching when api call is in progress (#254)
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
2022-08-23 11:22:56 +05:00
Mehak Nasir
e34ebdbeed fix: accessibility fixes (#236) 2022-08-07 01:10:35 +05:00
Muhammad Adeel Tajamul
bf953354a1 feat: update search in discussions mfe (#207)
* feat: update search in discussions mfe

* fix: updated code design

* fix: searchbar clear and code refactor

* fix: replaced existing search box

* feat: added search info bar

* fix: resolved failing topics test

* fix: resolved intl issue

* fix: resolved il8n extract check

* fix: labels moved to il8n message files

Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
Co-authored-by: Awais Ansari <awais.ansari63@gmail.com>
2022-07-07 14:31:20 +05:00
Mehak Nasir
a089235253 fix: load-more button added in place of infinite scroll (#199)
fix: accessibility issue resolved assigning aria-levels to UI components

fix: learner view loading changes and ui fix

fix: removed unused component

fix: lint fixes
2022-06-24 21:48:14 +05:00
Ahtisham Shahid
5719b5ce39 fix: Reported filter for global admin (#200)
* fix: Reported filter for global admin

* fix: udpted failing unit tests

* fix: updated failing unit tests

Co-authored-by: AhtishamShahid <ahtishamshahid@A006-00850.local>
2022-06-23 16:42:55 +05:00
Awais Ansari
59187d2217 feat: implement learners area new UI (#197)
* feat: implement learners area new UI

* fix: learners list UI

* fix: initial learner sort based on role
2022-06-20 16:14:13 +05:00
Mehak Nasir
84148954d0 fix: accessibility issues 2022-06-17 16:44:59 +05:00
Mehak Nasir
a2cfbc2b3a fix: tags added for reported/pinned/read/selected posts 2022-06-09 23:47:37 +05:00
Ahtisham Shahid
8d02ad33af fix: show reported label in case of reported response (#173)
* fix: show reported label in case of reported response

* fix: resolved linter issues

Co-authored-by: AhtishamShahid <ahtishamshahid@A006-00850.local>
2022-05-31 13:21:21 +05:00
adeel.tajamul
4b7145dccd fix: post summary pinned bar 2022-04-22 08:46:44 +05:00
Kshitij Sobti
c57dfc1fc5 fix: Fix constant reloading on topics page and posts links on category page [BD-38] [TNL-9868] [TNL-9846] (#128)
This fixes two issues. The first is that the topics page can cause constant requests to threads, and the second, that clicking on a post link when browsing a category can cause the application to crash.
2022-04-20 12:26:03 +00:00
Awais Ansari
a51f3ed7c6 fix: switching between subtopics are breaking the UI (#120) 2022-04-07 16:23:29 +05:00
Awais Ansari
3074ae807b fix: post summaries are being repeated in the list (#105)
* fix: post summaries are being repeated in the list
2022-03-28 15:31:42 +05:00
adeel.tajamul
30afbfb7b8 fix: posts not loading when scrolled to bottom 2022-03-10 12:26:47 +05:00
Keith Grootboom
c65230d5da feat: show empty state on posts pages [BD-38] [TNL-9484] [SE-5347] (#65)
When a user browses the discussion pages, show a page showing
that there is no data, rather than a blank page.

This PR implements the designs for this page while refactoring the
DiscussionHome component so that it doesn't get much larger.

- Created a hooks file and move some of the larger hooks in there.
- Added selectors for the state that would be needed for the
  components.
- Split the DiscussionHome into DiscussionContent and
  DiscussionSidebar to make it clearer where certain things get
  rendered.
- Adds a message to the sidebar to display No Results when
  appropriate.
- Added the NoResults component to show when filtering posts and there
  is nothing to show.
2022-03-09 12:15:32 +00:00
adeel.tajamul
bb73bdb9df fix: post summaries disappear upon scroll to the bottom 2022-03-04 16:52:59 +05:00
Kshitij Sobti
d31c438fc1 feat: add support for new provider and new topic api (#54)
Adds support for the new openedx provider and the new topics structure it introduces which ses the new topics v2 API.
2022-03-02 08:13:44 +00:00
Kshitij Sobti
c9cb8dd0e7 feat: Add new breadcrumb navigation
Adds the new breadcrumb dropdown-based navigation UI. This allows browsing the category and topic structure using dropdowns.
2021-11-23 14:43:53 +05:30
Kshitij Sobti
c8c3bb925c feat: Improve UX to match new mockups
Uses new API features for preview, deleting, pinning, and closing. Refactors and improves styling to match new mockups.
Adds the new post filter bar element.
2021-10-28 16:43:28 +05:30
Felipe Trzaskowski
3a71253e34 fix: move the loading indicator and scroll threshold inside the posts list 2021-10-19 11:03:51 -03:00
Felipe Trzaskowski
b8e3b86264 fix: posts pagination is loaded by scrolling
Implemented a ScrollThreshold reusable component to detect scrolling
events, which can be used in the place of a Button.

Removed the i18n entry created for the Button, which is no longer
needed.
2021-10-19 11:01:05 -03:00
Felipe Trzaskowski
1d3827ed10 feat: add posts pagination [BD-38] [TNL-8810] [BB-4993] 2021-10-19 11:01:05 -03:00
Kshitij Sobti
16e5901a46 feat: Add a reply editor and hook to API
This change uses the TinyMCE editor for editing comments and making comments and replies to existing threads.
2021-09-22 19:35:31 +05:30
Kshitij Sobti
586cf3e581 Remove Object.assign
Use arrays for pages instead of a map
2021-09-14 21:51:09 +05:30
Patrick Cockwell
93d10f9280 feat: Add major UI components and functionality
This adds a major chunk of UI code to the application covering topic listing,
topic filtering, subtopic browsing, browsing posts by topic, filtering unread
posts, filtering followed posts, sorting posts by recent activity, most activty
and most votes, liking/unliking a post, following/unfollowing a post, listing
comments and replis in a post.

Co-authored-by: Kshitij Sobti <kshitij@sobti.in>
2021-07-12 11:02:48 +05:30
Kshitij Sobti
491f7b7acd Basic discussions forum framework
Adds the basic structure for the Discussions MFE around which future development
will happen.
2020-10-21 23:59:23 +05:30