From add6e445bc64b5d1fb149205b95a263167c53994 Mon Sep 17 00:00:00 2001 From: ayesha waris <73840786+ayeshoali@users.noreply.github.com> Date: Tue, 28 Mar 2023 15:28:29 +0500 Subject: [PATCH] fix: hover color removed when filter buttons are clicked --- src/discussions/learners/learner/LearnerFilterBar.jsx | 2 ++ src/discussions/posts/post-filter-bar/PostFilterBar.jsx | 2 ++ src/index.scss | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/discussions/learners/learner/LearnerFilterBar.jsx b/src/discussions/learners/learner/LearnerFilterBar.jsx index d9b10c26..62f7cdec 100644 --- a/src/discussions/learners/learner/LearnerFilterBar.jsx +++ b/src/discussions/learners/learner/LearnerFilterBar.jsx @@ -27,6 +27,8 @@ const ActionItem = ({ data-testid={value === selected ? `${value} selected` : null} style={{ cursor: 'pointer' }} aria-checked={value === selected} + // eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex + tabIndex={value === selected ? '0' : '-1'} > diff --git a/src/discussions/posts/post-filter-bar/PostFilterBar.jsx b/src/discussions/posts/post-filter-bar/PostFilterBar.jsx index 249a1b78..d0cd89e0 100644 --- a/src/discussions/posts/post-filter-bar/PostFilterBar.jsx +++ b/src/discussions/posts/post-filter-bar/PostFilterBar.jsx @@ -41,6 +41,8 @@ export const ActionItem = ({ data-testid={value === selected ? 'selected' : null} style={{ cursor: 'pointer' }} aria-checked={value === selected} + // eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex + tabIndex={value === selected ? '0' : '-1'} > diff --git a/src/index.scss b/src/index.scss index dfbcca2b..40fda9df 100755 --- a/src/index.scss +++ b/src/index.scss @@ -251,7 +251,7 @@ header { min-width: 29rem; } -.filter-menu:focus-within { +.filter-menu:focus-visible { background-color: #e9e6e4 !important; }