From ab18806fa6d042ccdd46ec004bfa440b8a993808 Mon Sep 17 00:00:00 2001
From: Awais Ansari <79941147+awais-ansari@users.noreply.github.com>
Date: Thu, 24 Nov 2022 16:06:08 +0500
Subject: [PATCH] fix: minor issue after MEF rollout (#358)

* fix: update most votes filter name to most likes

* fix: add sorted word infilters description

* test: fixed post filter test case after sorted word addition
---
 src/components/FilterBar.jsx                      | 2 +-
 src/discussions/learners/messages.js              | 2 +-
 src/discussions/posts/PostsView.test.jsx          | 4 ++--
 src/discussions/posts/post-filter-bar/messages.js | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/components/FilterBar.jsx b/src/components/FilterBar.jsx
index 828778d8..05dc4b0a 100644
--- a/src/components/FilterBar.jsx
+++ b/src/components/FilterBar.jsx
@@ -101,7 +101,7 @@ function FilterBar({
         <span className="text-primary-700 pr-4">
           {intl.formatMessage(messages.sortFilterStatus, {
             own: false,
-            type: selectedFilters.type,
+            type: selectedFilters.postType,
             sort: selectedFilters.orderBy,
             status: selectedFilters.status,
             cohortType: selectedCohort?.name ? 'group' : 'all',
diff --git a/src/discussions/learners/messages.js b/src/discussions/learners/messages.js
index dfd62571..816730af 100644
--- a/src/discussions/learners/messages.js
+++ b/src/discussions/learners/messages.js
@@ -45,7 +45,7 @@ const messages = defineMessages({
   },
   sortFilterStatus: {
     id: 'discussions.learner.sortFilterStatus',
-    defaultMessage: `All learners by {sort, select,
+    defaultMessage: `All learners sorted by {sort, select,
       flagged {reported activity}
       activity {most activity}
       other {{sort}}
diff --git a/src/discussions/posts/PostsView.test.jsx b/src/discussions/posts/PostsView.test.jsx
index 84ca1072..4d60e567 100644
--- a/src/discussions/posts/PostsView.test.jsx
+++ b/src/discussions/posts/PostsView.test.jsx
@@ -199,7 +199,7 @@ describe('PostsView', () => {
         await renderComponent();
       });
       dropDownButton = screen.getByRole('button', {
-        name: /all posts by recent activity/i,
+        name: /all posts sorted by recent activity/i,
       });
       await act(async () => {
         fireEvent.click(dropDownButton);
@@ -220,7 +220,7 @@ describe('PostsView', () => {
       });
 
       dropDownButton = screen.getByRole('button', {
-        name: /All posts in Cohort 1 by recent activity/i,
+        name: /All posts in Cohort 1 sorted by recent activity/i,
       });
 
       expect(dropDownButton).toBeInTheDocument();
diff --git a/src/discussions/posts/post-filter-bar/messages.js b/src/discussions/posts/post-filter-bar/messages.js
index 62f91279..eed8c084 100644
--- a/src/discussions/posts/post-filter-bar/messages.js
+++ b/src/discussions/posts/post-filter-bar/messages.js
@@ -109,10 +109,10 @@ const messages = defineMessages({
         all {}
         group {in {cohort}}
         other {{cohortType}}
-    } by {sort, select,
+    } sorted by {sort, select,
       lastActivityAt {recent activity}
       commentCount {most activity}
-      voteCount {most votes}
+      voteCount {most likes}
       other {{sort}}
     }`,
     description: 'Status message showing current sorting and filtering status',