From 8ef83c5ae81c0425dbbbf74c3f8999a2fed74c16 Mon Sep 17 00:00:00 2001 From: Awais Ansari <79941147+awais-ansari@users.noreply.github.com> Date: Fri, 14 Oct 2022 15:42:28 +0500 Subject: [PATCH] fix: replace bodyheight with paragon windowSize (#327) --- src/discussions/discussions-home/DiscussionSidebar.jsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/discussions/discussions-home/DiscussionSidebar.jsx b/src/discussions/discussions-home/DiscussionSidebar.jsx index cbc015f2..9123ce2c 100644 --- a/src/discussions/discussions-home/DiscussionSidebar.jsx +++ b/src/discussions/discussions-home/DiscussionSidebar.jsx @@ -7,6 +7,8 @@ import { Redirect, Route, Switch, useLocation, } from 'react-router'; +import { useWindowSize } from '@edx/paragon'; + import { RequestStatus, Routes } from '../../data/constants'; import { useContainerSize, useIsOnDesktop, useIsOnXLDesktop, useShowLearnersTab, @@ -24,13 +26,14 @@ export default function DiscussionSidebar({ displaySidebar, postActionBarRef }) const redirectToLearnersTab = useShowLearnersTab(); const sidebarRef = useRef(null); const postActionBarHeight = useContainerSize(postActionBarRef); + const { height: windowHeight } = useWindowSize(); useEffect(() => { if (sidebarRef && postActionBarHeight) { if (isOnDesktop) { - sidebarRef.current.style.maxHeight = `${document.body.offsetHeight - postActionBarHeight}px`; + sidebarRef.current.style.maxHeight = `${windowHeight - postActionBarHeight}px`; } - sidebarRef.current.style.minHeight = `${document.body.offsetHeight - postActionBarHeight}px`; + sidebarRef.current.style.minHeight = `${windowHeight - postActionBarHeight}px`; sidebarRef.current.style.top = `${postActionBarHeight}px`; } }, [sidebarRef, postActionBarHeight]);