From 5f563ab70239d1002227508e28839ff152c43dea Mon Sep 17 00:00:00 2001 From: AhtishamShahid Date: Tue, 10 Jan 2023 13:53:41 +0500 Subject: [PATCH] fix: resolved linter errors --- src/discussions/discussions-home/DiscussionsHome.jsx | 2 +- src/discussions/tours/NotRespondedFilter.jsx | 2 +- src/discussions/tours/data/redux.test.js | 12 +++++++----- src/discussions/tours/data/selectors.js | 1 + 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/discussions/discussions-home/DiscussionsHome.jsx b/src/discussions/discussions-home/DiscussionsHome.jsx index f454ce86..62180909 100644 --- a/src/discussions/discussions-home/DiscussionsHome.jsx +++ b/src/discussions/discussions-home/DiscussionsHome.jsx @@ -24,12 +24,12 @@ import { EmptyTopic as InContextEmptyTopics } from '../in-context-topics/compone import messages from '../messages'; import { LegacyBreadcrumbMenu, NavigationBar } from '../navigation'; import { selectPostEditorVisible } from '../posts/data/selectors'; +import NotRespondedFilter from '../tours/NotRespondedFilter'; import { postMessageToParent } from '../utils'; import BlackoutInformationBanner from './BlackoutInformationBanner'; import DiscussionContent from './DiscussionContent'; import DiscussionSidebar from './DiscussionSidebar'; import InformationBanner from './InformationBanner'; -import NotRespondedFilter from '../tours/NotRespondedFilter'; export default function DiscussionsHome() { const location = useLocation(); diff --git a/src/discussions/tours/NotRespondedFilter.jsx b/src/discussions/tours/NotRespondedFilter.jsx index 1c03a25a..56483c5c 100644 --- a/src/discussions/tours/NotRespondedFilter.jsx +++ b/src/discussions/tours/NotRespondedFilter.jsx @@ -4,8 +4,8 @@ import { useDispatch, useSelector } from 'react-redux'; import { ProductTour } from '@edx/paragon'; -import { fetchDiscussionTours, updateTourShowStatus } from './data/thunks'; import { notRespondedFilterTour } from './data/selectors'; +import { fetchDiscussionTours, updateTourShowStatus } from './data/thunks'; export default () => { const dispatch = useDispatch(); diff --git a/src/discussions/tours/data/redux.test.js b/src/discussions/tours/data/redux.test.js index d05de496..80471d42 100644 --- a/src/discussions/tours/data/redux.test.js +++ b/src/discussions/tours/data/redux.test.js @@ -5,16 +5,21 @@ import { initializeMockApp } from '@edx/frontend-platform/testing'; import { initializeStore } from '../../../store'; import { getDiscussionTourUrl } from './api'; +import { notRespondedFilterTour } from './selectors'; import { fetchUserDiscussionsToursError, fetchUserDiscussionsToursRequest, fetchUserDiscussionsToursSuccess, - toursReducer, updateUserDiscussionsTourError, updateUserDiscussionsTourRequest, updateUserDiscussionsTourSuccess + toursReducer, + updateUserDiscussionsTourError, + updateUserDiscussionsTourRequest, + updateUserDiscussionsTourSuccess, } from './slices'; import { fetchDiscussionTours, updateTourShowStatus } from './thunks'; import discussionTourFactory from './tours.factory'; let mockAxios; +// eslint-disable-next-line no-unused-vars let store; const url = getDiscussionTourUrl(); describe('DiscussionToursThunk', () => { @@ -216,8 +221,6 @@ describe('toursReducer', () => { }); }); -import { notRespondedFilterTour } from './selectors'; - describe('notRespondedFilterTour', () => { it('filters the tours list by the "not_responded_filter" tour name', () => { const state = { @@ -228,8 +231,7 @@ describe('notRespondedFilterTour', () => { ], }, }; - const expectedResult = { id: 1, tourName: 'not_responded_filter' } - ; + const expectedResult = { id: 1, tourName: 'not_responded_filter' }; expect(notRespondedFilterTour(state)).toEqual(expectedResult); }); diff --git a/src/discussions/tours/data/selectors.js b/src/discussions/tours/data/selectors.js index 794ee8c0..97c56059 100644 --- a/src/discussions/tours/data/selectors.js +++ b/src/discussions/tours/data/selectors.js @@ -1,3 +1,4 @@ +// eslint-disable-next-line import/prefer-default-export export const notRespondedFilterTour = ({ tours }) => { // This function filters the tours list in the state by the tour_name 'not_responded_filter' // and returns the filtered list. This can be useful for displaying only the 'not_responded_filter'