From 4fecfabf2e5a6910809a0ccff021ac14e87ed758 Mon Sep 17 00:00:00 2001
From: Awais Ansari <79941147+awais-ansari@users.noreply.github.com>
Date: Thu, 13 Oct 2022 20:41:16 +0500
Subject: [PATCH] fix: add violates-guidelines edit reason as a default value
 for global staff (#323)

* fix: remove horizontal scrollbar

* fix: remove violates-guidelines edit reason as a default value for global staff

* fix: global staff can  edit comment/reply
---
 src/discussions/comments/comment/Comment.jsx     |  2 +-
 .../comments/comment/CommentEditor.jsx           | 16 +++++++++++-----
 src/discussions/posts/post-editor/PostEditor.jsx |  7 ++++---
 3 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/src/discussions/comments/comment/Comment.jsx b/src/discussions/comments/comment/Comment.jsx
index 6950bd11..2cdb6bc2 100644
--- a/src/discussions/comments/comment/Comment.jsx
+++ b/src/discussions/comments/comment/Comment.jsx
@@ -80,7 +80,7 @@ function Comment({
           <CommentHeader comment={comment} actionHandlers={actionHandlers} postType={postType} />
           {isEditing
             ? (
-              <CommentEditor comment={comment} onCloseEditor={() => setEditing(false)} />
+              <CommentEditor comment={comment} onCloseEditor={() => setEditing(false)} formClasses="pt-3" />
             )
             : <HTMLLoader cssClassName="comment-body pt-4 text-primary-500" componentId="comment" htmlNode={comment.renderedBody} />}
           <CommentIcons
diff --git a/src/discussions/comments/comment/CommentEditor.jsx b/src/discussions/comments/comment/CommentEditor.jsx
index 60b965d4..2742836b 100644
--- a/src/discussions/comments/comment/CommentEditor.jsx
+++ b/src/discussions/comments/comment/CommentEditor.jsx
@@ -17,6 +17,7 @@ import {
   selectModerationSettings,
   selectUserHasModerationPrivileges,
   selectUserIsGroupTa,
+  selectUserIsStaff,
 } from '../../data/selectors';
 import { formikCompatibleHandler, isFormikFieldInvalid } from '../../utils';
 import { addComment, editComment } from '../data/thunks';
@@ -27,16 +28,19 @@ function CommentEditor({
   comment,
   onCloseEditor,
   edit,
+  formClasses,
 }) {
   const editorRef = useRef(null);
   const { authenticatedUser } = useContext(AppContext);
   const userHasModerationPrivileges = useSelector(selectUserHasModerationPrivileges);
   const userIsGroupTa = useSelector(selectUserIsGroupTa);
+  const userIsStaff = useSelector(selectUserIsStaff);
   const { reasonCodesEnabled, editReasons } = useSelector(selectModerationSettings);
   const [submitting, dispatch] = useDispatchWithState();
 
-  const canDisplayEditReason = (reasonCodesEnabled && (userHasModerationPrivileges || userIsGroupTa)
-    && edit && comment.author !== authenticatedUser.username
+  const canDisplayEditReason = (reasonCodesEnabled && edit
+    && (userHasModerationPrivileges || userIsGroupTa || userIsStaff)
+    && comment?.author !== authenticatedUser.username
   );
 
   const editReasonCodeValidation = canDisplayEditReason && {
@@ -51,7 +55,7 @@ function CommentEditor({
 
   const initialValues = {
     comment: comment.rawBody,
-    editReasonCode: comment?.lastEdit?.reasonCode || '',
+    editReasonCode: comment?.lastEdit?.reasonCode || (userIsStaff ? 'violates-guidelines' : ''),
   };
 
   const handleCloseEditor = (resetForm) => {
@@ -94,7 +98,7 @@ function CommentEditor({
         handleChange,
         resetForm,
       }) => (
-        <Form onSubmit={handleSubmit}>
+        <Form onSubmit={handleSubmit} className={formClasses}>
           {canDisplayEditReason && (
             <Form.Group
               isInvalid={isFormikFieldInvalid('editReasonCode', {
@@ -104,7 +108,7 @@ function CommentEditor({
             >
               <Form.Control
                 name="editReasonCode"
-                className="mt-2"
+                className="mt-2 mr-0"
                 as="select"
                 value={values.editReasonCode}
                 onChange={handleChange}
@@ -181,10 +185,12 @@ CommentEditor.propTypes = {
   onCloseEditor: PropTypes.func.isRequired,
   intl: intlShape.isRequired,
   edit: PropTypes.bool,
+  formClasses: PropTypes.string,
 };
 
 CommentEditor.defaultProps = {
   edit: true,
+  formClasses: '',
 };
 
 export default injectIntl(CommentEditor);
diff --git a/src/discussions/posts/post-editor/PostEditor.jsx b/src/discussions/posts/post-editor/PostEditor.jsx
index 9a1e7528..825ff15c 100644
--- a/src/discussions/posts/post-editor/PostEditor.jsx
+++ b/src/discussions/posts/post-editor/PostEditor.jsx
@@ -107,7 +107,8 @@ function PostEditor({
   const userIsStaff = useSelector(selectUserIsStaff);
 
   const canDisplayEditReason = (reasonCodesEnabled && editExisting
-    && (userHasModerationPrivileges || userIsGroupTa || userIsStaff) && post?.author !== authenticatedUser.username
+    && (userHasModerationPrivileges || userIsGroupTa || userIsStaff)
+    && post?.author !== authenticatedUser.username
   );
 
   const editReasonCodeValidation = canDisplayEditReason && {
@@ -135,7 +136,7 @@ function PostEditor({
     follow: isEmpty(post?.following) ? true : post?.following,
     anonymous: allowAnonymous ? false : undefined,
     anonymousToPeers: allowAnonymousToPeers ? false : undefined,
-    editReasonCode: post?.lastEdit?.reasonCode || '',
+    editReasonCode: post?.lastEdit?.reasonCode || (userIsStaff ? 'violates-guidelines' : ''),
     cohort: post?.cohort || 'default',
   };
 
@@ -351,7 +352,7 @@ function PostEditor({
                   name="editReasonCode"
                   className="m-0"
                   as="select"
-                  value={userIsStaff ? 'violates-guidelines' : values.editReasonCode}
+                  value={values.editReasonCode}
                   onChange={handleChange}
                   onBlur={handleBlur}
                   aria-describedby="editReasonCodeInput"