From 1c2da56e3bd6f320a4528967d9eac5845ee55c0e Mon Sep 17 00:00:00 2001 From: ayesha waris <73840786+ayeshoali@users.noreply.github.com> Date: Fri, 17 Feb 2023 00:45:18 +0500 Subject: [PATCH] fix: fix filter and sorting effect in discussion sidebar (#438) * fix: fix filter and sorting effect in discussion sidebar * test: fix test cases --- src/discussions/posts/PostsView.jsx | 2 +- src/discussions/posts/PostsView.test.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/discussions/posts/PostsView.jsx b/src/discussions/posts/PostsView.jsx index ae7f42a3..fe050bcc 100644 --- a/src/discussions/posts/PostsView.jsx +++ b/src/discussions/posts/PostsView.jsx @@ -37,7 +37,7 @@ function CategoryPostsList({ category }) { const groupedCategory = useSelector(selectCurrentCategoryGrouping)(category); // If grouping at subsection is enabled, only apply it when browsing discussions in context in the learning MFE. const topicIds = useSelector(selectTopicsUnderCategory)(enableInContextSidebar ? groupedCategory : category); - const posts = useSelector(selectTopicThreads(topicIds)); + const posts = useSelector(enableInContextSidebar ? selectAllThreads : selectTopicThreads(topicIds)); return ; } diff --git a/src/discussions/posts/PostsView.test.jsx b/src/discussions/posts/PostsView.test.jsx index e8e3b5fa..bd734436 100644 --- a/src/discussions/posts/PostsView.test.jsx +++ b/src/discussions/posts/PostsView.test.jsx @@ -191,7 +191,7 @@ describe('PostsView', () => { .toHaveLength(topicThreadCount); // When grouping is enabled, topic 1 will be shown, but not otherwise. expect(screen.queryAllByText(/this is thread-\d+ in topic some-topic-1/i)) - .toHaveLength(grouping ? topicThreadCount : 0); + .toHaveLength(grouping ? topicThreadCount : 2); }, ); });