From 1005541e8d34280e3be994eade7541fdc1dfa0a8 Mon Sep 17 00:00:00 2001
From: sundasnoreen12 <sundasnoreen12@ggmail.com>
Date: Mon, 13 Mar 2023 11:37:32 +0500
Subject: [PATCH] refactor: added url changes

---
 src/discussions/data/api.js                    |  7 +++----
 src/discussions/learners/LearnersView.test.jsx | 12 +++++-------
 2 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/discussions/data/api.js b/src/discussions/data/api.js
index 045ac180..3f197194 100644
--- a/src/discussions/data/api.js
+++ b/src/discussions/data/api.js
@@ -8,14 +8,13 @@ ensureConfig([
 ], 'Posts API service');
 
 export const getCourseConfigApiUrl = () => `${getConfig().LMS_BASE_URL}/api/discussion/v1/courses/`;
-
+export const getDiscussionsConfigUrl = (courseId) => `${getCourseConfigApiUrl()}${courseId}/`;
 /**
  * Get discussions course config
  * @param {string} courseId
  */
 export async function getDiscussionsConfig(courseId) {
-  const url = `${getCourseConfigApiUrl()}${courseId}/`;
-  const { data } = await getAuthenticatedHttpClient().get(url);
+  const { data } = await getAuthenticatedHttpClient().get(getDiscussionsConfigUrl(courseId));
   return data;
 }
 
@@ -24,7 +23,7 @@ export async function getDiscussionsConfig(courseId) {
  * @param {string} courseId
  */
 export async function getDiscussionsSettings(courseId) {
-  const url = `${getCourseConfigApiUrl()}${courseId}/settings`;
+  const url = `${getDiscussionsConfigUrl(courseId)}settings`;
   const { data } = await getAuthenticatedHttpClient().get(url);
   return data;
 }
diff --git a/src/discussions/learners/LearnersView.test.jsx b/src/discussions/learners/LearnersView.test.jsx
index e25863b3..9e05e7b5 100644
--- a/src/discussions/learners/LearnersView.test.jsx
+++ b/src/discussions/learners/LearnersView.test.jsx
@@ -1,8 +1,7 @@
 import React from 'react';
 
 import {
-  fireEvent, render, screen, waitFor,
-  within,
+  fireEvent, render, screen, waitFor, within,
 } from '@testing-library/react';
 import MockAdapter from 'axios-mock-adapter';
 import { act } from 'react-dom/test-utils';
@@ -18,7 +17,7 @@ import { PostActionsBar } from '../../components';
 import { initializeStore } from '../../store';
 import { executeThunk } from '../../test-utils';
 import { DiscussionContext } from '../common/context';
-import { getCourseConfigApiUrl } from '../data/api';
+import { getDiscussionsConfigUrl } from '../data/api';
 import { fetchCourseConfig } from '../data/thunks';
 import { getUserProfileApiUrl, learnersApiUrl } from './data/api';
 import { fetchLearners } from './data/thunks';
@@ -28,7 +27,6 @@ import './data/__factories__';
 
 let store;
 let axiosMock;
-const courseConfigApiUrl = getCourseConfigApiUrl();
 const courseId = 'course-v1:edX+TestX+Test_Course';
 let container;
 
@@ -92,7 +90,7 @@ describe('LearnersView', () => {
   }
 
   async function assignPrivilages() {
-    axiosMock.onGet(`${courseConfigApiUrl}${courseId}/`).reply(200, {
+    axiosMock.onGet(getDiscussionsConfigUrl(courseId)).reply(200, {
       learners_tab_enabled: true,
       user_is_privileged: true,
     });
@@ -245,8 +243,8 @@ describe('LearnersView', () => {
       setUpLearnerMockResponse();
     });
 
-    const leaners = container.querySelectorAll('.discussion-post');
+    const learners = container.querySelectorAll('.discussion-post');
 
-    expect(leaners).toHaveLength(3);
+    expect(learners).toHaveLength(3);
   });
 });