From d05ed5ba269b955298a03ce866f1f591ca1ae031 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 15 Aug 2022 05:13:53 +0000 Subject: [PATCH 1/5] chore(deps): update dependency axios-mock-adapter to v1.21.2 --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 9a23c62..a92533c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -40,7 +40,7 @@ "@edx/frontend-build": "9.2.2", "@testing-library/jest-dom": "5.16.5", "@testing-library/react": "12.1.5", - "axios-mock-adapter": "1.21.1", + "axios-mock-adapter": "1.21.2", "codecov": "3.8.3", "es-check": "6.1.1", "glob": "7.2.3", @@ -8143,9 +8143,9 @@ } }, "node_modules/axios-mock-adapter": { - "version": "1.21.1", - "resolved": "https://registry.npmjs.org/axios-mock-adapter/-/axios-mock-adapter-1.21.1.tgz", - "integrity": "sha512-Pdm7nZuhkz/DSucQ4Bbo9qVBqfm9j7ev9ycTvIXHqvAjnJEjWPHKYfTfpounVp8MwjFFSHXGS7hCkTwAswtSTA==", + "version": "1.21.2", + "resolved": "https://registry.npmjs.org/axios-mock-adapter/-/axios-mock-adapter-1.21.2.tgz", + "integrity": "sha512-jzyNxU3JzB2XVhplZboUcF0YDs7xuExzoRSHXPHr+UQajaGmcTqvkkUADgkVI2WkGlpZ1zZlMVdcTMU0ejV8zQ==", "dev": true, "dependencies": { "fast-deep-equal": "^3.1.3", @@ -34727,9 +34727,9 @@ } }, "axios-mock-adapter": { - "version": "1.21.1", - "resolved": "https://registry.npmjs.org/axios-mock-adapter/-/axios-mock-adapter-1.21.1.tgz", - "integrity": "sha512-Pdm7nZuhkz/DSucQ4Bbo9qVBqfm9j7ev9ycTvIXHqvAjnJEjWPHKYfTfpounVp8MwjFFSHXGS7hCkTwAswtSTA==", + "version": "1.21.2", + "resolved": "https://registry.npmjs.org/axios-mock-adapter/-/axios-mock-adapter-1.21.2.tgz", + "integrity": "sha512-jzyNxU3JzB2XVhplZboUcF0YDs7xuExzoRSHXPHr+UQajaGmcTqvkkUADgkVI2WkGlpZ1zZlMVdcTMU0ejV8zQ==", "dev": true, "requires": { "fast-deep-equal": "^3.1.3", diff --git a/package.json b/package.json index ccb936e..83047ae 100644 --- a/package.json +++ b/package.json @@ -66,7 +66,7 @@ "@edx/frontend-build": "9.2.2", "@testing-library/jest-dom": "5.16.5", "@testing-library/react": "12.1.5", - "axios-mock-adapter": "1.21.1", + "axios-mock-adapter": "1.21.2", "codecov": "3.8.3", "es-check": "6.1.1", "glob": "7.2.3", From 64d532aad5aa7a27d5db4403330b7dc1e05bc884 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 15 Aug 2022 10:48:49 +0000 Subject: [PATCH 2/5] chore(deps): update dependency es-check to v6.2.1 --- package-lock.json | 22 +++++++++++----------- package.json | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/package-lock.json b/package-lock.json index a92533c..dcf61fb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -42,7 +42,7 @@ "@testing-library/react": "12.1.5", "axios-mock-adapter": "1.21.2", "codecov": "3.8.3", - "es-check": "6.1.1", + "es-check": "6.2.1", "glob": "7.2.3", "husky": "7.0.4", "jest": "27.3.1", @@ -11811,14 +11811,14 @@ } }, "node_modules/es-check": { - "version": "6.1.1", - "resolved": "https://registry.npmjs.org/es-check/-/es-check-6.1.1.tgz", - "integrity": "sha512-lH8Cc5UEidAntXNnQrVpc3gPMpF5fO9e9ISCD6geKF5fNcOVkqf3rgmtGjN6gHwItzRelpNz6GnHQxN5fzLW5Q==", + "version": "6.2.1", + "resolved": "https://registry.npmjs.org/es-check/-/es-check-6.2.1.tgz", + "integrity": "sha512-IPiRXUlwSTd2yMklIf9yEGe6GK5wCS8Sz1aTNHm1QSiYzI4aiq19giYbLi95tb+e0JJVKmcU0iQXQWW60a8V9A==", "dev": true, "dependencies": { "@caporal/core": "^2.0.2", - "acorn": "^8.4.1", - "glob": "^7.1.7" + "acorn": "^8.7.0", + "fast-glob": "^3.2.11" }, "bin": { "es-check": "index.js" @@ -37620,14 +37620,14 @@ } }, "es-check": { - "version": "6.1.1", - "resolved": "https://registry.npmjs.org/es-check/-/es-check-6.1.1.tgz", - "integrity": "sha512-lH8Cc5UEidAntXNnQrVpc3gPMpF5fO9e9ISCD6geKF5fNcOVkqf3rgmtGjN6gHwItzRelpNz6GnHQxN5fzLW5Q==", + "version": "6.2.1", + "resolved": "https://registry.npmjs.org/es-check/-/es-check-6.2.1.tgz", + "integrity": "sha512-IPiRXUlwSTd2yMklIf9yEGe6GK5wCS8Sz1aTNHm1QSiYzI4aiq19giYbLi95tb+e0JJVKmcU0iQXQWW60a8V9A==", "dev": true, "requires": { "@caporal/core": "^2.0.2", - "acorn": "^8.4.1", - "glob": "^7.1.7" + "acorn": "^8.7.0", + "fast-glob": "^3.2.11" } }, "es-module-lexer": { diff --git a/package.json b/package.json index 83047ae..5cd55f7 100644 --- a/package.json +++ b/package.json @@ -68,7 +68,7 @@ "@testing-library/react": "12.1.5", "axios-mock-adapter": "1.21.2", "codecov": "3.8.3", - "es-check": "6.1.1", + "es-check": "6.2.1", "glob": "7.2.3", "husky": "7.0.4", "jest": "27.3.1", From bc64c9e2788e04e63dc631971ee207afd2a4d6d7 Mon Sep 17 00:00:00 2001 From: Thomas Tracy Date: Fri, 19 Aug 2022 10:31:30 -0400 Subject: [PATCH 3/5] fix: [APER-1936] Changes for a11y review (#71) * fix: [APER-1936] Changes for a11y review - Fixes skip nav link to work properly - inline styles pending tasks link - adds
- adds sr-only span to "view message" links in task history table - header/footer updated in seperate PR * chore: add sr-only span to unit test * fix: fix space before sr-only span" --- src/components/bulk-email-tool/BulkEmailTool.jsx | 6 +++--- .../bulk-email-task-manager/BulkEmailContentHistory.jsx | 1 + .../bulk-email-task-manager/BulkEmailPendingTasksAlert.jsx | 1 + .../test/BulkEmailContentHistory.test.jsx | 2 ++ src/components/page-container/PageContainer.jsx | 4 +++- 5 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/components/bulk-email-tool/BulkEmailTool.jsx b/src/components/bulk-email-tool/BulkEmailTool.jsx index e4962b7..76d573f 100644 --- a/src/components/bulk-email-tool/BulkEmailTool.jsx +++ b/src/components/bulk-email-tool/BulkEmailTool.jsx @@ -18,13 +18,13 @@ export default function BulkEmailTool() { return ( {(courseMetadata) => (courseMetadata.originalUserIsStaff ? ( -
+ <>
-

+

-

+ ) : ( ))} diff --git a/src/components/bulk-email-tool/bulk-email-task-manager/BulkEmailContentHistory.jsx b/src/components/bulk-email-tool/bulk-email-task-manager/BulkEmailContentHistory.jsx index 75a0dab..90e1649 100644 --- a/src/components/bulk-email-tool/bulk-email-task-manager/BulkEmailContentHistory.jsx +++ b/src/components/bulk-email-tool/bulk-email-task-manager/BulkEmailContentHistory.jsx @@ -109,6 +109,7 @@ function BulkEmailContentHistory({ intl }) { Cell: ({ row }) => ( ), }, diff --git a/src/components/bulk-email-tool/bulk-email-task-manager/BulkEmailPendingTasksAlert.jsx b/src/components/bulk-email-tool/bulk-email-task-manager/BulkEmailPendingTasksAlert.jsx index e75d8d7..3ceec47 100644 --- a/src/components/bulk-email-tool/bulk-email-task-manager/BulkEmailPendingTasksAlert.jsx +++ b/src/components/bulk-email-tool/bulk-email-task-manager/BulkEmailPendingTasksAlert.jsx @@ -16,6 +16,7 @@ export default function BulkEmailPendingTasksAlert() { { expect(await screen.findByText(email.requester)).toBeTruthy(); expect(await screen.findByText(email.sent_to.join(', '))).toBeTruthy(); expect(await screen.findByText(email.email.subject)).toBeTruthy(); + // verify screen reader only + expect(await screen.findByText('0')).toHaveClass('sr-only'); expect(await screen.findAllByText('View Message')).toBeTruthy(); }); }); diff --git a/src/components/page-container/PageContainer.jsx b/src/components/page-container/PageContainer.jsx index bb44656..21ed528 100644 --- a/src/components/page-container/PageContainer.jsx +++ b/src/components/page-container/PageContainer.jsx @@ -65,7 +65,9 @@ export default function PageContainer(props) { courseNumber={courseMetadata.number} courseTitle={courseMetadata.title} /> - {children} +
+ {children} +