diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/CollapsibleFormWidget.jsx b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/CollapsibleFormWidget.jsx index 549b47976..1ff7caf1d 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/CollapsibleFormWidget.jsx +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/CollapsibleFormWidget.jsx @@ -19,11 +19,12 @@ export const CollapsibleFormWidget = ({ isError, subtitle, title, + fontSize, // injected intl, }) => ( @@ -33,8 +34,8 @@ export const CollapsibleFormWidget = ({ >
-
{title}
- {subtitle} +
{title}
+
{subtitle}
{isError && } @@ -42,13 +43,13 @@ export const CollapsibleFormWidget = ({
-
{title}
+
{title}
- + {children}
@@ -56,6 +57,7 @@ export const CollapsibleFormWidget = ({ CollapsibleFormWidget.defaultProps = { subtitle: null, + fontSize: '', }; CollapsibleFormWidget.propTypes = { @@ -63,6 +65,7 @@ CollapsibleFormWidget.propTypes = { isError: PropTypes.bool.isRequired, subtitle: PropTypes.node, title: PropTypes.node.isRequired, + fontSize: PropTypes.string, // injected intl: intlShape.isRequired, }; diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget.jsx b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget.jsx index d9595edf9..4c875aedf 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget.jsx +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget.jsx @@ -41,6 +41,7 @@ export const DurationWidget = ({ return ( diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/HandoutWidget/__snapshots__/index.test.jsx.snap b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/HandoutWidget/__snapshots__/index.test.jsx.snap index e72c9ee02..50ec2aac0 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/HandoutWidget/__snapshots__/index.test.jsx.snap +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/HandoutWidget/__snapshots__/index.test.jsx.snap @@ -2,6 +2,7 @@ exports[`HandoutWidget snapshots snapshots: renders as expected with default props 1`] = ` ( -
- {license === LicenseTypes.allRightsReserved ? : null} - {license === LicenseTypes.creativeCommons ? : null} - {details.attribution ? : null} - {details.noncommercial ? : null} - {details.noDerivatives ? : null} - {details.shareAlike ? : null} +
+ {/* not sure how to handle the edge cases when some of the icons are not displayed */} + {license === LicenseTypes.allRightsReserved ? : null} + {license === LicenseTypes.creativeCommons ? : null} + {details.attribution ? : null} + {details.noncommercial ? : null} + {details.noDerivatives ? : null} + {details.shareAlike ? : null} {license === LicenseTypes.allRightsReserved - ?
+ ?
: null} {license === LicenseTypes.creativeCommons - ?
+ ?
: null}
); diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseDetails.jsx b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseDetails.jsx index cfd9b2c2b..cbcb4b5de 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseDetails.jsx +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseDetails.jsx @@ -6,7 +6,8 @@ import { injectIntl, } from '@edx/frontend-platform/i18n'; import { - Card, + ActionRow, + CheckboxControl, Form, Icon, Stack, @@ -30,15 +31,15 @@ export const LicenseDetails = ({ updateField, }) => ( level !== LicenseLevel.course && details && license !== 'select' ? ( -
+
-
+
{license === LicenseTypes.allRightsReserved ? ( -
+
) @@ -47,39 +48,34 @@ export const LicenseDetails = ({ {license === LicenseTypes.creativeCommons ? ( - - - +
+ + + + -
- )} - actions={} - /> - + + + + + +
- - - - updateField({ - licenseDetails: { - ...details, - noncommercial: !details.noncommercial, - }, - })} - > - - +
+
+
+ + + + -
- )} - actions={( - + + updateField({ @@ -88,33 +84,23 @@ export const LicenseDetails = ({ noncommercial: e.target.checked, }, })} + aria-label="Checkbox" /> - )} - /> - + + +
- - - - updateField({ - licenseDetails: { - ...details, - noDerivatives: !details.noDerivatives, - shareAlike: !details.noDerivatives ? false : details.shareAlike, - }, - })} - > - - +
+
+
+ + + + -
- )} - actions={( - + + updateField({ @@ -124,34 +110,24 @@ export const LicenseDetails = ({ shareAlike: e.target.checked ? false : details.shareAlike, }, })} + aria-label="Checkbox" /> - )} - /> - + +
+
- - - - updateField({ - licenseDetails: { - ...details, - shareAlike: !details.shareAlike, - noDerivatives: !details.shareAlike ? false : details.noDerivatives, - }, - })} - > - - +
+
+
+ + + + -
- )} - actions={( - + + updateField({ licenseDetails: { @@ -160,13 +136,14 @@ export const LicenseDetails = ({ noDerivatives: e.target.checked ? false : details.noDerivatives, }, })} + aria-label="Checkbox" /> - )} - /> - + + +
- - +
+
) : null} diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseDisplay.jsx b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseDisplay.jsx index 865aa704c..33cb0b290 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseDisplay.jsx +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseDisplay.jsx @@ -6,7 +6,6 @@ import { injectIntl, } from '@edx/frontend-platform/i18n'; import { - Card, Stack, Hyperlink, } from '@edx/paragon'; @@ -24,16 +23,15 @@ export const LicenseDisplay = ({ }) => { if (license !== LicenseTypes.select) { return ( - - - - } /> - {licenseDescription} - + +
+
+ +
{licenseDescription}
+
{level !== LicenseLevel.course ? ( diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseSelector.jsx b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseSelector.jsx index c4dc578bb..20d6070a2 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseSelector.jsx +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/LicenseSelector.jsx @@ -31,8 +31,8 @@ export const LicenseSelector = ({ const onLicenseChange = hooks.onSelectLicense({ dispatch: useDispatch() }); const ref = React.useRef(); return ( - - + + ) : null } -
{levelDescription}
+
{levelDescription}
+ {license === LicenseTypes.select ? null :
} ); }; diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/__snapshots__/LicenseBlurb.test.jsx.snap b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/__snapshots__/LicenseBlurb.test.jsx.snap index 14dc40a18..1b44e6342 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/__snapshots__/LicenseBlurb.test.jsx.snap +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/__snapshots__/LicenseBlurb.test.jsx.snap @@ -2,12 +2,38 @@ exports[`LicenseBlurb snapshots snapshots: renders as expected when details.attribution and details.noDerivatives equal true 1`] = `
- - - -
+ + + +
- - - -
+ + + +
- - - -
+ + + +
- - -
+ + +
- -
+ +
- -
+ +
-
+
- - + + + - } - title={ -
- -
- } - /> - + + + +
+
+
- - - +
+
- - } - title={ -
+ + + - -
- } - /> - + + + + + +
- - - +
+
- - } - title={ -
+ + + - -
- } - /> - + + + + + +
- - - - - } - title={ -
+
+
+ + + + - -
- } - /> - + + + + + +
- - +
+
@@ -151,19 +148,19 @@ exports[`LicenseDetails snapshots snapshots: renders as expected with level set exports[`LicenseDetails snapshots snapshots: renders as expected with level set to block and license set to all rights reserved 1`] = `
-
+
-
+
-
+
- - - - } + - +
+
+ +
FormattedMessage component with license description - - +
+
`; exports[`LicenseDisplay snapshots snapshots: renders as expected with level set to block 1`] = ` - - - - } + - +
+
+ +
FormattedMessage component with license description - - +
+
- - - - } + - +
+
+ +
FormattedMessage component with license description - - +
+
- - - - } + - +
+
+ +
FormattedMessage component with license description - - +
+
- + @@ -43,23 +41,26 @@ exports[`LicenseSelector snapshots snapshots: renders as expected with block lev tooltipPlacement="top" /> -
+
+
`; exports[`LicenseSelector snapshots snapshots: renders as expected with default props 1`] = ` - + -
+
+
`; exports[`LicenseSelector snapshots snapshots: renders as expected with library level 1`] = ` - + @@ -137,23 +141,26 @@ exports[`LicenseSelector snapshots snapshots: renders as expected with library l tooltipPlacement="top" /> -
+
+
`; exports[`LicenseSelector snapshots snapshots: renders as expected with no license 1`] = ` - + -
+
+
`; diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/__snapshots__/index.test.jsx.snap b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/__snapshots__/index.test.jsx.snap index 361914e0d..fe6ccb131 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/__snapshots__/index.test.jsx.snap +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/__snapshots__/index.test.jsx.snap @@ -8,7 +8,9 @@ exports[`LicenseWidget snapshots snapshots: renders as expected with default pro details={Object {}} license="all-rights-reserved" /> -
+
-
+
-
+
-
{levelDescription}
+
{levelDescription}
)} title={intl.formatMessage(messages.title)} diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/messages.js b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/messages.js index af08c2c7f..e8b92aa54 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/messages.js +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/LicenseWidget/messages.js @@ -26,7 +26,7 @@ export const messages = { }, deleteLicenseSelection: { id: 'authoring.videoeditor.license.deleteLicenseSelection', - defaultMessage: 'Delete', + defaultMessage: 'Clear and apply the course-level license', description: 'Message presented to user for action to delete license selection', }, allRightsReservedIconsLabel: { diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/ThumbnailWidget/__snapshots__/index.test.jsx.snap b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/ThumbnailWidget/__snapshots__/index.test.jsx.snap index e4d107279..fe8a2075c 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/ThumbnailWidget/__snapshots__/index.test.jsx.snap +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/ThumbnailWidget/__snapshots__/index.test.jsx.snap @@ -2,6 +2,7 @@ exports[`ThumbnailWidget snapshots snapshots: renders as expected where thumbnail uploads are allowed 1`] = ` diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.jsx b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.jsx index df8f44af0..5a670fd30 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.jsx +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.jsx @@ -52,6 +52,7 @@ export const VideoSourceWidget = ({ return ( diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/__snapshots__/CollapsibleFormWidget.test.jsx.snap b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/__snapshots__/CollapsibleFormWidget.test.jsx.snap index 5d35d6ebd..85d7957ab 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/__snapshots__/CollapsibleFormWidget.test.jsx.snap +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/__snapshots__/CollapsibleFormWidget.test.jsx.snap @@ -2,7 +2,7 @@ exports[`CollapsibleFormWidget render snapshots: renders as expected with default props 1`] = `
tiTLE
- SuBTItle +
+ SuBTItle +
tiTLE
@@ -56,7 +60,7 @@ exports[`CollapsibleFormWidget render snapshots: renders as expected with defaul

Some test string @@ -67,7 +71,7 @@ exports[`CollapsibleFormWidget render snapshots: renders as expected with defaul exports[`CollapsibleFormWidget render snapshots: renders with open={true} when there is error 1`] = ` @@ -86,11 +90,15 @@ exports[`CollapsibleFormWidget render snapshots: renders with open={true} when t className="d-flex flex-column flex-grow-1" >

tiTLE
- SuBTItle +
+ SuBTItle +
tiTLE
@@ -125,7 +133,7 @@ exports[`CollapsibleFormWidget render snapshots: renders with open={true} when t

Some test string diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/__snapshots__/DurationWidget.test.jsx.snap b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/__snapshots__/DurationWidget.test.jsx.snap index 4b6e30a5c..7a79d63ec 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/__snapshots__/DurationWidget.test.jsx.snap +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/__snapshots__/DurationWidget.test.jsx.snap @@ -2,6 +2,7 @@ exports[`DurationWidget render snapshots: renders as expected with default props 1`] = `