From d2e89d7b288ab66b8c6d256fd1b1f15c1e124435 Mon Sep 17 00:00:00 2001 From: Ben Warzeski Date: Tue, 22 Feb 2022 12:59:37 -0500 Subject: [PATCH] chore: rename lms service to cms (#15) * chore: rename lms service to cms * fix: remove typo * fix: remove old selector --- src/editors/data/constants/requests.js | 6 ------ src/editors/data/redux/app/.selectors.js.swp | Bin 12288 -> 0 bytes src/editors/data/redux/app/selectors.js | 2 +- src/editors/data/redux/requests/selectors.js | 5 ----- src/editors/data/redux/thunkActions/requests.js | 2 +- src/editors/data/services/{lms => cms}/api.js | 0 .../data/services/{lms => cms}/api.test.js | 0 src/editors/data/services/{lms => cms}/urls.js | 0 src/editors/data/services/{lms => cms}/utils.js | 0 .../data/services/{lms => cms}/utils.test.js | 2 +- 10 files changed, 3 insertions(+), 14 deletions(-) delete mode 100644 src/editors/data/redux/app/.selectors.js.swp rename src/editors/data/services/{lms => cms}/api.js (100%) rename src/editors/data/services/{lms => cms}/api.test.js (100%) rename src/editors/data/services/{lms => cms}/urls.js (100%) rename src/editors/data/services/{lms => cms}/utils.js (100%) rename src/editors/data/services/{lms => cms}/utils.test.js (97%) diff --git a/src/editors/data/constants/requests.js b/src/editors/data/constants/requests.js index d2ac9ccc6..c85baabb9 100644 --- a/src/editors/data/constants/requests.js +++ b/src/editors/data/constants/requests.js @@ -1,11 +1,5 @@ import { StrictDict } from '../../utils'; -export const ReqeustKeys = StrictDict({ - fetchBlock: 'fetchBlock', - fetchUnit: 'fetchUnit', - saveBlock: 'saveBlock', -}); - export const RequestStates = StrictDict({ inactive: 'inactive', pending: 'pending', diff --git a/src/editors/data/redux/app/.selectors.js.swp b/src/editors/data/redux/app/.selectors.js.swp deleted file mode 100644 index e8be6db756dd573373e5c9255f2df3f5fabfe969..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 12288 zcmeI2&yN&E6vqp=fG%M4ASQ&=O2YK$Zucx)$ZiG>g9)P&qOhw8?xAP8z;=7Oo2u$% zVY2K6O~8|9O-#4~iSb1I5Bzm8diUzVKf&m?s=KFWrrBX{#`rqjl^%22`i=Ec#&V|;+&bw#VG78_U&hl_aIGT5o={_L=fskDlhQ0?@1A4 zTb`e$o)VGhn-2FARUeJMAp%5TlE7hh=JZm_e0TEodH%}FIOOyY0U|&IhyW2F0z`la z5CJ0azagO0eQXD_-CxZ3O!3|~^)8z9A_7E!2oM1xKm>>Y5g-CYfCvx)B0vQGg9QA5 zvCj`OrVb%_{QtlF`~SD2jQt8dgloy z`Df?{=zHiX^bq<2x(97SW?mAahX@b>B0vO)01+Sp|003y6~?)~or;UX4}@GmOA4LI zcvVKG5vpz+>d=qEJ0dV&xUQ?hK^loGWx?YD6I*E_H4nsfKZ`UU;#ZRi+cfr^FY_L1 zFgLDZkZY}VS0}4!DrCo3!fEn1t4>#CJ*8zB-*A?i*7H1XToqfofrc}R(d6xO+^O2U z-ELPwl>4zBM8^HvAPKTaOlRwk0Wmy*V?+z_OF@S zApInhN_2zSzNM9QvB$}7%h^tqUFBx3ggtl}v&!jt+1Y`*LFLfN>$vwYP+ state.app; diff --git a/src/editors/data/redux/requests/selectors.js b/src/editors/data/redux/requests/selectors.js index 2a4ba632e..480944f2a 100644 --- a/src/editors/data/redux/requests/selectors.js +++ b/src/editors/data/redux/requests/selectors.js @@ -19,13 +19,8 @@ export const errorCode = (request) => request.error?.response?.data; export const data = (request) => request.data; -export const allowNavigation = ({ requests }) => ( - !Object.keys(requests).some(requestKey => module.isPending(requests[requestKey])) -); - export default StrictDict({ requestStatus, - allowNavigation, isInactive: statusSelector(isInactive), isPending: statusSelector(isPending), isCompleted: statusSelector(isCompleted), diff --git a/src/editors/data/redux/thunkActions/requests.js b/src/editors/data/redux/thunkActions/requests.js index 1389d7447..d7e0bac4b 100644 --- a/src/editors/data/redux/thunkActions/requests.js +++ b/src/editors/data/redux/thunkActions/requests.js @@ -2,7 +2,7 @@ import { StrictDict } from '../../../utils'; import { RequestKeys } from '../../constants/requests'; import { actions, selectors } from '..'; -import * as api from '../../services/lms/api'; +import * as api from '../../services/cms/api'; import * as module from './requests'; diff --git a/src/editors/data/services/lms/api.js b/src/editors/data/services/cms/api.js similarity index 100% rename from src/editors/data/services/lms/api.js rename to src/editors/data/services/cms/api.js diff --git a/src/editors/data/services/lms/api.test.js b/src/editors/data/services/cms/api.test.js similarity index 100% rename from src/editors/data/services/lms/api.test.js rename to src/editors/data/services/cms/api.test.js diff --git a/src/editors/data/services/lms/urls.js b/src/editors/data/services/cms/urls.js similarity index 100% rename from src/editors/data/services/lms/urls.js rename to src/editors/data/services/cms/urls.js diff --git a/src/editors/data/services/lms/utils.js b/src/editors/data/services/cms/utils.js similarity index 100% rename from src/editors/data/services/lms/utils.js rename to src/editors/data/services/cms/utils.js diff --git a/src/editors/data/services/lms/utils.test.js b/src/editors/data/services/cms/utils.test.js similarity index 97% rename from src/editors/data/services/lms/utils.test.js rename to src/editors/data/services/cms/utils.test.js index a033bbae7..d158dac9f 100644 --- a/src/editors/data/services/lms/utils.test.js +++ b/src/editors/data/services/cms/utils.test.js @@ -9,7 +9,7 @@ jest.mock('@edx/frontend-platform/auth', () => ({ getAuthenticatedHttpClient: jest.fn(), })); -describe('lms service utils', () => { +describe('cms service utils', () => { describe('get', () => { it('forwards arguments to authenticatedHttpClient().get', () => { const get = jest.fn((...args) => ({ get: args }));