fix: failure toast and close modal bugs (#352)

src/editors/containers/EditorContainer/__snapshots__/index.test.jsx.snap

@@ -9,14 +9,7 @@ exports[`EditorContainer component render snapshot: initialized. enable save and
     close={[MockFunction closeCancelConfirmModal]}
     confirmAction={
       <Button
-        onClick={
+        onClick={[Function]}
-          Object {
-            "handleCancel": Object {
-              "onClose": [MockFunction props.onClose],
-              "returnFunction": [MockFunction props.returnFunction],
-            },
-          }
-        }
         variant="primary"
       >
         <FormattedMessage
@@ -92,14 +85,7 @@ exports[`EditorContainer component render snapshot: not initialized. disable sav
     close={[MockFunction closeCancelConfirmModal]}
     confirmAction={
       <Button
-        onClick={
+        onClick={[Function]}
-          Object {
-            "handleCancel": Object {
-              "onClose": [MockFunction props.onClose],
-              "returnFunction": [MockFunction props.returnFunction],
-            },
-          }
-        }
         variant="primary"
       >
         <FormattedMessage

src/editors/containers/EditorContainer/index.jsx

@@ -36,7 +36,12 @@ export const EditorContainer = ({
         confirmAction={(
           <Button
             variant="primary"
-            onClick={handleCancel}
+            onClick={() => {
+              handleCancel();
+              if (returnFunction) {
+                closeCancelConfirmModal();
+              }
+            }}
           >
             <FormattedMessage {...messages.okButtonLabel} />
           </Button>

src/editors/data/redux/thunkActions/app.js

@@ -64,13 +64,13 @@ export const initialize = (data) => (dispatch) => {
 /**
  * @param {func} onSuccess
  */
-export const saveBlock = ({ content, returnToUnit }) => (dispatch) => {
+export const saveBlock = (content, returnToUnit) => (dispatch) => {
   dispatch(actions.app.setBlockContent(content));
   dispatch(requests.saveBlock({
     content,
     onSuccess: (response) => {
       dispatch(actions.app.setSaveResponse(response));
-      returnToUnit(response.data)();
+      returnToUnit(response.data);
     },
   }));
 };

src/editors/data/redux/thunkActions/app.test.js

@@ -138,8 +138,8 @@ describe('app thunkActions', () => {
     let returnToUnit;
     let calls;
     beforeEach(() => {
-      returnToUnit = jest.fn((response) => () => response);
+      returnToUnit = jest.fn();
-      thunkActions.saveBlock({ content: testValue, returnToUnit })(dispatch);
+      thunkActions.saveBlock(testValue, returnToUnit)(dispatch);
       calls = dispatch.mock.calls;
     });
     it('dispatches actions.app.setBlockContent with content, before dispatching saveBlock', () => {

src/editors/hooks.js

@@ -54,15 +54,15 @@ export const saveBlock = ({
     attemptSave = true;
   }
   if (attemptSave) {
-    dispatch(thunkActions.app.saveBlock({
+    dispatch(thunkActions.app.saveBlock(
-      returnToUnit: module.navigateCallback({
+      content,
+      module.navigateCallback({
         destination,
         analyticsEvent: analyticsEvt.editorSaveClick,
         analytics,
         returnFunction,
       }),
-      content,
+    ));
-    }));
   }
 };
 

src/editors/hooks.test.jsx

@@ -146,14 +146,14 @@ describe('hooks', () => {
         analytics,
         dispatch,
       });
-      expect(dispatch).toHaveBeenCalledWith(thunkActions.app.saveBlock({
+      expect(dispatch).toHaveBeenCalledWith(thunkActions.app.saveBlock(
-        returnToUnit: navigateCallback({
+        content,
+        navigateCallback({
           destination,
           analyticsEvent: analyticsEvt.editorSaveClick,
           analytics,
         }),
-        content,
+      ));
-      }));
     });
   });