From bc18fffedf4be5be45a29d8c921840af86dbaab7 Mon Sep 17 00:00:00 2001
From: Navin Karkera <navin@opencraft.com>
Date: Wed, 30 Apr 2025 20:41:17 +0000
Subject: [PATCH] refactor: remove custom order function from course libraries
 list (#1865)

---
 src/course-libraries/ReviewTabContent.tsx | 24 ++---------------------
 1 file changed, 2 insertions(+), 22 deletions(-)

diff --git a/src/course-libraries/ReviewTabContent.tsx b/src/course-libraries/ReviewTabContent.tsx
index 1c756c5ca..0c22815a3 100644
--- a/src/course-libraries/ReviewTabContent.tsx
+++ b/src/course-libraries/ReviewTabContent.tsx
@@ -14,9 +14,7 @@ import {
   useToggle,
 } from '@openedx/paragon';
 
-import {
-  tail, keyBy, orderBy, merge, omitBy,
-} from 'lodash';
+import { tail, keyBy } from 'lodash';
 import { useQueryClient } from '@tanstack/react-query';
 import { Loop, Warning } from '@openedx/paragon/icons';
 import messages from './messages';
@@ -116,7 +114,6 @@ const ComponentReviewList = ({
     hits: downstreamInfo,
     isLoading: isIndexDataLoading,
     searchKeywords,
-    searchSortOrder,
     hasError,
     hasNextPage,
     isFetchingNextPage,
@@ -143,10 +140,6 @@ const ComponentReviewList = ({
     () => keyBy(outOfSyncComponents, 'downstreamUsageKey'),
     [outOfSyncComponents],
   );
-  const downstreamInfoByKey = useMemo(
-    () => keyBy(downstreamInfo, 'usageKey'),
-    [downstreamInfo],
-  );
   const queryClient = useQueryClient();
 
   useEffect(() => {
@@ -236,19 +229,6 @@ const ComponentReviewList = ({
     }
   }, [blockData]);
 
-  const orderInfo = useMemo(() => {
-    if (searchSortOrder !== SearchSortOption.RECENTLY_MODIFIED) {
-      return downstreamInfo;
-    }
-    if (isIndexDataLoading) {
-      return [];
-    }
-    let merged = merge(downstreamInfoByKey, outOfSyncComponentsByKey);
-    merged = omitBy(merged, (o) => !o.displayName);
-    const ordered = orderBy(Object.values(merged), 'updated', 'desc');
-    return ordered;
-  }, [downstreamInfoByKey, outOfSyncComponentsByKey]);
-
   if (isIndexDataLoading) {
     return <Loading />;
   }
@@ -259,7 +239,7 @@ const ComponentReviewList = ({
 
   return (
     <>
-      {orderInfo?.map((info) => (
+      {downstreamInfo?.map((info) => (
         <BlockCard
           key={info.usageKey}
           info={info}