From 918370f743d0883bed81503134a0eece487cdf1e Mon Sep 17 00:00:00 2001 From: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Date: Tue, 8 Aug 2023 12:41:15 -0400 Subject: [PATCH] fix: error return while editor loading (#369) --- src/editors/data/services/cms/urls.js | 2 +- src/editors/data/services/cms/urls.test.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/editors/data/services/cms/urls.js b/src/editors/data/services/cms/urls.js index bc72fcd8f..6a13f420d 100644 --- a/src/editors/data/services/cms/urls.js +++ b/src/editors/data/services/cms/urls.js @@ -19,7 +19,7 @@ export const returnUrl = ({ studioEndpointUrl, unitUrl, learningContextId }) => if (unitUrl) { return unit({ studioEndpointUrl, unitUrl }); } - throw new Error('No unit url for return url'); + return ''; }; export const block = ({ studioEndpointUrl, blockId }) => ( diff --git a/src/editors/data/services/cms/urls.test.js b/src/editors/data/services/cms/urls.test.js index 1b7a491e1..5e756b0d0 100644 --- a/src/editors/data/services/cms/urls.test.js +++ b/src/editors/data/services/cms/urls.test.js @@ -55,8 +55,8 @@ describe('cms url methods', () => { .toEqual(`${studioEndpointUrl}/container/${unitUrl.data.ancestors[0].id}`); }); it('throws error if no unit url', () => { - expect(() => { returnUrl({ studioEndpointUrl, unitUrl: null, learningContextId: courseId }); }) - .toThrow('No unit url for return url'); + expect(returnUrl({ studioEndpointUrl, unitUrl: null, learningContextId: courseId })) + .toEqual(''); }); it('returns the library page when given the library', () => { expect(libraryV1({ studioEndpointUrl, learningContextId: libraryV1Id }))