From 8552a96d56683efba0a84d5bd436725a023076f4 Mon Sep 17 00:00:00 2001 From: Ahtisham Shahid Date: Thu, 23 Sep 2021 14:26:23 +0500 Subject: [PATCH] refactor: added env variable for progress graph (#190) * refactor: added env variable for progress graph * refactor: removed API call when progress graph setting is disabled --- .env | 1 + .env.development | 1 + .env.test | 1 + src/index.jsx | 1 + src/pages-and-resources/progress/Settings.jsx | 9 +++++++-- 5 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.env b/.env index 909023cdb..5b28c3098 100644 --- a/.env +++ b/.env @@ -22,3 +22,4 @@ SITE_NAME='' SUPPORT_EMAIL='' SUPPORT_URL='' USER_INFO_COOKIE_NAME='' +ENABLE_PROGRESS_GRAPH_SETTINGS=false diff --git a/.env.development b/.env.development index 89165d505..e9e4c362e 100644 --- a/.env.development +++ b/.env.development @@ -24,3 +24,4 @@ STUDIO_BASE_URL='http://localhost:18010' SUPPORT_EMAIL='support@example.com' SUPPORT_URL='https://support.edx.org' USER_INFO_COOKIE_NAME='edx-user-info' +ENABLE_PROGRESS_GRAPH_SETTINGS=false diff --git a/.env.test b/.env.test index cc3e9abd2..46a29989d 100644 --- a/.env.test +++ b/.env.test @@ -23,3 +23,4 @@ STUDIO_BASE_URL='http://localhost:18010' SUPPORT_EMAIL='support@example.com' SUPPORT_URL='https://support.edx.org' USER_INFO_COOKIE_NAME='edx-user-info' +ENABLE_PROGRESS_GRAPH_SETTINGS=false diff --git a/src/index.jsx b/src/index.jsx index ef1a3e297..0fde0fe44 100755 --- a/src/index.jsx +++ b/src/index.jsx @@ -47,6 +47,7 @@ initialize({ SUPPORT_URL: process.env.SUPPORT_URL || null, SUPPORT_EMAIL: process.env.SUPPORT_EMAIL || null, CALCULATOR_HELP_URL: process.env.CALCULATOR_HELP_URL || null, + ENABLE_PROGRESS_GRAPH_SETTINGS: process.env.ENABLE_PROGRESS_GRAPH_SETTINGS || 'false', }, 'CourseAuthoringConfig'); }, }, diff --git a/src/pages-and-resources/progress/Settings.jsx b/src/pages-and-resources/progress/Settings.jsx index 477682e48..c114c1ae6 100644 --- a/src/pages-and-resources/progress/Settings.jsx +++ b/src/pages-and-resources/progress/Settings.jsx @@ -2,7 +2,7 @@ import { injectIntl, intlShape } from '@edx/frontend-platform/i18n'; import PropTypes from 'prop-types'; import React from 'react'; import * as Yup from 'yup'; - +import { getConfig } from '@edx/frontend-platform'; import FormSwitchGroup from '../../generic/FormSwitchGroup'; import { useAppSetting } from '../../utils'; import AppSettingsModal from '../app-settings-modal/AppSettingsModal'; @@ -10,8 +10,11 @@ import messages from './messages'; function ProgressSettings({ intl, onClose }) { const [disableProgressGraph, saveSetting] = useAppSetting('disableProgressGraph'); + const showProgressGraphSetting = getConfig().ENABLE_PROGRESS_GRAPH_SETTINGS.toLowerCase() === 'true'; - const handleSettingsSave = (values) => saveSetting(!values.enableProgressGraph); + const handleSettingsSave = (values) => { + if (showProgressGraphSetting) { saveSetting(!values.enableProgressGraph); } + }; return ( { ({ handleChange, handleBlur, values }) => ( + showProgressGraphSetting && ( + ) ) }