From 732fd28eb94e299372fcd47d7dfcf171dba4e0a4 Mon Sep 17 00:00:00 2001
From: Muhammad Farhan <muhammad.farhan@arbisoft.com>
Date: Mon, 10 Mar 2025 23:46:01 +0500
Subject: [PATCH] refactor: Improve conditions readability

---
 src/editors/containers/ProblemEditor/data/SettingsParser.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/editors/containers/ProblemEditor/data/SettingsParser.js b/src/editors/containers/ProblemEditor/data/SettingsParser.js
index d2b886358..afc56bde4 100644
--- a/src/editors/containers/ProblemEditor/data/SettingsParser.js
+++ b/src/editors/containers/ProblemEditor/data/SettingsParser.js
@@ -7,9 +7,9 @@ export const popuplateItem = (parentObject, itemName, statekey, metadata, defaul
   const item = _.get(metadata, itemName, null);
 
   // if item is null, undefined, or empty string, use defaultValue
-  const finalValue = (!_.isNil(item) && item !== '') ? item : defaultValue;
+  const finalValue = (_.isNil(item) || item === '') ? defaultValue : item;
 
-  if (allowNull || (!_.isNil(finalValue) && finalValue !== defaultValue)) {
+  if (!_.isNil(finalValue) || allowNull) {
     parent = { ...parentObject, [statekey]: finalValue };
   }
   return parent;