Andal.LND/frontend-app-authoring
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Upgrade frontend-build to v14 (#1052)

Browse Source 
* fix: warnings about Duplicate message id
* fix: paragon's Hyperlink no longer accepts a 'content' attribute
* test: ensure all act() calls are async
* test: Removed "async" from "describe"
* fix: DiscussionsSettings tests
* Don't nest userAction.click in act() -- nested act() statements have
  indeterminent behaviour.
* Use getBy* instead of findBy* with userAction to avoid nested act() statements
* Always await userEvent.click
* Use fireEvent.click when the onClick handlers need to be called
* Use queryBy* instead of getBy* when using .toBeInTheDocument or 
* fix: typo in data-testid
* test: Use useLocation to test route changes
* Don't nest userAction.click in act() -- nested act() statements have
* chore: fix lint:fix and lint errors
* remove "indent" setting from .eslintrc.js
* add @typescript-eslint/ prefix to eslint-disable-line statements where flagged by linter
* changed stylelint setting import-notation to "string"
* test: fix failing tests after upgrade
* fix: css error "target selector was not found"
* chore: upgrades dependency frontend-lib-content-components@2.3.0
* chore: bumps @edx/frontend-component-ai-translations to ^2.1.0

---------

Co-authored-by: Yusuf Musleh <yusuf@opencraft.com>
This commit is contained in:
Jillian
2024-06-22 04:14:46 +09:30
committed by GitHub
parent 3936737b48
commit 6b6d3aaa7a
53 changed files with 3141 additions and 4850 deletions
Download Patch File Download Diff File Expand all files Collapse all files

122
src/grading-settings/assignment-section/utils/validation.js
View File

@@ -53,90 +53,90 @@ export const validationAssignmentFields = (
const courseGradingTypes = courseGraders?.map(grade => grade.type);
switch (assignmentName) {
case assignmentType:
if (assignmentValue === '') {
updateAssignmentErrorList(assignmentName, assignmentId, setErrorList, setShowSavePrompt);
return;
}
if (courseGradingTypes.includes(assignmentValue)) {
case assignmentType:
if (assignmentValue === '') {
updateAssignmentErrorList(assignmentName, assignmentId, setErrorList, setShowSavePrompt);
return;
}
if (courseGradingTypes.includes(assignmentValue)) {
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
DUPLICATE_ASSIGNMENT_NAME,
);
return;
}
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
DUPLICATE_ASSIGNMENT_NAME,
false,
);
return;
}
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
break;
case weightOfTotalGrade:
if (assignmentValue < 0 || assignmentValue > 100 || assignmentValue === '-0') {
break;
case weightOfTotalGrade:
if (assignmentValue < 0 || assignmentValue > 100 || assignmentValue === '-0') {
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
);
return;
}
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
return;
}
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
break;
case assignmentMinCount:
if (assignmentValue <= 0 || assignmentValue === '' || assignmentValue === '-0') {
break;
case assignmentMinCount:
if (assignmentValue <= 0 || assignmentValue === '' || assignmentValue === '-0') {
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
);
return;
}
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
return;
}
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
break;
case assignmentDropCount:
if (assignmentValue < 0 || assignmentValue === '' || assignmentValue === '-0') {
break;
case assignmentDropCount:
if (assignmentValue < 0 || assignmentValue === '' || assignmentValue === '-0') {
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
);
return;
}
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
break;
default:
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
return;
}
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
break;
default:
updateAssignmentErrorList(
assignmentName,
assignmentId,
setErrorList,
setShowSavePrompt,
false,
);
}
};