From 529ec8ddf2015be5b823578b53ed383aaa9320df Mon Sep 17 00:00:00 2001
From: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com>
Date: Tue, 14 Feb 2023 09:34:55 -0800
Subject: [PATCH] feat: fix checkbox colors for feedback (#244)

---
 .../settingsComponents/GroupFeedback/GroupFeedbackRow.jsx | 2 +-
 .../__snapshots__/GroupFeedbackRow.test.jsx.snap          | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/GroupFeedback/GroupFeedbackRow.jsx b/src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/GroupFeedback/GroupFeedbackRow.jsx
index 6f7016573..b5b4bc3e3 100644
--- a/src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/GroupFeedback/GroupFeedbackRow.jsx
+++ b/src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/GroupFeedback/GroupFeedbackRow.jsx
@@ -43,7 +43,7 @@ export const GroupFeedbackRow = ({
             className="mr-4 mt-1"
             value={letter.id}
             checked={value.answers.indexOf(letter.id)}
-            isValid={value.answers.indexOf(letter.id)}
+            isValid={value.answers.indexOf(letter.id) >= 0}
           >{letter.id}
           </Form.Checkbox>
         ))}
diff --git a/src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/GroupFeedback/__snapshots__/GroupFeedbackRow.test.jsx.snap b/src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/GroupFeedback/__snapshots__/GroupFeedbackRow.test.jsx.snap
index 19fecd6e9..410ac07c4 100644
--- a/src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/GroupFeedback/__snapshots__/GroupFeedbackRow.test.jsx.snap
+++ b/src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/GroupFeedback/__snapshots__/GroupFeedbackRow.test.jsx.snap
@@ -37,22 +37,22 @@ exports[`GroupFeedbackRow snapshot snapshot: renders hints row 1`] = `
       <Form.Checkbox
         checked={-1}
         className="mr-4 mt-1"
-        isValid={-1}
+        isValid={false}
       />
       <Form.Checkbox
         checked={-1}
         className="mr-4 mt-1"
-        isValid={-1}
+        isValid={false}
       />
       <Form.Checkbox
         checked={-1}
         className="mr-4 mt-1"
-        isValid={-1}
+        isValid={false}
       />
       <Form.Checkbox
         checked={-1}
         className="mr-4 mt-1"
-        isValid={-1}
+        isValid={false}
       />
     </Row>
   </Component>