Andal.LND/frontend-app-authoring
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: more correct parsing of settings, for scoring; use empty string instead of null for empty attempts. TNL-10433.

Browse Source
This commit is contained in:
Ken Clary
2023-02-09 18:46:29 -05:00
parent 7c0309189f
commit 38e262eee0
6 changed files with 58 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/editors/containers/ProblemEditor/data/SettingsParser.test.js
View File

@@ -4,7 +4,7 @@ import {
dropdownWithFeedbackHints,
numericWithHints,
textInputWithHints,
singleSelectWithHints,
singleSelectWithHints, negativeAttempts,
} from './mockData/problemTestData';
describe('Test Settings to State Parser', () => {
@@ -33,13 +33,18 @@ describe('Test Settings to State Parser', () => {
});
test('Test score settings attempts missing', () => {
const scoreSettings = parseScoringSettings(textInputWithHints.metadata);
expect(scoreSettings.attempts).toBeUndefined();
const scoreSettings = parseScoringSettings(singleSelectWithHints.metadata);
expect(scoreSettings.attempts).toStrictEqual(singleSelectWithHints.state.settings.scoring.attempts);
});
test('Test negative attempts in score', () => {
const scoreSettings = parseScoringSettings(negativeAttempts.metadata);
expect(scoreSettings.attempts).toStrictEqual(negativeAttempts.state.settings.scoring.attempts);
});
test('Test score settings missing', () => {
const settings = parseSettings(singleSelectWithHints.metadata);
expect(settings.scoring).toBeUndefined();
expect(settings.scoring).toStrictEqual(singleSelectWithHints.state.settings.scoring);
});
test('Test invalid randomization', () => {