From 2a9851544e3d0fe8d8b5f5dc7e30d01ff41abd36 Mon Sep 17 00:00:00 2001 From: connorhaugh <49422820+connorhaugh@users.noreply.github.com> Date: Thu, 12 Jan 2023 13:23:02 -0500 Subject: [PATCH] Fix: advanced problem template reference (#194) * fix: correctly reference advanced problem templates * fix: remove console log --- .../ProblemEditor/components/SelectTypeModal/hooks.js | 2 +- .../ProblemEditor/components/SelectTypeModal/hooks.test.js | 2 +- .../data/constants/advancedOlxTemplates/circuitschematic.js | 2 +- src/editors/data/constants/advancedOlxTemplates/customgrader.js | 2 +- .../data/constants/advancedOlxTemplates/drag_and_drop.js | 2 +- .../data/constants/advancedOlxTemplates/formularesponse.js | 2 +- .../data/constants/advancedOlxTemplates/imageresponse.js | 2 +- .../data/constants/advancedOlxTemplates/jsinput_response.js | 2 +- .../data/constants/advancedOlxTemplates/problem_with_hint.js | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/editors/containers/ProblemEditor/components/SelectTypeModal/hooks.js b/src/editors/containers/ProblemEditor/components/SelectTypeModal/hooks.js index 4adec09b5..0f5a13e75 100644 --- a/src/editors/containers/ProblemEditor/components/SelectTypeModal/hooks.js +++ b/src/editors/containers/ProblemEditor/components/SelectTypeModal/hooks.js @@ -20,7 +20,7 @@ export const selectHooks = () => { export const onSelect = (selected, updateField) => () => { if (Object.values(AdvanceProblemKeys).includes(selected)) { - updateField({ problemType: ProblemTypeKeys.ADVANCED, rawOLX: AdvanceProblems[selected] }); + updateField({ problemType: ProblemTypeKeys.ADVANCED, rawOLX: AdvanceProblems[selected].template }); } else { const newOLX = ProblemTypes[selected].template; const { settings, ...newState } = getDataFromOlx({ rawOLX: newOLX, rawSettings: {} }); diff --git a/src/editors/containers/ProblemEditor/components/SelectTypeModal/hooks.test.js b/src/editors/containers/ProblemEditor/components/SelectTypeModal/hooks.test.js index 206205487..771b58b91 100644 --- a/src/editors/containers/ProblemEditor/components/SelectTypeModal/hooks.test.js +++ b/src/editors/containers/ProblemEditor/components/SelectTypeModal/hooks.test.js @@ -48,7 +48,7 @@ describe('SelectTypeModal hooks', () => { module.onSelect(mockAdvancedSelected, mockUpdateField)(); expect(mockUpdateField).toHaveBeenCalledWith({ problemType: ProblemTypeKeys.ADVANCED, - rawOLX: AdvanceProblems[mockAdvancedSelected], + rawOLX: AdvanceProblems[mockAdvancedSelected].template, }); }); test('updateField is called with selected on visual propblems', () => { diff --git a/src/editors/data/constants/advancedOlxTemplates/circuitschematic.js b/src/editors/data/constants/advancedOlxTemplates/circuitschematic.js index 571b7c484..6dc5beb85 100644 --- a/src/editors/data/constants/advancedOlxTemplates/circuitschematic.js +++ b/src/editors/data/constants/advancedOlxTemplates/circuitschematic.js @@ -89,4 +89,4 @@ export const circuitSchematic = ` `; -export default { circuitSchematic }; +export default circuitSchematic; diff --git a/src/editors/data/constants/advancedOlxTemplates/customgrader.js b/src/editors/data/constants/advancedOlxTemplates/customgrader.js index 914fe3bb3..cd0f50555 100644 --- a/src/editors/data/constants/advancedOlxTemplates/customgrader.js +++ b/src/editors/data/constants/advancedOlxTemplates/customgrader.js @@ -76,4 +76,4 @@ export const customGrader = ` `; -export default { customGrader }; +export default customGrader; diff --git a/src/editors/data/constants/advancedOlxTemplates/drag_and_drop.js b/src/editors/data/constants/advancedOlxTemplates/drag_and_drop.js index 40d313652..05f6c77f8 100644 --- a/src/editors/data/constants/advancedOlxTemplates/drag_and_drop.js +++ b/src/editors/data/constants/advancedOlxTemplates/drag_and_drop.js @@ -85,4 +85,4 @@ export const dragAndDrop = ` `; -export default { dragAndDrop }; +export default dragAndDrop; diff --git a/src/editors/data/constants/advancedOlxTemplates/formularesponse.js b/src/editors/data/constants/advancedOlxTemplates/formularesponse.js index ea5d43987..b77a166ae 100644 --- a/src/editors/data/constants/advancedOlxTemplates/formularesponse.js +++ b/src/editors/data/constants/advancedOlxTemplates/formularesponse.js @@ -13,4 +13,4 @@ export const formulaResponse = ` `; -export default { formulaResponse }; +export default formulaResponse; diff --git a/src/editors/data/constants/advancedOlxTemplates/imageresponse.js b/src/editors/data/constants/advancedOlxTemplates/imageresponse.js index b3b7acb6a..36ac9e2c6 100644 --- a/src/editors/data/constants/advancedOlxTemplates/imageresponse.js +++ b/src/editors/data/constants/advancedOlxTemplates/imageresponse.js @@ -30,4 +30,4 @@ export const imageResponse = ` `; -export default { imageResponse }; +export default imageResponse; diff --git a/src/editors/data/constants/advancedOlxTemplates/jsinput_response.js b/src/editors/data/constants/advancedOlxTemplates/jsinput_response.js index 3af5a3761..356a96d66 100644 --- a/src/editors/data/constants/advancedOlxTemplates/jsinput_response.js +++ b/src/editors/data/constants/advancedOlxTemplates/jsinput_response.js @@ -78,4 +78,4 @@ export const jsInputResponse = ` `; -export default { jsInputResponse }; +export default jsInputResponse; diff --git a/src/editors/data/constants/advancedOlxTemplates/problem_with_hint.js b/src/editors/data/constants/advancedOlxTemplates/problem_with_hint.js index 10be3531c..fb79a28d2 100644 --- a/src/editors/data/constants/advancedOlxTemplates/problem_with_hint.js +++ b/src/editors/data/constants/advancedOlxTemplates/problem_with_hint.js @@ -43,4 +43,4 @@ export const problemWithHint = ` `; -export default { problemWithHint }; +export default problemWithHint;