diff --git a/src/pages-and-resources/discussions/app-config-form/apps/lti/LtiConfigForm.jsx b/src/pages-and-resources/discussions/app-config-form/apps/lti/LtiConfigForm.jsx index 373e3ad4c..f493d5986 100644 --- a/src/pages-and-resources/discussions/app-config-form/apps/lti/LtiConfigForm.jsx +++ b/src/pages-and-resources/discussions/app-config-form/apps/lti/LtiConfigForm.jsx @@ -8,7 +8,6 @@ import { useFormik } from 'formik'; import * as Yup from 'yup'; import { useDispatch } from 'react-redux'; -import AppConfigFormDivider from '../shared/AppConfigFormDivider'; import AppExternalLinks from '../shared/AppExternalLinks'; import { @@ -91,7 +90,6 @@ function LtiConfigForm({ )} - ); diff --git a/src/pages-and-resources/discussions/app-config-form/apps/shared/AppExternalLinks.jsx b/src/pages-and-resources/discussions/app-config-form/apps/shared/AppExternalLinks.jsx index 847b30906..885541b1b 100644 --- a/src/pages-and-resources/discussions/app-config-form/apps/shared/AppExternalLinks.jsx +++ b/src/pages-and-resources/discussions/app-config-form/apps/shared/AppExternalLinks.jsx @@ -5,6 +5,8 @@ import { Hyperlink, MailtoLink, } from '@edx/paragon'; +import AppConfigFormDivider from './AppConfigFormDivider'; + import messages from '../lti/messages'; function AppExternalLinks({ @@ -13,26 +15,30 @@ function AppExternalLinks({ title, }) { const { contactEmail, ...links } = externalLinks; - const linkTypes = Object.keys(links); + const linkTypes = Object.keys(links).filter(key => links[key]); return (
-

{intl.formatMessage(messages.linkTextHeading)}

-
- {linkTypes.map((type) => ( - links[type] && ( -
- - {intl.formatMessage(messages[type], { title })} - -
- ) - ))} -
- {contactEmail && ( + {linkTypes.length + ? ( + <> + +

{intl.formatMessage(messages.linkTextHeading)}

+ {linkTypes.map((type) => ( +
+ + { intl.formatMessage(messages[type], { title }) } + +
+ ))} + + ) : null} + {contactEmail && ( +
+
- {contactEmail} + { contactEmail } ), }} /> - )} -
+
+ )}
); } diff --git a/src/pages-and-resources/discussions/app-config-form/messages.js b/src/pages-and-resources/discussions/app-config-form/messages.js index bdef25d61..6bcfe2e55 100644 --- a/src/pages-and-resources/discussions/app-config-form/messages.js +++ b/src/pages-and-resources/discussions/app-config-form/messages.js @@ -36,6 +36,31 @@ const messages = defineMessages({ defaultMessage: 'Piazza', description: 'The name of the Piazza app.', }, + 'appName-edx-next': { + id: 'authoring.discussions.appConfigForm.appName-edx-next', + defaultMessage: 'EdX Next', + description: 'The name of the EdX Next app.', + }, + 'appName-yellowdig': { + id: 'authoring.discussions.appConfigForm.appName-yellowdig', + defaultMessage: 'Yellowdig', + description: 'The name of the yellowdig app.', + }, + 'appName-inscribe': { + id: 'authoring.discussions.appConfigForm.appName-inscribe', + defaultMessage: 'Inscribe', + description: 'The name of the inscribe app.', + }, + 'appName-discourse': { + id: 'authoring.discussions.appConfigForm.appName-discourse', + defaultMessage: 'Discourse', + description: 'The name of the discourse app.', + }, + 'appName-ed-discuss': { + id: 'authoring.discussions.appConfigForm.appName-ed-discuss', + defaultMessage: 'Ed Discuss', + description: 'The name of the Ed Discuss app.', + }, 'appName-legacy': { id: 'authoring.discussions.appConfigForm.appName-legacy', defaultMessage: 'edX Discussions',