From 157e2464aa914de3388067239b345008f7865f5b Mon Sep 17 00:00:00 2001 From: Braden MacDonald Date: Fri, 24 Oct 2025 14:31:51 -0700 Subject: [PATCH] test: fix test code improperly using/missing 'await' (#2560) --- .../ora_settings/Settings.test.jsx | 7 +- .../setting-card/SettingCard.test.jsx | 6 +- .../{SettingCard.jsx => SettingCard.tsx} | 4 +- .../CertificateDetailsForm.test.jsx | 2 +- .../CertificateSignatories.test.jsx | 6 +- .../signatory/SignatoryForm.test.jsx | 20 ++-- .../header-buttons/HeaderButtons.test.jsx | 2 +- src/course-libraries/CourseLibraries.test.tsx | 2 +- .../OutlineAddChildButtons.test.tsx | 8 +- src/course-unit/CourseUnit.test.jsx | 31 +++--- src/custom-pages/CustomPages.test.jsx | 2 +- src/editors/data/services/cms/api.test.ts | 96 +++++++++---------- .../tests/SelectableBox.test.jsx | 4 +- .../tests/SelectableBoxSet.test.jsx | 2 +- .../SelectionModal/SearchSort.test.jsx | 29 ++---- .../files-page/FilesPage.test.jsx | 12 +-- .../videos-page/VideosPage.test.jsx | 4 +- .../info-sidebar/TranscriptTab.test.jsx | 4 +- .../CourseUploadImage.test.jsx | 6 +- .../CreateOrRerunCourseForm.test.jsx | 10 +- .../{messages.js => messages.ts} | 0 ...inkModal.test.jsx => UnlinkModal.test.tsx} | 6 +- .../credit-section/CreditSection.test.jsx | 2 +- .../add-content/AddContent.test.tsx | 12 +-- .../backup-restore/LibraryBackupPage.test.tsx | 12 +-- .../collections/CollectionDetails.test.tsx | 6 +- .../LibraryCollectionPage.test.tsx | 2 +- .../containers/ContainerCard.test.tsx | 2 +- .../containers/ContainerInfo.test.tsx | 2 +- .../apps/openedx/OpenedXConfigForm.test.jsx | 4 +- .../discussions/app-list/AppCard.test.jsx | 2 +- .../discussions/app-list/AppList.test.jsx | 4 +- .../discussions/data/redux.test.js | 10 +- .../pages/PageCard.test.jsx | 12 +-- .../ScheduleAndDetails.test.jsx | 4 +- .../details-section/DetailsSection.test.jsx | 4 +- .../InstructorsSection.test.jsx | 64 +++++++------ .../InstructorContainer.test.jsx | 10 +- .../{messages.js => messages.ts} | 0 .../{messages.js => messages.ts} | 0 .../InstructorsSection.test.jsx | 52 +++++----- .../LicenseCommonsOptions.test.jsx | 21 ++-- .../license-selector/LicenseSelector.test.jsx | 20 ++-- .../{messages.js => messages.ts} | 0 .../entrance-exam/EntranceExam.test.jsx | 35 ++++--- .../GradeRequirements.test.jsx | 20 ++-- .../CollapsibleStateWithAction.test.jsx | 12 +-- .../import-tags/ImportTagsWizard.test.jsx | 4 +- .../textbook-form/TextbookForm.test.jsx | 4 +- 49 files changed, 286 insertions(+), 297 deletions(-) rename src/advanced-settings/setting-card/{SettingCard.jsx => SettingCard.tsx} (97%) rename src/generic/create-or-rerun-course/{messages.js => messages.ts} (100%) rename src/generic/unlink-modal/{UnlinkModal.test.jsx => UnlinkModal.test.tsx} (96%) rename src/schedule-and-details/instructors-section/instructor-container/{messages.js => messages.ts} (100%) rename src/schedule-and-details/instructors-section/{messages.js => messages.ts} (100%) rename src/schedule-and-details/{messages.js => messages.ts} (100%) diff --git a/plugins/course-apps/ora_settings/Settings.test.jsx b/plugins/course-apps/ora_settings/Settings.test.jsx index 86522188d..0dd79a13f 100644 --- a/plugins/course-apps/ora_settings/Settings.test.jsx +++ b/plugins/course-apps/ora_settings/Settings.test.jsx @@ -125,10 +125,13 @@ describe('ORASettings', () => { }); it('Displays title, helper text and badge when flexible peer grading button is enabled', async () => { - renderComponent(); await mockStore({ apiStatus: 200, enabled: true }); + renderComponent(); - waitFor(() => { + const checkbox = await screen.getByRole('checkbox', { name: /Flex Peer Grading/ }); + expect(checkbox).toBeChecked(); + + await waitFor(() => { const label = screen.getByText(messages.enableFlexPeerGradeLabel.defaultMessage); const enableBadge = screen.getByTestId('enable-badge'); diff --git a/src/advanced-settings/setting-card/SettingCard.test.jsx b/src/advanced-settings/setting-card/SettingCard.test.jsx index 43665b416..3dce02dca 100644 --- a/src/advanced-settings/setting-card/SettingCard.test.jsx +++ b/src/advanced-settings/setting-card/SettingCard.test.jsx @@ -1,4 +1,3 @@ -import React from 'react'; import { fireEvent, render, waitFor } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { IntlProvider } from '@edx/frontend-platform/i18n'; @@ -22,7 +21,6 @@ jest.mock('react-textarea-autosize', () => jest.fn((props) => (