Andal.LND/frontend-app-authoring
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #240 from openedx/kenclary/TNL-10433

Browse Source 
fix: more correct parsing of settings, for scoring; use empty string instead of null for empty attempts. TNL-10433.
This commit is contained in:
kenclary
2023-02-10 12:01:10 -05:00
committed by GitHub
parent eff3df7115 38e262eee0
commit 0367ef776e
6 changed files with 58 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/editors/containers/ProblemEditor/data/SettingsParser.js
View File

@@ -15,11 +15,15 @@ export const parseScoringSettings = (metadata) => {
let scoring = {};
let attempts = popuplateItem({}, 'max_attempts', 'number', metadata);
if (!_.isEmpty(attempts)) {
const unlimited = _.isNaN(attempts.number);
attempts = { ...attempts, unlimited };
scoring = { ...scoring, attempts };
if (_.isEmpty(attempts) || _.isNaN(attempts.number)) {
attempts = { unlimited: true, number: '' };
} else {
attempts.unlimited = false;
if (attempts.number < 0) {
attempts.number = 0;
}
}
scoring = { ...scoring, attempts };
scoring = popuplateItem(scoring, 'weight', 'weight', metadata);