From efc07aac67da32278c68e14ad374a24eef69852e Mon Sep 17 00:00:00 2001 From: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com> Date: Thu, 1 Aug 2024 16:06:20 +0500 Subject: [PATCH] fix: fix datadog js errors (#1296) --- src/recommendations/track.js | 4 ++-- src/register/RegistrationFields/NameField/validator.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/recommendations/track.js b/src/recommendations/track.js index 5d826a3e..9a18b974 100644 --- a/src/recommendations/track.js +++ b/src/recommendations/track.js @@ -15,7 +15,7 @@ const generateProductKey = (product) => ( export const getProductMapping = (recommendedProducts) => recommendedProducts.map((product) => ({ product_key: generateProductKey(product), product_line: product.cardType, - product_source: product.productSource.name, + product_source: product?.productSource?.name, })); export const trackRecommendationClick = (product, position, userId) => { @@ -25,7 +25,7 @@ export const trackRecommendationClick = (product, position, userId) => { recommendation_type: product.recommendationType, product_key: generateProductKey(product), product_line: product.cardType, - product_source: product.productSource.name, + product_source: product?.productSource?.name, user_id: userId, }); diff --git a/src/register/RegistrationFields/NameField/validator.js b/src/register/RegistrationFields/NameField/validator.js index aefaedfb..c8e1d09c 100644 --- a/src/register/RegistrationFields/NameField/validator.js +++ b/src/register/RegistrationFields/NameField/validator.js @@ -11,7 +11,7 @@ export const INVALID_NAME_REGEX = /https?:\/\/(?:[-\w.]|(?:%[\da-fA-F]{2}))*/g; const validateName = (value, formatMessage) => { let fieldError = ''; - if (!value.trim()) { + if (!value || (value && !value.trim())) { fieldError = formatMessage(messages['empty.name.field.error']); } else if (URL_REGEX.test(value) || HTML_REGEX.test(value) || INVALID_NAME_REGEX.test(value)) { fieldError = formatMessage(messages['name.validation.message']);