From cda8f497236564b41fef5cbde7a411d13201273c Mon Sep 17 00:00:00 2001 From: Waheed Ahmed Date: Thu, 17 Jun 2021 17:02:50 +0500 Subject: [PATCH] temp: add redesign launch experiment and events (#358) --- src/legacy/login/LoginPage.jsx | 7 +++++++ src/legacy/register/RegistrationPage.jsx | 6 +++--- src/legacy/register/tests/RegistrationPage.test.jsx | 10 ---------- src/redesign/login/LoginPage.jsx | 7 +++++++ src/redesign/register/RegistrationPage.jsx | 4 ++-- src/redesign/register/tests/RegistrationPage.test.jsx | 10 ---------- 6 files changed, 19 insertions(+), 25 deletions(-) diff --git a/src/legacy/login/LoginPage.jsx b/src/legacy/login/LoginPage.jsx index ffe9d1f1..c296d7a5 100644 --- a/src/legacy/login/LoginPage.jsx +++ b/src/legacy/login/LoginPage.jsx @@ -175,6 +175,13 @@ class LoginPage extends React.Component { if (this.props.loginResult.success) { setSurveyCookie('login'); + + // Fire optimizely events + window.optimizely = window.optimizely || []; + window.optimizely.push({ + type: 'event', + eventName: 'authn-login-coversion', + }); } return ( diff --git a/src/legacy/register/RegistrationPage.jsx b/src/legacy/register/RegistrationPage.jsx index 11ba8ae4..7b012d4f 100644 --- a/src/legacy/register/RegistrationPage.jsx +++ b/src/legacy/register/RegistrationPage.jsx @@ -446,12 +446,12 @@ class RegistrationPage extends React.Component { if (this.props.registrationResult.success) { setSurveyCookie('register'); - window.optimizely = window.optimizely || []; // Fire optimizely events + window.optimizely = window.optimizely || []; window.optimizely.push({ type: 'event', - eventName: 'van_504_total_registrations', + eventName: 'authn-register-conversion', }); if (this.state.optimizelyExperimentName !== 'progressiveProfilingConcept1') { @@ -610,7 +610,7 @@ class RegistrationPage extends React.Component { }} /> - {getConfig().REGISTRATION_OPTIONAL_FIELDS && this.state.optimizelyExperimentName !== 'progressiveProfilingConcept1' ? ( + {getConfig().REGISTRATION_OPTIONAL_FIELDS && localStorage.getItem('DESIGN_NAME') !== 'redesign' ? ( { jest.clearAllMocks(); }); - it('should not show optional field check when optimizely experiment is set', () => { - window.optimizelyExperimentName = 'progressiveProfilingConcept1'; - - const registrationPage = mount(reduxWrapper()); - expect(registrationPage.find('RegistrationPage').state('optimizelyExperimentName')).toEqual('progressiveProfilingConcept1'); - expect(registrationPage.find('#optional').length).toEqual(0); - - delete window.optimizelyExperimentName; - }); - it('should toggle optional fields state on checkbox click', () => { const registrationPage = mount(reduxWrapper()); diff --git a/src/redesign/login/LoginPage.jsx b/src/redesign/login/LoginPage.jsx index fddeb3c9..c69c45e2 100644 --- a/src/redesign/login/LoginPage.jsx +++ b/src/redesign/login/LoginPage.jsx @@ -190,6 +190,13 @@ class LoginPage extends React.Component { if (this.props.loginResult.success) { setSurveyCookie('login'); + + // Fire optimizely events + window.optimizely = window.optimizely || []; + window.optimizely.push({ + type: 'event', + eventName: 'authn-login-coversion', + }); } return ( diff --git a/src/redesign/register/RegistrationPage.jsx b/src/redesign/register/RegistrationPage.jsx index 27575a83..1e11de85 100644 --- a/src/redesign/register/RegistrationPage.jsx +++ b/src/redesign/register/RegistrationPage.jsx @@ -494,7 +494,7 @@ class RegistrationPage extends React.Component { // Fire optimizely events window.optimizely.push({ type: 'event', - eventName: 'VAN-504-user-registered', + eventName: 'authn-register-conversion', }); if (window.optimizelyExperimentName !== 'VAN-504-PP-Exp') { @@ -626,7 +626,7 @@ class RegistrationPage extends React.Component { }} /> - {getConfig().REGISTRATION_OPTIONAL_FIELDS && this.state.optimizelyExperimentName !== 'progressive_profiling_phase1' ? ( + {getConfig().REGISTRATION_OPTIONAL_FIELDS && localStorage.getItem('DESIGN_NAME') !== 'redesign' ? ( { expect(analytics.sendPageEvent).toHaveBeenCalledWith('login_and_registration', 'register'); }); - it('should not show optional field check when optimizely experiment is set', () => { - window.optimizelyExperimentName = 'progressive_profiling_phase1'; - - const registrationPage = mount(reduxWrapper()); - expect(registrationPage.find('RegistrationPage').state('optimizelyExperimentName')).toEqual('progressive_profiling_phase1'); - expect(registrationPage.find('#optional').length).toEqual(0); - - delete window.optimizelyExperimentName; - }); - // ******** shouldComponentUpdate tests ******** it('should populate form with pipeline user details', () => {