From af7edd8a3fd31ece3d29d68112f45fd4ae62a1fe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9gis=20Behmo?= <regis@behmo.com>
Date: Wed, 2 Apr 2025 12:48:48 +0200
Subject: [PATCH] =?UTF-8?q?chore:=20remove=20husky=20=F0=9F=AA=93?=
 =?UTF-8?q?=F0=9F=90=B6?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We remove husky, which is triggering pre-push git hooks, including
running "npm lint". This is causing failures when building Docker
images, because "npm clean-install --omit=dev" automatically triggers "npm
prepare", which attemps to run "husky". But husky is not listed in the
build dependencies, only in devDependencies. As a consequence, package
installation is failing with the following error:

        14.13 > @edx/frontend-app-ora-grading@0.0.1 prepare
        14.13 > husky install
        14.13
        14.15 sh: 1: husky: not found

Similar to: https://github.com/openedx/frontend-app-learning/pull/1622
---
 package-lock.json | 17 -----------------
 package.json      |  6 ------
 2 files changed, 23 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 29551f7d..bbd8b9a0 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -54,7 +54,6 @@
         "eslint-plugin-import": "2.31.0",
         "glob": "7.2.3",
         "history": "5.3.0",
-        "husky": "9.1.7",
         "jest": "29.7.0",
         "react-test-renderer": "^18.3.1"
       }
@@ -11364,22 +11363,6 @@
         "node": ">=10.17.0"
       }
     },
-    "node_modules/husky": {
-      "version": "9.1.7",
-      "resolved": "https://registry.npmjs.org/husky/-/husky-9.1.7.tgz",
-      "integrity": "sha512-5gs5ytaNjBrh5Ow3zrvdUUY+0VxIuWVL4i9irt6friV+BqdCfmV11CQTWMiBYWHbXhco+J1kHfTOUkePhCDvMA==",
-      "dev": true,
-      "license": "MIT",
-      "bin": {
-        "husky": "bin.js"
-      },
-      "engines": {
-        "node": ">=18"
-      },
-      "funding": {
-        "url": "https://github.com/sponsors/typicode"
-      }
-    },
     "node_modules/hyphenate-style-name": {
       "version": "1.1.0",
       "resolved": "https://registry.npmjs.org/hyphenate-style-name/-/hyphenate-style-name-1.1.0.tgz",
diff --git a/package.json b/package.json
index f32bb844..c21ff299 100644
--- a/package.json
+++ b/package.json
@@ -19,11 +19,6 @@
     "dev": "PUBLIC_PATH=/authn/ MFE_CONFIG_API_URL='http://localhost:8000/api/mfe_config/v1' fedx-scripts webpack-dev-server --progress --host apps.local.openedx.io",
     "test": "fedx-scripts jest --coverage --passWithNoTests"
   },
-  "husky": {
-    "hooks": {
-      "pre-commit": "npm run lint"
-    }
-  },
   "author": "edX",
   "license": "AGPL-3.0",
   "homepage": "https://github.com/openedx/frontend-app-authn#readme",
@@ -79,7 +74,6 @@
     "eslint-plugin-import": "2.31.0",
     "glob": "7.2.3",
     "history": "5.3.0",
-    "husky": "9.1.7",
     "jest": "29.7.0",
     "react-test-renderer": "^18.3.1"
   }