From a3d618735e73ec7ffaccf5982958bd994ab538f5 Mon Sep 17 00:00:00 2001
From: Zainab Amir <zainab.amir@arbisoft.com>
Date: Mon, 8 Feb 2021 17:49:57 +0500
Subject: [PATCH] fix bug: Error on correct password submission (#129)

---
 src/reset-password/ResetPasswordPage.jsx            | 4 ++--
 src/reset-password/tests/ResetPasswordPage.test.jsx | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/reset-password/ResetPasswordPage.jsx b/src/reset-password/ResetPasswordPage.jsx
index aba1e42a..3b444f99 100644
--- a/src/reset-password/ResetPasswordPage.jsx
+++ b/src/reset-password/ResetPasswordPage.jsx
@@ -32,12 +32,12 @@ const ResetPasswordPage = (props) => {
   const [bannerErrorMessage, setbannerErrorMessage] = useState('');
 
   useEffect(() => {
-    if (props.errors) {
+    if (props.status === 'failure' && props.errors) {
       setbannerErrorMessage(props.errors);
       setvalidationMessage(props.errors);
       setPasswordValidValue(false);
     }
-  }, [props.status === 'failure']);
+  }, [props.status]);
 
   const validatePasswordFromBackend = async (newPassword) => {
     let errorMessage;
diff --git a/src/reset-password/tests/ResetPasswordPage.test.jsx b/src/reset-password/tests/ResetPasswordPage.test.jsx
index deee3e75..e505d704 100644
--- a/src/reset-password/tests/ResetPasswordPage.test.jsx
+++ b/src/reset-password/tests/ResetPasswordPage.test.jsx
@@ -224,6 +224,7 @@ describe('ResetPasswordPage', () => {
       token_status: 'valid',
       token: 'token',
       errors: validationMessage,
+      status: 'failure',
     };
 
     const resetPasswordPage = mount(reduxWrapper(<IntlResetPasswordPage {...props} />));