From 56d8a106940f386fa5b9a7df9688a2ed8f2936f9 Mon Sep 17 00:00:00 2001 From: "Adolfo R. Brandes" Date: Thu, 12 Mar 2026 07:38:30 -0300 Subject: [PATCH] fix: add missing deps to registrationResult useEffect Add USER_RETENTION_COOKIE_NAME and SESSION_COOKIE_DOMAIN to the dependency array instead of suppressing react-hooks/exhaustive-deps. Both are config constants from useAppConfig() that never change at runtime, so behavior is unchanged. Co-Authored-By: Claude Opus 4.6 --- src/register/RegistrationPage.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/register/RegistrationPage.jsx b/src/register/RegistrationPage.jsx index bf69c6e1..73560e43 100644 --- a/src/register/RegistrationPage.jsx +++ b/src/register/RegistrationPage.jsx @@ -205,7 +205,7 @@ const RegistrationPage = (props) => { // This is used by the "User Retention Rate Event" on GTM setCookie(USER_RETENTION_COOKIE_NAME, true, SESSION_COOKIE_DOMAIN); } - }, [registrationResult]); // eslint-disable-line react-hooks/exhaustive-deps + }, [registrationResult, USER_RETENTION_COOKIE_NAME, SESSION_COOKIE_DOMAIN]); const handleOnChange = (event) => { const { name } = event.target;