From 488644f50d7c36deb107a14632b0781c198e59a5 Mon Sep 17 00:00:00 2001 From: Blue Date: Mon, 4 Mar 2024 16:14:41 +0500 Subject: [PATCH] fix: remove rebrand experiment from authn (#1187) Description: Remove rebrand experiment code from Authn VAN-1858 --- src/base-container/data/constants.js | 4 ---- src/base-container/index.jsx | 21 ++----------------- .../tests/BaseContainer.test.jsx | 17 --------------- 3 files changed, 2 insertions(+), 40 deletions(-) delete mode 100644 src/base-container/data/constants.js diff --git a/src/base-container/data/constants.js b/src/base-container/data/constants.js deleted file mode 100644 index adde2561..00000000 --- a/src/base-container/data/constants.js +++ /dev/null @@ -1,4 +0,0 @@ -const IMAGE_LAYOUT = 'image-layout'; -const DEFAULT_LAYOUT = 'default-layout'; - -export { DEFAULT_LAYOUT, IMAGE_LAYOUT }; diff --git a/src/base-container/index.jsx b/src/base-container/index.jsx index 72c6b9c5..46f135f9 100644 --- a/src/base-container/index.jsx +++ b/src/base-container/index.jsx @@ -1,4 +1,4 @@ -import React, { useEffect, useState } from 'react'; +import React from 'react'; import { getConfig } from '@edx/frontend-platform'; import { breakpoints } from '@openedx/paragon'; @@ -11,28 +11,11 @@ import { ImageExtraSmallLayout, ImageLargeLayout, ImageMediumLayout, ImageSmallLayout, } from './components/image-layout'; import { AuthLargeLayout, AuthMediumLayout, AuthSmallLayout } from './components/welcome-page-layout'; -import { DEFAULT_LAYOUT, IMAGE_LAYOUT } from './data/constants'; const BaseContainer = ({ children, showWelcomeBanner, fullName }) => { - const [baseContainerVersion, setBaseContainerVersion] = useState(DEFAULT_LAYOUT); const enableImageLayout = getConfig().ENABLE_IMAGE_LAYOUT; - useEffect(() => { - const initRebrandExperiment = () => { - if (window.experiments?.rebrandExperiment) { - setBaseContainerVersion(window.experiments?.rebrandExperiment?.variation); - } else { - window.experiments = window.experiments || {}; - window.experiments.rebrandExperiment = {}; - window.experiments.rebrandExperiment.handleLoaded = () => { - setBaseContainerVersion(window.experiments?.rebrandExperiment?.variation); - }; - } - }; - initRebrandExperiment(); - }, []); - - if (baseContainerVersion === IMAGE_LAYOUT || enableImageLayout) { + if (enableImageLayout) { return (
diff --git a/src/base-container/tests/BaseContainer.test.jsx b/src/base-container/tests/BaseContainer.test.jsx index 293bc07b..b7af9b18 100644 --- a/src/base-container/tests/BaseContainer.test.jsx +++ b/src/base-container/tests/BaseContainer.test.jsx @@ -25,23 +25,6 @@ describe('Base component tests', () => { expect(container.querySelector('.large-screen-svg-primary')).toBeDefined(); }); - it('[experiment] should show image layout for treatment group', () => { - window.experiments = { - rebrandExperiment: { - variation: 'image-layout', - }, - }; - - const { container } = render( - - - , - LargeScreen, - ); - - expect(container.querySelector('.banner__image')).toBeDefined(); - }); - it('renders Image layout when ENABLE_IMAGE_LAYOUT configuration is enabled', () => { mergeConfig({ ENABLE_IMAGE_LAYOUT: true,