From 12670240b31b4785ee4e0ec06f3e6627aeb4eb27 Mon Sep 17 00:00:00 2001 From: "Adolfo R. Brandes" Date: Fri, 13 Mar 2026 08:27:01 -0300 Subject: [PATCH] style: add explanatory comments for late imports after jest.mock() Co-Authored-By: Claude Opus 4.6 --- src/login/tests/LoginPage.test.jsx | 2 ++ src/register/RegistrationPage.test.jsx | 2 ++ .../components/tests/ConfigurableRegistrationForm.test.jsx | 2 ++ src/register/components/tests/RegistrationFailure.test.jsx | 2 ++ src/register/components/tests/ThirdPartyAuth.test.jsx | 2 ++ 5 files changed, 10 insertions(+) diff --git a/src/login/tests/LoginPage.test.jsx b/src/login/tests/LoginPage.test.jsx index 48042fe9..2deb030c 100644 --- a/src/login/tests/LoginPage.test.jsx +++ b/src/login/tests/LoginPage.test.jsx @@ -30,6 +30,8 @@ jest.mock('@openedx/frontend-base', () => ({ getAuthService: jest.fn(), })); +// jest.mock() must be called before importing the mocked module's members, +// so this import intentionally comes after the mock declaration above. // eslint-disable-next-line import/first import { sendPageEvent, sendTrackEvent } from '@openedx/frontend-base'; diff --git a/src/register/RegistrationPage.test.jsx b/src/register/RegistrationPage.test.jsx index 399b33c0..df17be46 100644 --- a/src/register/RegistrationPage.test.jsx +++ b/src/register/RegistrationPage.test.jsx @@ -44,6 +44,8 @@ jest.mock('@openedx/frontend-base', () => ({ getLocale: jest.fn(), })); +// jest.mock() must be called before importing the mocked module's members, +// so this import intentionally comes after the mock declaration above. // eslint-disable-next-line import/first import { getLocale, sendPageEvent, sendTrackEvent } from '@openedx/frontend-base'; diff --git a/src/register/components/tests/ConfigurableRegistrationForm.test.jsx b/src/register/components/tests/ConfigurableRegistrationForm.test.jsx index 8c93a196..ebc05e96 100644 --- a/src/register/components/tests/ConfigurableRegistrationForm.test.jsx +++ b/src/register/components/tests/ConfigurableRegistrationForm.test.jsx @@ -20,6 +20,8 @@ jest.mock('@openedx/frontend-base', () => ({ getLocale: jest.fn(), })); +// jest.mock() must be called before importing the mocked module's members, +// so this import intentionally comes after the mock declaration above. // eslint-disable-next-line import/first import { getLocale } from '@openedx/frontend-base'; diff --git a/src/register/components/tests/RegistrationFailure.test.jsx b/src/register/components/tests/RegistrationFailure.test.jsx index fe94cd69..63aefca0 100644 --- a/src/register/components/tests/RegistrationFailure.test.jsx +++ b/src/register/components/tests/RegistrationFailure.test.jsx @@ -22,6 +22,8 @@ jest.mock('@openedx/frontend-base', () => ({ getLocale: jest.fn(), })); +// jest.mock() must be called before importing the mocked module's members, +// so this import intentionally comes after the mock declaration above. // eslint-disable-next-line import/first import { getLocale } from '@openedx/frontend-base'; diff --git a/src/register/components/tests/ThirdPartyAuth.test.jsx b/src/register/components/tests/ThirdPartyAuth.test.jsx index 09d03670..2a229a9f 100644 --- a/src/register/components/tests/ThirdPartyAuth.test.jsx +++ b/src/register/components/tests/ThirdPartyAuth.test.jsx @@ -21,6 +21,8 @@ jest.mock('@openedx/frontend-base', () => ({ getLocale: jest.fn(), })); +// jest.mock() must be called before importing the mocked module's members, +// so this import intentionally comes after the mock declaration above. // eslint-disable-next-line import/first import { getLocale } from '@openedx/frontend-base';